mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-01-08 04:55:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

scoutfs: add server error messages

Browse Source 
Add specific error messages for failures that can happen as the server
commits log trees from the client.  These are severe enough that we'd
like to know about them.

Signed-off-by: Zach Brown <zab@versity.com>
This commit is contained in:
Zach Brown
2020-04-10 10:58:23 -07:00
committed by Zach Brown
parent ae9e060fbf
commit 192453e717
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
kmod/src/server.c
View File

@@ -474,8 +474,10 @@ static int server_commit_log_trees(struct super_block *sb,
lt = arg;
ret = hold_commit(sb);
if (ret < 0)
if (ret < 0) {
scoutfs_err(sb, "server error preparing commit: %d", ret);
goto out;
}
mutex_lock(&server->logs_mutex);
@@ -485,13 +487,17 @@ static int server_commit_log_trees(struct super_block *sb,
ltk.nr = le64_to_be64(lt->nr);
ret = scoutfs_btree_lookup(sb, &super->logs_root,
&ltk, sizeof(ltk), &iref);
if (ret < 0 && ret != -ENOENT)
if (ret < 0 && ret != -ENOENT) {
scoutfs_err(sb, "server error finding client logs: %d", ret);
goto unlock;
}
if (ret == 0) {
if (iref.val_len == sizeof(struct scoutfs_log_trees_val)) {
memcpy(&ltv, iref.val, iref.val_len);
} else {
ret = -EIO;
scoutfs_err(sb, "server error, invalid log item: %d",
ret);
}
scoutfs_btree_put_iref(&iref);
if (ret < 0)
@@ -517,11 +523,15 @@ static int server_commit_log_trees(struct super_block *sb,
ret = scoutfs_btree_update(sb, &server->alloc, &server->wri,
&super->logs_root, &ltk, sizeof(ltk),
&ltv, sizeof(ltv));
if (ret < 0)
scoutfs_err(sb, "server error updating client logs: %d", ret);
unlock:
mutex_unlock(&server->logs_mutex);
ret = apply_commit(sb, ret);
if (ret < 0)
scoutfs_err(sb, "server error commiting client logs: %d", ret);
out:
WARN_ON_ONCE(ret < 0);
return scoutfs_net_response(sb, conn, cmd, id, ret, NULL, 0);