mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2025-12-23 05:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

scoutfs: free our dentry info

Browse Source 
Stop leaking dentry_info allocations by adding a dentry_op with a
d_release that frees our dentry info allocation.  rmmod tests no longer
fail when dmesg screams that we have slab caches that still have
allocated objects.

Signed-off-by: Zach Brown <zab@versity.com>
s
This commit is contained in:
Zach Brown
2016-03-25 11:08:20 -07:00
parent 434cbb9c78
commit 6834100251
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
kmod/src/dir.c
View File

@@ -128,6 +128,20 @@ struct dentry_info {
static struct kmem_cache *scoutfs_dentry_cachep;
static void scoutfs_d_release(struct dentry *dentry)
{
struct dentry_info *di = dentry->d_fsdata;
if (di) {
kmem_cache_free(scoutfs_dentry_cachep, di);
dentry->d_fsdata = NULL;
}
}
static const struct dentry_operations scoutfs_dentry_ops = {
.d_release = scoutfs_d_release,
};
static struct dentry_info *alloc_dentry_info(struct dentry *dentry)
{
struct dentry_info *di;
@@ -141,8 +155,11 @@ static struct dentry_info *alloc_dentry_info(struct dentry *dentry)
return ERR_PTR(-ENOMEM);
spin_lock(&dentry->d_lock);
if (!dentry->d_fsdata)
if (!dentry->d_fsdata) {
dentry->d_fsdata = di;
d_set_d_op(dentry, &scoutfs_dentry_ops);
}
spin_unlock(&dentry->d_lock);
if (di != dentry->d_fsdata)