mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-04-21 22:10:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Verify that log tree commit is for sending rid

Browse Source 
We were trusting the rid in the log trees struct that the client sent.
Compare it to our recorded rid on the connection and fail if the client
sent the wrong rid.

Signed-off-by: Zach Brown <zab@versity.com>
This commit is contained in:
Zach Brown
2021-08-04 10:05:11 -07:00
parent 7cf9cd8c20
commit 89b5865a4c
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
kmod/src/server.c
View File

@@ -882,6 +882,7 @@ static int server_commit_log_trees(struct super_block *sb,
u8 cmd, u64 id, void *arg, u16 arg_len)
{
struct scoutfs_super_block *super = &SCOUTFS_SB(sb)->super;
const u64 rid = scoutfs_net_client_rid(conn);
DECLARE_SERVER_INFO(sb, server);
SCOUTFS_BTREE_ITEM_REF(iref);
struct scoutfs_log_trees lt;
@@ -896,6 +897,11 @@ static int server_commit_log_trees(struct super_block *sb,
/* don't modify the caller's log_trees */
memcpy(&lt, arg, sizeof(struct scoutfs_log_trees));
if (le64_to_cpu(lt.rid) != rid) {
ret = -EIO;
goto out;
}
scoutfs_server_hold_commit(sb);
mutex_lock(&server->logs_mutex);