mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-02-07 19:20:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

scoutfs: only trace read qourum blocks after io

Browse Source 
We have trace points as blocks are read, but the reads are cached as
buffer heads.  The iteration helpers are used to referenced cached
blocks a few times in each voting cycle and we end up tracing cached
read blocks multiple times.  This uses a bit on the buffer_head to only
trace a cached block the first time it's read.

Signed-off-by: Zach Brown <zab@versity.com>
This commit is contained in:
Zach Brown
2019-05-30 14:03:39 -07:00
committed by Zach Brown
parent 4df35efbc0
commit abd7ffc247
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
kmod/src/quorum.c
View File

@@ -256,6 +256,13 @@ out:
return ret;
}
enum {
BH_ScoutfsTraced = BH_PrivateStart,
};
BUFFER_FNS(ScoutfsTraced, scoutfs_traced) /* has been traced */
TAS_BUFFER_FNS(ScoutfsTraced, scoutfs_traced)
/*
* The caller is about to read the current version of a set of quorum
* blocks. We invalidate all the quorum blocks in the cache and
@@ -279,6 +286,7 @@ static void readahead_quorum_blocks(struct super_block *sb)
lock_buffer(bh);
clear_buffer_uptodate(bh);
clear_buffer_scoutfs_traced(bh);
unlock_buffer(bh);
ll_rw_block(READA | REQ_META | REQ_PRIO, 1, &bh);
@@ -346,7 +354,8 @@ static int read_quorum_block(struct super_block *sb,
if (blk->write_nr == 0)
goto out;
trace_scoutfs_quorum_read_block(sb, bh->b_blocknr, blk);
if (!test_set_buffer_scoutfs_traced(bh))
trace_scoutfs_quorum_read_block(sb, bh->b_blocknr, blk);
if (invalid_quorum_block(super, bh, blk)) {
scoutfs_inc_counter(sb, quorum_read_invalid_block);