mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-01-05 03:44:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix updating parent dirty bits

Browse Source 
We were trying to propagate dirty bits from a node itself when its dirty
bit is set.  But it's bits are consistent so it stops immediately.  We
need to propagate from the parent of the node that changed.

Signed-off-by: Zach Brown <zab@versity.com>
This commit is contained in:
Zach Brown
2016-12-08 23:33:05 -08:00
parent b7b43de8c7
commit b251f91842
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
kmod/src/item.c
View File

@@ -348,6 +348,17 @@ static void free_item(struct cached_item *item)
}
}
/*
* The caller has changed an item's dirty bit. Its child dirty bits are
* still consistent. But its parent's bits might need to be updated.
* Its bits are consistent so we don't propagate from the node itself
* because it would immediately terminate.
*/
static void update_dirty_parents(struct cached_item *item)
{
scoutfs_item_rb_propagate(rb_parent(&item->node), NULL);
}
static void mark_item_dirty(struct item_cache *cac,
struct cached_item *item)
{
@@ -362,7 +373,7 @@ static void mark_item_dirty(struct item_cache *cac,
cac->dirty_key_bytes += scoutfs_kvec_length(item->key);
cac->dirty_val_bytes += scoutfs_kvec_length(item->val);
scoutfs_item_rb_propagate(&item->node, NULL);
update_dirty_parents(item);
}
static void clear_item_dirty(struct item_cache *cac,
@@ -382,7 +393,7 @@ static void clear_item_dirty(struct item_cache *cac,
WARN_ON_ONCE(cac->nr_dirty_items < 0 || cac->dirty_key_bytes < 0 ||
cac->dirty_val_bytes < 0);
scoutfs_item_rb_propagate(&item->node, NULL);
update_dirty_parents(item);
}
/*