mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-02-07 19:20:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

scoutfs: warn if we read items without cache limit

Browse Source 
All the item ops now know the limit of the items they're allowed to read
into the cache.  Warn if someone asks to read items without knowing
how much they're allowed to read based on their lock coverage.

Signed-off-by: Zach Brown <zab@versity.com>
This commit is contained in:
Zach Brown
2017-10-05 12:17:35 -07:00
committed by Mark Fasheh
parent 365048b785
commit d593e2caa0
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kmod/src/manifest.c
View File

@@ -535,11 +535,13 @@ out:
* The caller found a hole in the item cache that they'd like populated.
*
* We search the manifest for all the segments we'll need to iterate
* from the key to the end key. If the end key is null then we'll read
* as many items as the intersecting segments contain.
* from the key to the end key, the last key we're allowed to insert
* into the cache.
*
* If next_key is provided then the segments are only walked to find the
* next key after the search key. If none is found -ENOENT is returned.
* There's no limit on the next_key we can return, the caller has
* to deal with that.
*
* As we insert the batch of items we give the item cache the range of
* keys that contain these items. This lets the cache return negative
@@ -584,6 +586,9 @@ static int read_items(struct super_block *sb, struct scoutfs_key_buf *key,
int err;
int cmp;
if (WARN_ON_ONCE(!end && !next_key))
return -EINVAL;
if (end) {
scoutfs_key_clone(&seg_end, end);
} else {
@@ -593,7 +598,6 @@ static int read_items(struct super_block *sb, struct scoutfs_key_buf *key,
trace_scoutfs_read_items(sb, key, &seg_end);
/*
* Ask the manifest server which manifest root to read from. Lock
* holding callers will be responsible for this in the future. They'll