scoutfs: return non-zero status on error

The error return conventions were confused, resulting in main exiting
with success when command execution failed.

Signed-off-by: Zach Brown <zab@versity.com>

utils/src/cmd.c

@@ -60,7 +60,8 @@ static void usage(void)
 	}
 }
 
-int cmd_execute(int argc, char **argv)
+/* this returns a positive unix return code on error for some reason */
+char cmd_execute(int argc, char **argv)
 {
 	struct command *com = NULL;
 	int ret;

utils/src/cmd.h

@@ -4,6 +4,6 @@
 void cmd_register(char *name, char *opts, char *summary,
 		  int (*func)(int argc, char **argv));
 
-int cmd_execute(int argc, char **argv);
+char cmd_execute(int argc, char **argv);
 
 #endif

utils/src/main.c

@@ -10,15 +10,9 @@
 
 int main(int argc, char **argv)
 {
-	int ret;
-
 	/*
 	 * XXX parse global options, env, configs, etc.
 	 */
 
-	ret = cmd_execute(argc, argv);
-	if (ret < 0)
-		return 1;
-
-	return 0;
+	return cmd_execute(argc, argv);
 }