mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-01-07 12:35:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

scoutfs: don't unlock err bh after validation

Browse Source 
If block validation failed then we'd end up trying to unlock an IS_ERR
buffer_head pointer.  Fix it so that we drop the ref and set the
pointer after unlocking.

Signed-off-by: Zach Brown <zab@versity.com>
This commit is contained in:
Zach Brown
2016-08-26 16:51:47 -07:00
parent cb318982c9
commit df93073971
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
kmod/src/block.c
View File

@@ -194,14 +194,16 @@ struct buffer_head *scoutfs_block_read(struct super_block *sb, u64 blkno)
lock_buffer(bh);
if (!buffer_scoutfs_verified(bh)) {
ret = verify_block_header(sbi, bh);
if (ret < 0) {
scoutfs_block_put(bh);
bh = ERR_PTR(ret);
} else {
if (!ret)
set_buffer_scoutfs_verified(bh);
}
} else {
ret = 0;
}
unlock_buffer(bh);
if (ret < 0) {
scoutfs_block_put(bh);
bh = ERR_PTR(ret);
}
}
out: