mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-01-05 03:44:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add shrinker counters for wkic and quota_info.

Browse Source 
These new shrinkers were recently added. Because there's very little
ways to debug them, or even see them properly function, we should at
least add counters for them.

Signed-off-by: Auke Kok <auke.kok@versity.com>
This commit is contained in:
Auke Kok
2024-09-17 13:46:22 -04:00
parent 49acbb4415
commit fb93d82b1e
3 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
kmod/src/counters.h
View File

@@ -162,6 +162,8 @@
EXPAND_COUNTER(orphan_scan_error) \
EXPAND_COUNTER(orphan_scan_item) \
EXPAND_COUNTER(orphan_scan_omap_set) \
EXPAND_COUNTER(quota_info_count_objects) \
EXPAND_COUNTER(quota_info_scan_objects) \
EXPAND_COUNTER(quorum_candidate_server_stopping) \
EXPAND_COUNTER(quorum_elected) \
EXPAND_COUNTER(quorum_fence_error) \
@@ -206,10 +208,12 @@
EXPAND_COUNTER(trans_commit_meta_alloc_low) \
EXPAND_COUNTER(trans_commit_sync_fs) \
EXPAND_COUNTER(trans_commit_timer) \
EXPAND_COUNTER(trans_commit_written)
EXPAND_COUNTER(trans_commit_written) \
EXPAND_COUNTER(wkic_count_objects) \
EXPAND_COUNTER(wkic_scan_objects)
#define FIRST_COUNTER alloc_alloc_data
#define LAST_COUNTER trans_commit_written
#define LAST_COUNTER wkic_scan_objects
#undef EXPAND_COUNTER
#define EXPAND_COUNTER(which) struct percpu_counter which;

5
kmod/src/quota.c
View File

@@ -34,6 +34,7 @@
#include "totl.h"
#include "util.h"
#include "quota.h"
#include "counters.h"
#include "scoutfs_trace.h"
/*
@@ -219,6 +220,8 @@ static unsigned long count_cached_checks(struct shrinker *shrink, struct shrink_
{
struct squota_info *qtinf = KC_SHRINKER_CONTAINER_OF(shrink, struct squota_info);
scoutfs_inc_counter(qtinf->sb, quota_info_count_objects);
return shrinker_min_long(atomic64_read(&qtinf->nr_checks));
}
@@ -237,6 +240,8 @@ static unsigned long scan_cached_checks(struct shrinker *shrink, struct shrink_c
struct squota_check *chk;
int err;
scoutfs_inc_counter(qtinf->sb, quota_info_scan_objects);
rcu_read_lock();
while (nr > 0 && retries > 0 && (chk = lookup_random_check(&qtinf->check_ht))) {

5
kmod/src/wkic.c
View File

@@ -27,6 +27,7 @@
#include "totl.h"
#include "counters.h"
#include "util.h"
#include "counters.h"
#include "scoutfs_trace.h"
#include "wkic.h"
@@ -552,6 +553,8 @@ static unsigned long wkic_shrink_count(struct shrinker *shrink, struct shrink_co
{
struct wkic_info *winf = KC_SHRINKER_CONTAINER_OF(shrink, struct wkic_info);
scoutfs_inc_counter(winf->sb, wkic_count_objects);
return shrinker_min_long(atomic64_read(&winf->shrink_count));
}
@@ -564,6 +567,8 @@ static unsigned long wkic_shrink_scan(struct shrinker *shrink, struct shrink_con
unsigned long after;
LIST_HEAD(empty_list);
scoutfs_inc_counter(winf->sb, wkic_scan_objects);
if (sc->nr_to_scan > 0) {
before = wkic_shrink_count(shrink, sc);
update_trees(sb, winf, &empty_list, sc->nr_to_scan, NULL, NULL, true);