mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-17 10:41:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

scst: Introduce tgt_dev.tgtt

Browse Source 
A later patch will free tgt_devs after an RCU grace period. Make it
safe to access the target template pointer after an RCU grace period.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8474 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Bart Van Assche
2019-07-24 01:09:25 +00:00
parent 89b1c2fb99
commit 0ac23deee2
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
scst/include/scst.h
View File

@@ -3104,6 +3104,7 @@ struct scst_tgt_dev {
/* List entry in sess->sess_tgt_dev_list */
struct list_head sess_tgt_dev_list_entry;
struct scst_tgt_template *tgtt; /* to avoid use-after-free issues */
struct scst_device *dev; /* to save extra dereferences */
uint64_t lun; /* to save extra dereferences */

4
scst/src/dev_handlers/scst_user.c
View File

@@ -3086,7 +3086,7 @@ static int dev_user_attach_tgt(struct scst_tgt_dev *tgt_dev)
int res = 0, rc;
struct scst_user_cmd *ucmd;
DECLARE_COMPLETION_ONSTACK(cmpl);
struct scst_tgt_template *tgtt = tgt_dev->sess->tgt->tgtt;
struct scst_tgt_template *tgtt = tgt_dev->tgtt;
struct scst_tgt *tgt = tgt_dev->sess->tgt;
TRACE_ENTRY();
@@ -3115,7 +3115,7 @@ static int dev_user_attach_tgt(struct scst_tgt_dev *tgt_dev)
ucmd->user_cmd.subcode = SCST_USER_ATTACH_SESS;
ucmd->user_cmd.sess.sess_h = (unsigned long)tgt_dev;
ucmd->user_cmd.sess.lun = (uint64_t)tgt_dev->lun;
ucmd->user_cmd.sess.threads_num = tgt_dev->sess->tgt->tgtt->threads_num;
ucmd->user_cmd.sess.threads_num = tgt_dev->tgtt->threads_num;
ucmd->user_cmd.sess.rd_only = tgt_dev->tgt_dev_rd_only;
if (tgtt->get_phys_transport_version != NULL)
ucmd->user_cmd.sess.phys_transport_version =

9
scst/src/scst_lib.c
View File

@@ -5286,8 +5286,6 @@ static void scst_aic_keeper_release(struct kref *kref)
/* scst_mutex supposed to be held */
void scst_tgt_dev_stop_threads(struct scst_tgt_dev *tgt_dev)
{
struct scst_tgt_template *tgtt = tgt_dev->sess->tgt->tgtt;
TRACE_ENTRY();
lockdep_assert_held(&scst_mutex);
@@ -5304,7 +5302,7 @@ void scst_tgt_dev_stop_threads(struct scst_tgt_dev *tgt_dev)
} else if (tgt_dev->active_cmd_threads == &tgt_dev->dev->dev_cmd_threads) {
/* Per device shared threads */
scst_del_threads(tgt_dev->active_cmd_threads,
tgtt->threads_num);
tgt_dev->tgtt->threads_num);
} else if (tgt_dev->active_cmd_threads == &tgt_dev->tgt_dev_cmd_threads) {
/* Per tgt_dev threads */
scst_del_threads(tgt_dev->active_cmd_threads, -1);
@@ -5349,6 +5347,7 @@ static int scst_alloc_add_tgt_dev(struct scst_session *sess,
}
INIT_LIST_HEAD(&tgt_dev->sess_tgt_dev_list_entry);
tgt_dev->tgtt = tgtt;
tgt_dev->dev = dev;
tgt_dev->lun = acg_dev->lun;
tgt_dev->acg_dev = acg_dev;
@@ -5567,7 +5566,7 @@ static void scst_del_tgt_dev(struct scst_tgt_dev *tgt_dev)
*/
static void scst_free_tgt_dev(struct scst_tgt_dev *tgt_dev)
{
struct scst_tgt_template *tgtt = tgt_dev->sess->tgt->tgtt;
struct scst_tgt_template *tgtt = tgt_dev->tgtt;
struct scst_device *dev = tgt_dev->dev;
TRACE_ENTRY();
@@ -5772,7 +5771,7 @@ struct scst_cmd *__scst_create_prepare_internal_cmd(const uint8_t *cdb,
res->cmd_threads = tgt_dev->active_cmd_threads;
res->sess = tgt_dev->sess;
res->internal = 1;
res->tgtt = tgt_dev->sess->tgt->tgtt;
res->tgtt = tgt_dev->tgtt;
res->tgt = tgt_dev->sess->tgt;
res->dev = tgt_dev->dev;
res->devt = tgt_dev->dev->handler;