mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-23 13:41:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

scst_vdisk: Always mark manually set thin_provisioned sysfs attributes as [key]

Browse Source 
The thin_provisioned != dev_thin_provisioned condition isn't the best way
for marking manually set thin_provisioned attribute.

-----------------------------------
| thin_prov | dev_thin_prov | key |
----------------------------------
|    0, 1   |      0        | No  |
-----------------------------------
|     1     |      1        | No  |
-----------------------------------
|     0     |      1        | Yes |
-----------------------------------

The thin_prov=1, dev_thin_prov=0 case leads to thin_prov will be set to
0 due to internal checking.

So, it's possible to see the value of the thin_provisioned attribute
via scstadmin only in the one case (3 row).

It's especially unclear for the fileio devices, because they support
thin provisioning only when the corresponding attribute is manually set.

Thus, to clarify the using of the thin_provisioned attribute always
display it when manually set.
This commit is contained in:
Gleb Chesnokov
2022-01-24 22:30:44 +03:00
parent 012e5f039b
commit 0b8612cab0
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scst/src/dev_handlers/scst_vdisk.c
View File

@@ -7944,9 +7944,7 @@ static ssize_t vdisk_sysfs_tp_show(struct kobject *kobj,
virt_dev = dev->dh_priv;
pos = sprintf(buf, "%d\n%s", virt_dev->thin_provisioned,
virt_dev->thin_provisioned_manually_set &&
(virt_dev->thin_provisioned !=
virt_dev->dev_thin_provisioned) ?
virt_dev->thin_provisioned_manually_set ?
SCST_SYSFS_KEY_MARK "\n" : "");
TRACE_EXIT_RES(pos);