mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-23 13:41:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

scst_lib: Fix a locking bug

Browse Source 
Avoid that the tgt_dev list can be modified after the
spin_lock(&tgt_dev->tgt_dev_lock) statement and before the
spin_unlock(&tgt_dev->tgt_dev_lock) statement.

See also patch "scst: Rework sess_tgt_dev_list locking" (commit ID
5af7d9277d).

Reported-by: Kurt Reddew <kurt.reddew@gmail.com>
This commit is contained in:
Bart Van Assche
2015-09-02 11:54:38 -07:00
parent 9550c47e75
commit 0bc7df1729
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scst/src/scst_lib.c
View File

@@ -11617,7 +11617,6 @@ again:
spin_lock(&tgt_dev->tgt_dev_lock);
}
}
rcu_read_unlock();
#endif
first = false;
@@ -11647,7 +11646,6 @@ again:
list_del(&UA_entry->UA_list_entry);
if (UA_entry->global_UA) {
rcu_read_lock();
for (i = 0; i < SESS_TGT_DEV_LIST_HASH_SIZE; i++) {
struct list_head *head = &sess->sess_tgt_dev_list[i];
struct scst_tgt_dev *tgt_dev;
@@ -11671,7 +11669,6 @@ again:
}
}
}
rcu_read_unlock();
}
mempool_free(UA_entry, scst_ua_mempool);
@@ -11684,7 +11681,6 @@ again:
out_unlock:
if (global_unlock) {
#if !defined(__CHECKER__)
rcu_read_lock();
for (i = SESS_TGT_DEV_LIST_HASH_SIZE-1; i >= 0; i--) {
struct list_head *head = &sess->sess_tgt_dev_list[i];
struct scst_tgt_dev *tgt_dev;