mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-19 03:31:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

scst_vdisk: Fix error handling in __vdev_load_mode_pages()

Browse Source 
Avoid that unknown parameters cause __vdev_load_mode_pages() to
return 0 instead of -EINVAL. Detected by Coverity.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
This commit is contained in:
Bart Van Assche
2015-04-29 15:36:28 +02:00
parent 24b317946b
commit 0da80bb241
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scst/src/dev_handlers/scst_vdisk.c
View File

@@ -1181,7 +1181,7 @@ out:
/* Params are NULL-terminated */
static int __vdev_load_mode_pages(struct scst_vdisk_dev *virt_dev, char *params)
{
int res;
int res = 0;
char *param, *p, *pp;
unsigned long val;
@@ -1216,14 +1216,11 @@ static int __vdev_load_mode_pages(struct scst_vdisk_dev *virt_dev, char *params)
else {
TRACE_DBG("Unknown parameter %s", p);
res = -EINVAL;
break;
}
if (res != 0)
goto out;
break;
}
res = 0;
out:
TRACE_EXIT_RES(res);
return res;