mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-08-20 06:06:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

iscsi-scstd: Improve create_and_open_dev() robustness

Browse Source 
Reset 'devn' if the sscanf() return value is lower than two.
Based on a Coverity report.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6367 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Bart Van Assche
2015-06-17 00:21:28 +00:00
parent d70b1e39c0
commit 165b0f1d10
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
iscsi-scst/usr/misc.c
+3 -6
View File
@@ -43,12 +43,9 @@ int create_and_open_dev(const char *dev, int readonly)
}
devn = 0;
while (!feof(f)) {
if (!fgets(buf, sizeof(buf), f))
break;
if (sscanf(buf, "%d %s", &devn, devname) != 2)
continue;
if (!strcmp(devname, dev))
while (fgets(buf, sizeof(buf), f)) {
if (sscanf(buf, "%d %s", &devn, devname) == 2 &&
devn > 0 && strcmp(devname, dev) == 0)
break;
devn = 0;
}