mirror of
https://github.com/SCST-project/scst.git
synced 2026-10-22 14:12:33 +00:00
qla2x00t-32gbit: Unlink NVMe unsol ctx before freeing on LS reject error
qla_nvme_xmt_ls_rsp() obtains uctx, which was linked into
fcport->unsol_ctx_head by qla2xxx_process_purls_iocb() and is still linked
when the NVMe transport calls back to transmit the LS response. On the
error (out:) path the function frees uctx with kfree() but never removes
it from the list. This leaves a freed node in fcport->unsol_ctx_head: the
next list_add_tail() for that fcport writes through the freed node, and a
subsequent list_del() can corrupt the list or panic.
Unlink uctx with list_del() before kfree() on the error path, matching the
other free sites in qla_nvme_release_lsrsp_cmd_kref() and
qla2xxx_process_purls_pkt(). qla2x00_rel_sp() in the failure path only
returns the SRB to its pool and does not invoke sp->put_fn, so the out:
path is the sole free and uctx is always still linked there.
Fixes: 875386b98857 ("scsi: qla2xxx: Add Unsolicited LS Request and Response Support for NVMe")
Cc: stable@vger.kernel.org
Reported-by: Sashiko <sashiko-dev@google.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://patch.msgid.link/20260730155838.2119230-27-njavali@marvell.com
Signed-off-by: Martin K. Petersen (Oracle) <mkp@kernel.org>
[ commit e46160a5d4fa59bf4d5f3412b6b5cb79edb967dd upstream ]
This commit is contained in:
committed by
Gleb Chesnokov
parent
e2cd45daa3
commit
232ba975fe
@@ -472,6 +472,7 @@ out:
|
||||
qla_nvme_ls_reject_iocb(vha, ha->base_qpair, &a, true);
|
||||
spin_unlock_irqrestore(ha->base_qpair->qp_lock_ptr, flags);
|
||||
}
|
||||
list_del(&uctx->elem);
|
||||
kfree(uctx);
|
||||
return rval;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user