mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-21 12:41:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

scst: avoid possible side effect with WARN_ON_ONCE()

Browse Source 
Reported-By: David Butterfield <dab21774@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7136 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2017-04-18 04:06:18 +00:00
parent 89a939536f
commit 24b9a38b2b
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
scst/src/scst_lib.c
View File

@@ -4783,6 +4783,7 @@ static void scst_put_acg_work(struct work_struct *work)
void scst_put_acg(struct scst_acg *acg)
{
struct scst_acg_put_work *put_work;
bool rc;
put_work = kmalloc(sizeof(*put_work), GFP_KERNEL | __GFP_NOFAIL);
if (WARN_ON_ONCE(!put_work)) {
@@ -4801,7 +4802,9 @@ void scst_put_acg(struct scst_acg *acg)
* Schedule the kref_put() call instead of invoking it directly to
* avoid deep recursion and a stack overflow.
*/
WARN_ON_ONCE(!queue_work(scst_release_acg_wq, &put_work->work));
rc = queue_work(scst_release_acg_wq, &put_work->work);
WARN_ON_ONCE(!rc);
return;
}
void scst_get_acg(struct scst_acg *acg)