mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-17 18:51:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for non-initialized s_id during ABTS handling

Browse Source 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3244 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2011-02-01 00:23:25 +00:00
parent d38930733e
commit 3ee6fec0ba
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
qla2x00t/qla2x00-target/qla2x00t.c
View File

@@ -5336,6 +5336,8 @@ retry:
global_resets = atomic_read(&ha->tgt->tgt_global_resets_count);
if (IS_FWI2_CAPABLE(ha)) {
sBUG_ON(s_id == NULL);
rc = q24_get_loop_id(ha, s_id, &loop_id);
if (rc != 0) {
if ((s_id[0] == 0xFF) &&
@@ -5402,7 +5404,8 @@ static void q2t_exec_sess_work(struct q2t_tgt *tgt,
scsi_qla_host_t *pha = to_qla_parent(ha);
int rc;
struct q2t_sess *sess = NULL;
const uint8_t *s_id = NULL; /* to hide compiler warnings */
uint8_t *s_id = NULL; /* to hide compiler warnings */
uint8_t local_s_id[3];
int loop_id = -1; /* to hide compiler warnings */
TRACE_ENTRY();
@@ -5430,6 +5433,12 @@ static void q2t_exec_sess_work(struct q2t_tgt *tgt,
if (IS_FWI2_CAPABLE(ha)) {
sess = q2t_find_sess_by_s_id_le(tgt,
prm->abts.fcp_hdr_le.s_id);
if (sess == NULL) {
s_id = local_s_id;
s_id[0] = prm->abts.fcp_hdr_le.s_id[2];
s_id[1] = prm->abts.fcp_hdr_le.s_id[1];
s_id[2] = prm->abts.fcp_hdr_le.s_id[0];
}
goto after_find;
} else
loop_id = GET_TARGET_ID(ha, &prm->tm_iocb);
@@ -5445,9 +5454,10 @@ static void q2t_exec_sess_work(struct q2t_tgt *tgt,
break;
}
if (IS_FWI2_CAPABLE(ha))
if (IS_FWI2_CAPABLE(ha)) {
sBUG_ON(s_id == NULL);
sess = q2t_find_sess_by_s_id(tgt, s_id);
else
} else
sess = q2t_find_sess_by_loop_id(tgt, loop_id);
after_find: