mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-08-20 14:16:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect state check in the debug trap reported by Bart Van Assche <bvanassche@acm.org>

Browse Source 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4238 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2012-04-26 18:41:14 +00:00
parent 1856c4985b
commit 3f0b7169ba
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scst/src/scst_targ.c
+9 -7
View File
@@ -882,16 +882,18 @@ out:
#ifdef CONFIG_SCST_EXTRACHECKS
/*
* At this point either data_len must be initialized, or cmd
* completed (with an error).
* completed (with an error) and correct state set.
*/
if (unlikely((cmd->data_len == SCST_DEF_DATA_LEN)) &&
(!cmd->completed || ((cmd->state <= SCST_CMD_STATE_REAL_EXEC) &&
(cmd->state != SCST_CMD_STATE_PREPROCESSING_DONE)))) {
(!cmd->completed ||
(((cmd->state <= SCST_CMD_STATE_PRE_XMIT_RESP) ||
(cmd->state >= SCST_CMD_STATE_LAST_ACTIVE)) &&
(cmd->state != SCST_CMD_STATE_PREPROCESSING_DONE)))) {
PRINT_CRIT_ERROR("Not initialized data_len for going to "
"execute command (cmd %p, data_len %d, completed %d, "
"state %d)", cmd, cmd->data_len, cmd->completed,
cmd->state);
WARN_ON(1);
"execute command or bad state (cmd %p, data_len %d, "
"completed %d, state %d)", cmd, cmd->data_len,
cmd->completed, cmd->state);
sBUG();
goto out_hw_error;
}
#endif