scst_vdisk: Fix error handling in __vdev_load_mode_pages()

Avoid that unknown parameters cause __vdev_load_mode_pages() to
return 0 instead of -EINVAL. Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6338 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Bart Van Assche
2015-06-16 20:21:22 +00:00
parent f6806b930c
commit 3fe91cf714

View File

@@ -1217,7 +1217,7 @@ out:
/* Params are NULL-terminated */
static int __vdev_load_mode_pages(struct scst_vdisk_dev *virt_dev, char *params)
{
int res;
int res = 0;
char *param, *p, *pp;
unsigned long val;
@@ -1252,14 +1252,11 @@ static int __vdev_load_mode_pages(struct scst_vdisk_dev *virt_dev, char *params)
else {
TRACE_DBG("Unknown parameter %s", p);
res = -EINVAL;
break;
}
if (res != 0)
goto out;
break;
}
res = 0;
out:
TRACE_EXIT_RES(res);
return res;