mirror of
https://github.com/SCST-project/scst.git
synced 2026-05-20 12:11:26 +00:00
scst_vdisk: Fix error handling in __vdev_load_mode_pages()
Avoid that unknown parameters cause __vdev_load_mode_pages() to return 0 instead of -EINVAL. Detected by Coverity. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6338 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
@@ -1217,7 +1217,7 @@ out:
|
||||
/* Params are NULL-terminated */
|
||||
static int __vdev_load_mode_pages(struct scst_vdisk_dev *virt_dev, char *params)
|
||||
{
|
||||
int res;
|
||||
int res = 0;
|
||||
char *param, *p, *pp;
|
||||
unsigned long val;
|
||||
|
||||
@@ -1252,14 +1252,11 @@ static int __vdev_load_mode_pages(struct scst_vdisk_dev *virt_dev, char *params)
|
||||
else {
|
||||
TRACE_DBG("Unknown parameter %s", p);
|
||||
res = -EINVAL;
|
||||
break;
|
||||
}
|
||||
if (res != 0)
|
||||
goto out;
|
||||
break;
|
||||
}
|
||||
|
||||
res = 0;
|
||||
|
||||
out:
|
||||
TRACE_EXIT_RES(res);
|
||||
return res;
|
||||
|
||||
Reference in New Issue
Block a user