mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-14 01:01:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

qla2x00t-32gbit: Always check the return value of qla24xx_get_isp_stats()

Browse Source 
This patch fixes the following Coverity warning:

    CID 361199 (#1 of 1): Unchecked return value (CHECKED_RETURN)
    3. check_return: Calling qla24xx_get_isp_stats without checking return
    value (as is done elsewhere 4 out of 5 times).


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9117 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Bart Van Assche
2020-08-09 00:41:51 +00:00
parent 31dbbf3274
commit 41b4e25644
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
qla2x00t-32gbit/qla_attr.c
View File

@@ -2816,6 +2816,8 @@ qla2x00_reset_host_stats(struct Scsi_Host *shost)
vha->qla_stats.jiffies_at_last_reset = get_jiffies_64();
if (IS_FWI2_CAPABLE(ha)) {
int rval;
stats = dma_alloc_coherent(&ha->pdev->dev,
sizeof(*stats), &stats_dma, GFP_KERNEL);
if (!stats) {
@@ -2825,7 +2827,8 @@ qla2x00_reset_host_stats(struct Scsi_Host *shost)
}
/* reset firmware statistics */
qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0);
rval = qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0);
WARN_ONCE(rval != QLA_SUCCESS, "rval = %d\n", rval);
dma_free_coherent(&ha->pdev->dev, sizeof(*stats),
stats, stats_dma);