scst: Put KUnit visibility annotations on separate lines

The full SCS scan reports three instances of the same diagnostic:

  scst/src/scst_lib.c:3007:1:
  scst/src/scst_sysfs.c:1762:1:
  scst/src/scst_targ.c:5666:1:
    error: SCS.1: place SCST_KUNIT_VISIBLE on a line of its own

Move the annotations above the declarations of scst_check_reassign_sess,
__scst_acg_black_hole_store and scst_mgmt_cmd_init. This satisfies the
existing SCS.1 rule without changing visibility or function behavior.
This commit is contained in:
Gleb Chesnokov
2026-10-20 18:02:29 +03:00
parent 46505c2670
commit 43ee1a7c5d
3 changed files with 6 additions and 4 deletions
+2 -1
View File
@@ -3004,7 +3004,8 @@ void scst_dev_inquiry_data_changed(struct scst_device *dev)
EXPORT_SYMBOL(scst_dev_inquiry_data_changed);
/* The activity supposed to be suspended and scst_mutex held */
SCST_KUNIT_VISIBLE void scst_check_reassign_sess(struct scst_session *sess)
SCST_KUNIT_VISIBLE
void scst_check_reassign_sess(struct scst_session *sess)
{
struct scst_acg *acg, *old_acg;
struct scst_acg_dev *acg_dev;
+2 -2
View File
@@ -1759,8 +1759,8 @@ static ssize_t __scst_acg_black_hole_show(struct scst_acg *acg, char *buf)
return sysfs_emit(buf, "%d\n", t);
}
SCST_KUNIT_VISIBLE ssize_t
__scst_acg_black_hole_store(struct scst_acg *acg, const char *buf, size_t count)
SCST_KUNIT_VISIBLE
ssize_t __scst_acg_black_hole_store(struct scst_acg *acg, const char *buf, size_t count)
{
int res = 0;
int prev, t;
+2 -1
View File
@@ -5663,7 +5663,8 @@ static int scst_clear_task_set(struct scst_mgmt_cmd *mcmd)
* Returns 0 if the command processing should be continued,
* >0, if it should be requeued, <0 otherwise.
*/
SCST_KUNIT_VISIBLE int scst_mgmt_cmd_init(struct scst_mgmt_cmd *mcmd)
SCST_KUNIT_VISIBLE
int scst_mgmt_cmd_init(struct scst_mgmt_cmd *mcmd)
{
int res = 0, rc, t;