mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-18 03:01:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

scst: Remove dead code from scst_assign_dev_handler()

Browse Source 
The BUG_ON(handler == NULL) statement at the start of this function
guarantees that handler != NULL. Hence remove the remaining tests of
the 'handler' pointer. Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6341 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Bart Van Assche
2015-06-16 23:43:31 +00:00
parent f272064c12
commit 4efcfc7bfd
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scst/src/scst_main.c
View File

@@ -2103,10 +2103,6 @@ int scst_assign_dev_handler(struct scst_device *dev,
assign:
dev->handler = handler;
if (handler == NULL)
goto out;
dev->threads_num = handler->threads_num;
dev->threads_pool_type = handler->threads_pool_type;
dev->max_write_same_len = 256 * 1024 * 1024; /* 256 MB */
@@ -2152,7 +2148,7 @@ out:
return res;
out_err_detach_tgt:
if (handler && handler->detach_tgt) {
if (handler->detach_tgt) {
list_for_each_entry(tgt_dev, &attached_tgt_devs,
extra_tgt_dev_list_entry) {
TRACE_DBG("Calling handler's detach_tgt(%p)",
@@ -2165,7 +2161,7 @@ out_err_detach_tgt:
scst_devt_dev_sysfs_del(dev);
out_detach:
if (handler && handler->detach) {
if (handler->detach) {
TRACE_DBG("%s", "Calling handler's detach()");
handler->detach(dev);
TRACE_DBG("%s", "Handler's detach() returned");