mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-09-20 15:04:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

iscsi-scst/usr/iscsi_adm.c: Fix use of uninitialized struct field

Browse Source 
This patch fixes the following Coverity complaint:

    CID 271601 (#1 of 1): Uninitialized scalar variable (UNINIT)
    uninit_use_in_call: Using uninitialized value req.
    Field req.cid is uninitialized when calling iscsid_request.
This commit is contained in:
Gleb Chesnokov
2022-06-27 14:14:52 +03:00
parent d9442eaa18
commit 828940842a
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
iscsi-scst/usr/iscsi_adm.c
+1 -1
View File
@@ -375,7 +375,7 @@ out:
static int sess_handle(int op, u32 set, u32 tid, u64 sid, char *params)
{
int err = -EINVAL;
struct iscsi_adm_req req;
struct iscsi_adm_req req = {};
if (op == OP_NEW || op == OP_UPDATE) {
fprintf(stderr, "Unsupported.\n");
iscsi-scst/usr/iscsi_adm.h
-1
View File
@@ -74,7 +74,6 @@ struct iscsi_adm_req {
u32 tid;
u64 sid;
u32 cid;
u32 lun;
union {
struct msg_trgt trgt;
iscsi-scst/usr/message.c
+2 -2
View File
@@ -58,8 +58,8 @@ static void iscsi_adm_request_exec(struct iscsi_adm_req *req, struct iscsi_adm_r
{
int err = 0;
log_debug(1, "request %u, tid %u, sid 0x%" PRIx64 ", cid %u, lun %u",
req->rcmnd, req->tid, req->sid, req->cid, req->lun);
log_debug(1, "request %u, tid %u, sid 0x%" PRIx64 ", cid %u",
req->rcmnd, req->tid, req->sid, req->cid);
switch (req->rcmnd) {
case C_TRGT_NEW: