mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-23 21:51:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

isert: fix race between ioctl events and disconnect flow

Browse Source 
The ioctl events may arive after the isert connection has
started the teardown flow.
This scenario may occur on login logout stress.
It may lead to NULL derefrence bugs.

Signed-off-by: Israel Rukshin <israelr@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6940 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Israel Rukshin
2016-08-17 07:27:28 +00:00
parent e3f77ba979
commit 8587672dc4
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
iscsi-scst/kernel/isert-scst/isert_login.c
View File

@@ -51,6 +51,8 @@
#include "isert.h"
#include "iser_datamover.h"
static DEFINE_MUTEX(conn_mgmt_mutex);
static unsigned int n_devs;
static int isert_major;
@@ -204,6 +206,8 @@ int isert_conn_alloc(struct iscsi_session *session,
lockdep_assert_held(&session->target->target_mutex);
mutex_lock(&conn_mgmt_mutex);
if (unlikely(!filp)) {
res = -EBADF;
goto out;
@@ -273,6 +277,7 @@ cleanup_conn:
conn->session = NULL;
isert_close_connection(conn);
out:
mutex_unlock(&conn_mgmt_mutex);
TRACE_EXIT_RES(res);
return res;
}
@@ -445,7 +450,10 @@ int isert_connection_closed(struct iscsi_conn *iscsi_conn)
TRACE_ENTRY();
mutex_lock(&conn_mgmt_mutex);
if (iscsi_conn->rd_state) {
mutex_unlock(&conn_mgmt_mutex);
res = isert_handle_close_connection(iscsi_conn);
} else {
struct isert_conn_dev *dev = isert_get_priv(iscsi_conn);
@@ -465,6 +473,7 @@ int isert_connection_closed(struct iscsi_conn *iscsi_conn)
isert_set_priv(iscsi_conn, NULL);
}
mutex_unlock(&conn_mgmt_mutex);
isert_free_connection(iscsi_conn);
}
@@ -681,6 +690,8 @@ static long isert_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
TRACE_ENTRY();
mutex_lock(&conn_mgmt_mutex);
if (dev->state == CS_DISCONNECTED) {
res = -EPIPE;
goto out;
@@ -767,6 +778,7 @@ static long isert_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
}
out:
mutex_unlock(&conn_mgmt_mutex);
TRACE_EXIT_RES(res);
return res;
}