A bunch of minor changes:

- Logging improved
 - #warning about io_context patched for pre-2.6.27 kernels improved
 - Docs updated



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@909 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2009-06-17 17:22:17 +00:00
parent 0d445511f8
commit 8bbdf3949f
6 changed files with 41 additions and 5 deletions

View File

@@ -188,6 +188,9 @@ http://virtualgeek.typepad.com/virtual_geek/2009/01/a-multivendor-post-to-help-o
It's about VMware, but its recommendations apply to other environments
as well.
3. ISCSI initiators built in pre-CentOS/RHEL 5 reported to have some
performance problems. If you use it, it is strongly advised to upgrade.
Compilation options
-------------------

View File

@@ -124,6 +124,9 @@ http://virtualgeek.typepad.com/virtual_geek/2009/01/a-multivendor-post-to-help-o
It's about VMware, but its recommendations apply to other environments
as well.
3. ISCSI initiators built in pre-CentOS/RHEL 5 reported to have some
performance problems. If you use it, it is strongly advised to upgrade.
Compilation options
-------------------

View File

@@ -810,6 +810,11 @@ using debug2perf root Makefile target.
4. For other target and initiator software parts:
- Make sure you applied on your kernel all available SCST patches,
especially io_context-2.6.X.patch. If for your kernel version this
patch doesn't exist, it is strongly recommended to upgrade your
kernel to version, for which this patch exists.
- Don't enable debug/hacking features in the kernel, i.e. use them as
they are by default.

View File

@@ -732,6 +732,11 @@ using debug2perf root Makefile target.
4. For other target and initiator software parts:
- Make sure you applied on your kernel all available SCST patches,
especially io_context-2.6.X.patch. If for your kernel version this
patch doesn't exist, it is strongly recommended to upgrade your
kernel to version, for which this patch exists.
- Don't enable debug/hacking features in the kernel, i.e. use them as
they are by default.

View File

@@ -158,12 +158,24 @@ do { \
} \
} while (0)
#ifdef CONFIG_SCST_DEBUG
#define PRINT_BUFFER(message, buff, len) \
do { \
PRINT(NO_FLAG, "%s:%s:", __func__, message); \
debug_print_buffer(INFO_FLAG, buff, len); \
} while (0)
#else
#define PRINT_BUFFER(message, buff, len) \
do { \
PRINT(NO_FLAG, "%s:", message); \
debug_print_buffer(INFO_FLAG, buff, len); \
} while (0)
#endif
#define PRINT_BUFF_FLAG(flag, message, buff, len) \
do { \
if (___unlikely(trace_flag & (flag))) { \

View File

@@ -42,16 +42,20 @@
#if !defined(SCSI_EXEC_REQ_FIFO_DEFINED) && \
!defined(CONFIG_SCST_STRICT_SERIALIZING)
#warning "Patch scst_exec_req_fifo-<kernel-version>.patch was not applied on\
#warning "Patch scst_exec_req_fifo-<kernel-version> was not applied on\
your kernel and CONFIG_SCST_STRICT_SERIALIZING isn't defined.\
Pass-through dev handlers will not work."
#endif
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 25)
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)
#if !defined(SCST_IO_CONTEXT)
#warning "Patch io_context-<kernel-version>.patch was not applied\
#warning "Patch io_context-<kernel-version> was not applied\
on your kernel. SCST will be working with not the best performance."
#endif
#else
#warning "There is no patch io_context-<kernel-version>\
for your kernel version. For performance reasons it is strongly recommended\
to upgrade your kernel to version >= 2.6.27.x."
#endif
/**
@@ -919,7 +923,7 @@ int __scst_register_dev_driver(struct scst_dev_type *dev_type,
if (dev_type->exec == NULL) {
PRINT_ERROR("Pass-through dev handlers (handler \"%s\") not "
"supported. Consider applying on your kernel patch "
"scst_exec_req_fifo-<kernel-version>.patch or define "
"scst_exec_req_fifo-<kernel-version> or define "
"CONFIG_SCST_STRICT_SERIALIZING", dev_type->name);
res = -EINVAL;
goto out;
@@ -1691,12 +1695,16 @@ static int __init init_scst(void)
BUILD_BUG_ON(sizeof(c->sn) != sizeof(t->expected_sn));
}
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 25)
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)
#if !defined(SCST_IO_CONTEXT)
PRINT_WARNING("%s", "Patch io_context was not applied on "
"your kernel. SCST will be working with not the best "
"performance.");
#endif
#else
PRINT_WARNING("%s", "There is no patch io_context for your kernel "
"version. For performance reasons it is strongly recommended "
"to upgrade your kernel to version >= 2.6.27.x.");
#endif
mutex_init(&scst_mutex);