mirror of
https://github.com/SCST-project/scst.git
synced 2026-08-20 06:06:23 +00:00
qla2x00t-32gbit: edif: Fix session thrash
Current code prematurely sends out PRLI before authentication application has given the OK to do so. This causes PRLI failure and session teardown. Prevents PRLI from going out before authentication app gives the OK. Link: https://lore.kernel.org/r/20220608115849.16693-7-njavali@marvell.com Fixes: 91f6f5fbe87b ("scsi: qla2xxx: edif: Reduce connection thrash") Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> Signed-off-by: Quinn Tran <qutran@marvell.com> Signed-off-by: Nilesh Javali <njavali@marvell.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> [ commit a8fdfb0b39c2 upstream ]
This commit is contained in:
@@ -3518,7 +3518,7 @@ int qla_edif_process_els(scsi_qla_host_t *vha, BSG_JOB_TYPE *bsg_job)
|
||||
if (qla_bsg_check(vha, bsg_job, fcport))
|
||||
return 0;
|
||||
|
||||
if (fcport->loop_id == FC_NO_LOOP_ID) {
|
||||
if (EDIF_SESS_DELETE(fcport)) {
|
||||
ql_dbg(ql_dbg_edif, vha, 0x910d,
|
||||
"%s ELS code %x, no loop id.\n", __func__,
|
||||
bsg_request->rqst_data.r_els.els_code);
|
||||
|
||||
@@ -149,4 +149,8 @@ struct enode {
|
||||
(DBELL_ACTIVE(_fcport->vha) && \
|
||||
(_fcport->disc_state == DSC_LOGIN_AUTH_PEND))
|
||||
|
||||
#define EDIF_SESS_DELETE(_s) \
|
||||
(qla_ini_mode_enabled(_s->vha) && (_s->disc_state == DSC_DELETE_PEND || \
|
||||
_s->disc_state == DSC_DELETED))
|
||||
|
||||
#endif /* __QLA_EDIF_H */
|
||||
|
||||
@@ -1762,8 +1762,16 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport)
|
||||
break;
|
||||
|
||||
case DSC_LOGIN_PEND:
|
||||
if (fcport->fw_login_state == DSC_LS_PLOGI_COMP)
|
||||
if (vha->hw->flags.edif_enabled)
|
||||
break;
|
||||
|
||||
if (fcport->fw_login_state == DSC_LS_PLOGI_COMP) {
|
||||
ql_dbg(ql_dbg_disc, vha, 0x2118,
|
||||
"%s %d %8phC post %s PRLI\n",
|
||||
__func__, __LINE__, fcport->port_name,
|
||||
NVME_TARGET(vha->hw, fcport) ? "NVME" : "FC");
|
||||
qla24xx_post_prli_work(vha, fcport);
|
||||
}
|
||||
break;
|
||||
|
||||
case DSC_UPD_FCPORT:
|
||||
|
||||
Reference in New Issue
Block a user