mirror of
https://github.com/SCST-project/scst.git
synced 2026-08-19 13:46:25 +00:00
ib_srpt: Ensure that the BUG_ON() argument has no side effects
Reported-by: David Butterfield <dab21774@gmail.com> git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7106 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
+5
-2
@@ -3530,8 +3530,11 @@ static int srpt_xfer_data(struct srpt_rdma_ch *ch,
|
||||
int ret;
|
||||
|
||||
if (ioctx->imm_data) {
|
||||
BUG_ON(!srpt_test_and_set_cmd_state(ioctx, SRPT_STATE_NEED_DATA,
|
||||
SRPT_STATE_DATA_IN));
|
||||
bool res;
|
||||
|
||||
res = srpt_test_and_set_cmd_state(ioctx, SRPT_STATE_NEED_DATA,
|
||||
SRPT_STATE_DATA_IN);
|
||||
BUG_ON(!res);
|
||||
if (unlikely(!scst_cmd_get_tgt_data_buff_alloced(cmd))) {
|
||||
unsigned int offset = 0, len;
|
||||
uint8_t *buf;
|
||||
|
||||
Reference in New Issue
Block a user