mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-19 03:31:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

iscsi-scstd: Improve create_and_open_dev() robustness

Browse Source 
Reset 'devn' if the sscanf() return value is lower than two.
Based on a Coverity report.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
This commit is contained in:
Bart Van Assche
2015-05-05 10:43:43 +02:00
parent 189e3b9e7e
commit ab78e6ae61
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
iscsi-scst/usr/misc.c
View File

@@ -43,12 +43,9 @@ int create_and_open_dev(const char *dev, int readonly)
}
devn = 0;
while (!feof(f)) {
if (!fgets(buf, sizeof(buf), f))
break;
if (sscanf(buf, "%d %s", &devn, devname) != 2)
continue;
if (!strcmp(devname, dev))
while (fgets(buf, sizeof(buf), f)) {
if (sscanf(buf, "%d %s", &devn, devname) == 2 &&
devn > 0 && strcmp(devname, dev) == 0)
break;
devn = 0;
}