mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-18 03:01:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add q2t_pre_xmit_response comment

Browse Source 
The fix for the locking bug I found in q2t_pre_xmit_response has already
been added, but I had some comments in my copy that couldn't hurt.

From "Robinson, Herbie" <Herbie.Robinson@stratus.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4418 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2012-07-24 18:48:03 +00:00
parent e70b729707
commit bb4e5eec24
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
qla2x00t/qla2x00-target/qla2x00t.c
View File

@@ -2439,6 +2439,11 @@ static inline int q2t_has_data(struct q2t_cmd *cmd)
return cmd->bufflen > 0;
}
/*
* Acquires pha->hardware lock and returns with the lock held when
* the result == SCST_TGT_RES_SUCCESS. The lock is unlocked if an
* error is returned.
*/
static int q2t_pre_xmit_response(struct q2t_cmd *cmd,
struct q2t_prm *prm, int xmit_type, unsigned long *flags)
{
@@ -2545,6 +2550,8 @@ static int q2t_pre_xmit_response(struct q2t_cmd *cmd,
/* Does F/W have an IOCBs for this request */
res = q2t_check_reserve_free_req(ha, full_req_cnt);
/* The following check must match the callers' assumptions */
if (unlikely(res != SCST_TGT_RES_SUCCESS))
goto out_unlock_free_unmap;