mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-18 03:01:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify scst_free_session() by invoking wake_up_all() while scst_mutex is held.

Browse Source 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2844 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2010-11-26 21:28:38 +00:00
parent bd60cf5505
commit bef485b20f
1 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
scst/src/scst_lib.c
View File

@@ -3962,9 +3962,6 @@ void scst_free_session(struct scst_session *sess)
scst_sess_free_tgt_devs(sess);
#ifndef CONFIG_SCST_PROC
/* tgt will stay alive at least until its sysfs alive */
kobject_get(&sess->tgt->tgt_kobj);
mutex_unlock(&scst_mutex);
scst_sess_sysfs_del(sess);
mutex_lock(&scst_mutex);
@@ -3980,19 +3977,15 @@ void scst_free_session(struct scst_session *sess)
TRACE_DBG("Removing session %p from acg %s", sess, sess->acg->acg_name);
list_del(&sess->acg_sess_list_entry);
#ifdef CONFIG_SCST_PROC
/* Called under lock to protect from too early tgt release */
wake_up_all(&sess->tgt->unreg_waitQ);
#endif
/*
* NOTE: do not dereference the sess->tgt pointer after scst_mutex
* has been unlocked, because it can be already dead!!
*/
mutex_unlock(&scst_mutex);
#ifndef CONFIG_SCST_PROC
wake_up_all(&sess->tgt->unreg_waitQ);
kobject_put(&sess->tgt->tgt_kobj);
#endif
kfree(sess->transport_id);
kfree(sess->initiator_name);