mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-22 13:11:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

- Improve errors reporting

Browse Source 
- Fix minor race for sense buffer allocation



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1574 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2010-03-31 11:42:15 +00:00
parent e4ba045c90
commit c7be8ae91d
1 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
scst/src/dev_handlers/scst_vdisk.c
View File

@@ -2533,22 +2533,31 @@ static void blockio_endio(struct bio *bio, int error)
return 1;
#endif
error = test_bit(BIO_UPTODATE, &bio->bi_flags) ? error : -EIO;
if (unlikely(!test_bit(BIO_UPTODATE, &bio->bi_flags))) {
if (error == 0) {
PRINT_ERROR("Not up to date bio with error 0 for "
"cmd %p, returning -EIO", blockio_work->cmd);
error = -EIO;
}
}
if (unlikely(error != 0)) {
static DEFINE_SPINLOCK(blockio_endio_lock);
PRINT_ERROR("cmd %p returned error %d", blockio_work->cmd,
error);
/*
* The race with other such bio's doesn't matter, since all
* scst_set_cmd_error() calls do the same local to this cmd
* operations.
*/
/* To protect from several bios finishing simultaneously */
spin_lock_bh(&blockio_endio_lock);
if (bio->bi_rw & WRITE)
scst_set_cmd_error(blockio_work->cmd,
SCST_LOAD_SENSE(scst_sense_write_error));
else
scst_set_cmd_error(blockio_work->cmd,
SCST_LOAD_SENSE(scst_sense_read_error));
spin_unlock_bh(&blockio_endio_lock);
}
blockio_check_finish(blockio_work);