Until now I had been using the latest git version of sparse (August 26, 2008).

Apparently not all messages reported by this version are correct. So I switched
back to the last released sparse version (0.4.1). The patch below fixes all
errors and warnings reported by sparse 0.4.1 on the SCST source code.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@596 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2008-12-04 18:00:51 +00:00
parent 52fae86a01
commit cba6490e82
3 changed files with 3 additions and 3 deletions

View File

@@ -2138,7 +2138,7 @@ void cmnd_tx_start(struct iscsi_cmnd *cmnd)
set_cork(conn->sock, 1);
conn->write_iop = (void __force __user *)(conn->write_iov);
conn->write_iop = conn->write_iov;
conn->write_iop->iov_base = (void __force __user *)(&cmnd->pdu.bhs);
conn->write_iop->iov_len = sizeof(cmnd->pdu.bhs);
conn->write_iop_used = 1;

View File

@@ -169,7 +169,7 @@ struct iscsi_conn {
* thread.
*/
struct iscsi_cmnd *write_cmnd;
struct iovec __user *write_iop;
struct iovec *write_iop;
int write_iop_used;
struct iovec write_iov[2];
u32 write_size;

View File

@@ -988,7 +988,7 @@ static int write_data(struct iscsi_conn *conn)
struct iscsi_cmnd *write_cmnd = conn->write_cmnd;
struct iscsi_cmnd *ref_cmd;
struct scatterlist *sg;
struct iovec __user *iop;
struct iovec *iop;
int saved_size, size, sendsize;
int offset, idx, sg_offset;
int flags, res, count;