mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-17 10:41:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

The FORMAT UNIT has an optional data-out buffer with unspecified length.

Browse Source 
Make sure that SCST parses this command correctly.

Reported-by: Leonid Podolny <leonid.podolny@xtremio.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4158 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2012-03-07 19:52:50 +00:00
parent a095641495
commit cc07f3904e
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
scst/src/scst_lib.c
View File

@@ -76,11 +76,11 @@ static int get_trans_len_4(struct scst_cmd *cmd, uint8_t off);
static int get_bidi_trans_len_2(struct scst_cmd *cmd, uint8_t off);
/* for special commands */
static int get_trans_len_fmt(struct scst_cmd *cmd, uint8_t off);
static int get_verify_trans_len_2(struct scst_cmd *cmd, uint8_t off);
static int get_verify_trans_len_3(struct scst_cmd *cmd, uint8_t off);
static int get_verify_trans_len_4(struct scst_cmd *cmd, uint8_t off);
/* for special commands */
static int get_trans_len_block_limit(struct scst_cmd *cmd, uint8_t off);
static int get_trans_len_read_capacity(struct scst_cmd *cmd, uint8_t off);
static int get_trans_len_serv_act_in(struct scst_cmd *cmd, uint8_t off);
@@ -192,8 +192,8 @@ static const struct scst_sdbops scst_scsi_op_table[] = {
SCST_EXCL_ACCESS_ALLOWED,
4, get_trans_len_1},
{0x04, "M O O ", "FORMAT UNIT",
SCST_DATA_WRITE, SCST_LONG_TIMEOUT|SCST_UNKNOWN_LENGTH|SCST_WRITE_MEDIUM,
0, get_trans_len_none},
SCST_DATA_NONE, SCST_LONG_TIMEOUT|SCST_WRITE_MEDIUM,
0, get_trans_len_fmt},
{0x04, " O ", "FORMAT",
SCST_DATA_NONE, SCST_WRITE_MEDIUM, 0, get_trans_len_none},
{0x05, "VMVVVV V ", "READ BLOCK LIMITS",
@@ -5123,6 +5123,16 @@ static int get_bidi_trans_len_2(struct scst_cmd *cmd, uint8_t off)
return 0;
}
static int get_trans_len_fmt(struct scst_cmd *cmd, uint8_t off)
{
if (cmd->cdb[1] & 0x04/*FMTDATA*/) {
cmd->data_direction = SCST_DATA_WRITE;
cmd->op_flags |= SCST_UNKNOWN_LENGTH;
}
return 0;
}
/*
* get_verify_trans_len_2() - Compute transport len and dir for SCSI VERIFY.
*