mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-23 05:31:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

It's wrong to clean reservation on failed RESERVE commands

Browse Source 
With multiple outstanding commands it can open a race window leading to
loose of a valid reservation



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5490 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2014-04-29 00:13:24 +00:00
parent 8a53a54081
commit d51053c5d9
1 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
scst/src/scst_targ.c
View File

@@ -3595,23 +3595,6 @@ static int scst_pre_dev_done(struct scst_cmd *cmd)
TRACE(TRACE_SCSI, "cmd %p not succeeded with status %x",
cmd, cmd->status);
if ((cmd->cdb[0] == RESERVE) || (cmd->cdb[0] == RESERVE_10)) {
struct scst_device *dev = cmd->dev;
if (scst_is_reservation_holder(dev, cmd->sess)) {
TRACE(TRACE_SCSI, "RESERVE failed lun=%lld, "
"status=%x",
(long long unsigned int)cmd->lun,
cmd->status);
PRINT_BUFF_FLAG(TRACE_SCSI, "Sense", cmd->sense,
cmd->sense_valid_len);
spin_lock_bh(&dev->dev_lock);
scst_clear_dev_reservation(dev);
spin_unlock_bh(&dev->dev_lock);
}
}
/* Check for MODE PARAMETERS CHANGED UA */
if ((cmd->dev->scsi_dev != NULL) &&
(cmd->status == SAM_STAT_CHECK_CONDITION) &&