mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-21 04:31:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

scst_pr_read_reservation(): Initialize returned buffer

Browse Source 
Avoid that this function returns an uninitialized buffer to the
initiator if buffer_size < 8. Detected by Coverity.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5602 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2014-06-13 23:57:26 +00:00
parent 14f4e35b64
commit dc37ed9b4d
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scst/src/scst_pres.c
View File

@@ -2567,7 +2567,7 @@ void scst_pr_read_reservation(struct scst_cmd *cmd, uint8_t *buffer,
int buffer_size)
{
struct scst_device *dev = cmd->dev;
uint8_t b[24];
uint8_t b[24] = { };
int size = 0;
TRACE_ENTRY();
@@ -2580,8 +2580,6 @@ void scst_pr_read_reservation(struct scst_cmd *cmd, uint8_t *buffer,
goto out;
}
memset(b, 0, sizeof(b));
put_unaligned_be32(dev->pr_generation, &b[0]);
if (!dev->pr_is_set) {