mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-18 03:01:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

qla2x00t: Simplify q2t_create_sess()

Browse Source 
Replace a kmalloc() and sprintf() call by a kasprintf() call. This
patch does not change any functionality.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4998 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2013-09-11 22:44:04 +00:00
parent 8a03df3ed0
commit e3b9d00d97
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
qla2x00t/qla2x00-target/qla2x00t.c
View File

@@ -1133,7 +1133,6 @@ static struct q2t_sess *q2t_create_sess(scsi_qla_host_t *ha, fc_port_t *fcport,
bool local)
{
char *wwn_str;
const int wwn_str_len = 3*WWN_SIZE+2;
struct q2t_tgt *tgt = ha->tgt;
struct q2t_sess *sess;
scsi_qla_host_t *pha = to_qla_parent(ha);
@@ -1197,7 +1196,12 @@ static struct q2t_sess *q2t_create_sess(scsi_qla_host_t *ha, fc_port_t *fcport,
BUILD_BUG_ON(sizeof(sess->port_name) != sizeof(fcport->port_name));
memcpy(sess->port_name, fcport->port_name, sizeof(sess->port_name));
wwn_str = kmalloc(wwn_str_len, GFP_KERNEL);
wwn_str = kasprintf(GFP_KERNEL,
"%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x",
fcport->port_name[0], fcport->port_name[1],
fcport->port_name[2], fcport->port_name[3],
fcport->port_name[4], fcport->port_name[5],
fcport->port_name[6], fcport->port_name[7]);
if (wwn_str == NULL) {
PRINT_ERROR("qla2x00t(%ld): Allocation of wwn_str failed. "
"All commands from port %02x:%02x:%02x:%02x:%02x:%02x:"
@@ -1209,12 +1213,6 @@ static struct q2t_sess *q2t_create_sess(scsi_qla_host_t *ha, fc_port_t *fcport,
goto out_free_sess;
}
sprintf(wwn_str, "%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x",
fcport->port_name[0], fcport->port_name[1],
fcport->port_name[2], fcport->port_name[3],
fcport->port_name[4], fcport->port_name[5],
fcport->port_name[6], fcport->port_name[7]);
/* Let's do the session creation async'ly */
sess->scst_sess = scst_register_session(tgt->scst_tgt, 1, wwn_str,
sess, sess, q2t_alloc_session_done);