mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-17 10:41:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible BUG_ON() on multiple forced commands release

Browse Source 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4513 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2012-09-11 20:38:57 +00:00
parent a2825d8b06
commit e9008a5b12
2 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
iscsi-scst/kernel/iscsi.c
View File

@@ -542,7 +542,30 @@ void req_cmnd_release_force(struct iscsi_cmnd *req)
TRACE_ENTRY();
TRACE_MGMT_DBG("req %p", req);
if (req->force_release_done) {
/*
* There are some scenarios when this function can be called
* more, than once, for the same req. For instance, dropped
* command in iscsi_push_cmnd() and then for it
* iscsi_fail_data_waiting_cmnd() during closing (aborting) this
* connection or from iscsi_check_tm_data_wait_timeouts().
*/
TRACE_MGMT_DBG("Double force release for req %p", req);
EXTRACHECKS_BUG_ON(!req->release_called);
sBUG_ON(req->hashed);
sBUG_ON(req->cmd_req);
sBUG_ON(req->main_rsp != NULL);
sBUG_ON(!list_empty(&req->rx_ddigest_cmd_list));
sBUG_ON(!list_empty(&req->rsp_cmd_list));
sBUG_ON(req->pending);
cmnd_put(req);
goto out;
} else
TRACE_MGMT_DBG("req %p", req);
req->force_release_done = 1;
sBUG_ON(req == conn->read_cmnd);
@@ -601,6 +624,7 @@ void req_cmnd_release_force(struct iscsi_cmnd *req)
req_cmnd_release(req);
out:
TRACE_EXIT();
return;
}

1
iscsi-scst/kernel/iscsi.h
View File

@@ -384,6 +384,7 @@ struct iscsi_cmnd {
* req_cmnd_release() supposed to be called only once.
*/
unsigned int data_out_in_data_receiving:1;
unsigned int force_release_done:1;
#ifdef CONFIG_SCST_EXTRACHECKS
unsigned int on_rx_digest_list:1;
unsigned int release_called:1;