- Compiler made to show more warnings

- New warnings fixed



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@484 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2008-07-31 10:01:45 +00:00
parent 5a5f1d3247
commit fdbe23b77c
17 changed files with 38 additions and 32 deletions

View File

@@ -9,8 +9,8 @@ Index: iscsi-scst/kernel/Makefile
-EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
+#EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DCONFIG_SCST_ISCSI_DEBUG_DIGEST_FAILURES

View File

@@ -8,10 +8,10 @@ Index: iscsi-scst/kernel/Makefile
-EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
-#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
+#EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
+EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DCONFIG_SCST_ISCSI_DEBUG_DIGEST_FAILURES

View File

@@ -104,8 +104,8 @@ struct iscsi_param_info {
u32 param_type;
u32 partial;
u32 session_param[session_key_last];
u32 target_param[target_key_last];
s32 session_param[session_key_last];
s32 target_param[target_key_last];
};
enum iscsi_event_state {

View File

@@ -25,7 +25,7 @@ EXTRA_CFLAGS += -I$(src)/../include -I$(SCST_INC_DIR)
EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DCONFIG_SCST_ISCSI_DEBUG_DIGEST_FAILURES

View File

@@ -91,13 +91,13 @@ static void log_params(struct iscsi_sess_param *param)
/* target_mutex supposed to be locked */
static void sess_param_check(struct iscsi_param_info *info)
{
u32 *iparam = info->session_param;
s32 *iparam = info->session_param;
CHECK_PARAM(info, iparam, max_connections, 1, 1);
CHECK_PARAM(info, iparam, max_recv_data_length, 512,
(u32) (ISCSI_CONN_IOV_MAX * PAGE_SIZE));
(s32) (ISCSI_CONN_IOV_MAX * PAGE_SIZE));
CHECK_PARAM(info, iparam, max_xmit_data_length, 512,
(u32) (ISCSI_CONN_IOV_MAX * PAGE_SIZE));
(s32) (ISCSI_CONN_IOV_MAX * PAGE_SIZE));
CHECK_PARAM(info, iparam, error_recovery_level, 0, 0);
CHECK_PARAM(info, iparam, data_pdu_inorder, 0, 1);
CHECK_PARAM(info, iparam, data_sequence_inorder, 0, 1);

View File

@@ -42,4 +42,6 @@ typedef u_int16_t u16;
typedef u_int32_t u32;
typedef u_int64_t u64;
typedef int32_t s32;
#endif /* TYPES_H */

View File

@@ -9,8 +9,8 @@ Index: qla2x00t/qla2x00-target/Makefile
-EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
+#EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
-EXTRA_CFLAGS += -DDEBUG_TGT -g
+#EXTRA_CFLAGS += -DDEBUG_TGT -g
-EXTRA_CFLAGS += -DDEBUG_TGT -g -W -Wno-unused-parameter
+#EXTRA_CFLAGS += -DDEBUG_TGT -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DDEBUG_WORK_IN_THREAD
ifeq ($(KVER),)

View File

@@ -8,10 +8,10 @@ Index: qla2x00t/qla2x00-target/Makefile
-EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
-#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
-EXTRA_CFLAGS += -DDEBUG_TGT -g
-EXTRA_CFLAGS += -DDEBUG_TGT -g -W -Wno-unused-parameter
+#EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
+EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
+#EXTRA_CFLAGS += -DDEBUG_TGT -g
+#EXTRA_CFLAGS += -DDEBUG_TGT -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DDEBUG_WORK_IN_THREAD
ifeq ($(KVER),)

View File

@@ -37,7 +37,7 @@ INSTALL_DIR := /lib/modules/$(shell uname -r)/extra
EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
EXTRA_CFLAGS += -DDEBUG_TGT -g
EXTRA_CFLAGS += -DDEBUG_TGT -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DDEBUG_WORK_IN_THREAD
ifeq ($(KVER),)

View File

@@ -674,7 +674,7 @@ static int q2t_xmit_response(struct scst_cmd *scst_cmd)
struct q2t_sess *sess;
int is_send_status;
unsigned long flags = 0;
struct q2t_prm prm = { 0 };
struct q2t_prm prm;
int data_sense_flag = 0;
uint16_t full_req_cnt;
@@ -686,6 +686,8 @@ static int q2t_xmit_response(struct scst_cmd *scst_cmd)
return SCST_TGT_RES_NEED_THREAD_CTX;
#endif
memset(&prm, 0, sizeof(prm));
prm.cmd = (struct q2t_cmd *)scst_cmd_get_tgt_priv(scst_cmd);
sess = (struct q2t_sess *)
scst_sess_get_tgt_priv(scst_cmd_get_session(scst_cmd));
@@ -831,7 +833,7 @@ static int q2t_rdy_to_xfer(struct scst_cmd *scst_cmd)
int res = SCST_TGT_RES_SUCCESS;
struct q2t_sess *sess;
unsigned long flags = 0;
struct q2t_prm prm = { 0 };
struct q2t_prm prm;
TRACE_ENTRY();
TRACE(TRACE_SCSI, "tag=%Ld", scst_cmd_get_tag(scst_cmd));
@@ -841,6 +843,8 @@ static int q2t_rdy_to_xfer(struct scst_cmd *scst_cmd)
return SCST_TGT_RES_NEED_THREAD_CTX;
#endif
memset(&prm, 0, sizeof(prm));
prm.cmd = (struct q2t_cmd *)scst_cmd_get_tgt_priv(scst_cmd);
sess = (struct q2t_sess *)
scst_sess_get_tgt_priv(scst_cmd_get_session(scst_cmd));

View File

@@ -15,8 +15,8 @@ Index: scst/src/Makefile
#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_TM -UCONFIG_SCST_TM_DBG_GO_OFFLINE
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_RETRY
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_OOM
@@ -32,8 +32,8 @@ Index: scst/src/dev_handlers/Makefile
+#EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
clean:
rm -f *.o *.ko .*.cmd *.mod.c .*.d .depend Modules.symvers \

View File

@@ -18,8 +18,8 @@ Index: scst/src/Makefile
-#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
+EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_TM -UCONFIG_SCST_TM_DBG_GO_OFFLINE
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_RETRY
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_OOM
@@ -35,9 +35,9 @@ Index: scst/src/dev_handlers/Makefile
+#EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
-#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
-EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
+EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
+#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
clean:
rm -f *.o *.ko .*.cmd *.mod.c .*.d .depend Modules.symvers \

View File

@@ -125,7 +125,7 @@ EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_TM -UCONFIG_SCST_TM_DBG_GO_OFFLINE
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_RETRY
#EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG_OOM

View File

@@ -72,7 +72,7 @@ EXTRA_CFLAGS += -I$(SUBDIRS) -I$(SCST_INC_DIR) -Wextra -Wno-unused-parameter
EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS
#EXTRA_CFLAGS += -DCONFIG_SCST_TRACING
EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g
EXTRA_CFLAGS += -DCONFIG_SCST_DEBUG -g -W -Wno-unused-parameter
clean:
rm -f *.o *.ko .*.cmd *.mod.c .*.d .depend Modules.symvers \

View File

@@ -9,8 +9,8 @@ Index: usr/fileio/Makefile
-CFLAGS += -DEXTRACHECKS
+#CFLAGS += -DEXTRACHECKS
#CFLAGS += -DTRACING
-CFLAGS += -DDEBUG -g
+#CFLAGS += -DDEBUG -g
-CFLAGS += -DDEBUG -g -W -Wno-unused-parameter
+#CFLAGS += -DDEBUG -g -W -Wno-unused-parameter
#CFLAGS += -DDEBUG_NOMEM
#CFLAGS += -DDEBUG_SENSE

View File

@@ -8,10 +8,10 @@ Index: usr/fileio/Makefile
-CFLAGS += -DEXTRACHECKS
-#CFLAGS += -DTRACING
-CFLAGS += -DDEBUG -g
-CFLAGS += -DDEBUG -g -W -Wno-unused-parameter
+#CFLAGS += -DEXTRACHECKS
+CFLAGS += -DTRACING
+#CFLAGS += -DDEBUG -g
+#CFLAGS += -DDEBUG -g -W -Wno-unused-parameter
#CFLAGS += -DDEBUG_NOMEM
#CFLAGS += -DDEBUG_SENSE

View File

@@ -32,7 +32,7 @@ LIBS = -lpthread
CFLAGS += -DEXTRACHECKS
#CFLAGS += -DTRACING
CFLAGS += -DDEBUG -g
CFLAGS += -DDEBUG -g -W -Wno-unused-parameter
#CFLAGS += -DDEBUG_NOMEM
#CFLAGS += -DDEBUG_SENSE