Commit Graph

6725 Commits

Author SHA1 Message Date
Bart Van Assche
041ef55247 scripts/kernel-functions: Fix the RHEL 6.x build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8909 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 21:27:11 +00:00
Bart Van Assche
57d9df0717 scst: Remove an empty function
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8908 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:52:23 +00:00
Bart Van Assche
bcdfc28dd8 iscsi-scst: Add a hint what to look for if no userspace process is connected
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
[ bvanassche: edited description and patch ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8907 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:48:12 +00:00
Bart Van Assche
115ec5be90 scripts/kernel-functions: Only apply RHEL patches on RHEL kernels
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8906 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:37:30 +00:00
Bart Van Assche
858f50e4d3 scstadmin: Improve robustness
Instead of only interpreting the empty string as "no argument passed", also
consider 'undef' as "no argument passed".


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8905 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 17:24:35 +00:00
Bart Van Assche
ee0328f6f7 scst: Drop support for scst_register_target(..., NULL)
Support for autogenerated target names was declared obsolete in 2011. Remove
support for autogenerated target names. See also commit 21d503cbb7
("Autogenerated SCST target names made deprecated").


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8904 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 17:23:14 +00:00
Bart Van Assche
08ba5d8f1a iscsi-scst: Remove unnecessary %s format modifiers
See also https://github.com/bvanassche/scst/pull/18.

Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8903 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-12 14:57:00 +00:00
Bart Van Assche
95893200f2 scst_user: Fix a recently introduced coding style issue
See also commit b2facc91c9 ("scst/src/dev_handlers/scst_user: Simplify dev_user_reply_get_multi()").



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8902 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-12 01:04:32 +00:00
Bart Van Assche
58a1ea5bd7 scripts/generate-kernel-patch: Use read instead of readarray and fix shellcheck warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8901 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:38:25 +00:00
Bart Van Assche
056f426165 scripts/kernel-functions: Make this script compatible with bash versions that do not support readarray
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8900 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:37:43 +00:00
Bart Van Assche
9429a9930f scripts/rhel-rpm-functions: Use ${...//...} instead of setting the IFS variable
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8899 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:36:04 +00:00
Bart Van Assche
04b4ee34fe scripts/run-regression-tests: Fix the CentOS 6.x build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8894 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 20:47:33 +00:00
Bart Van Assche
f40d96c8a0 scripts/run-regression-tests: Make the CentOS build less noisy
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8893 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 19:00:39 +00:00
Bart Van Assche
ab4f2f5077 scripts/generate-kernel-patch: Use the generic drivers Makefile for CentOS 6.x
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8892 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:59:38 +00:00
Bart Van Assche
30488c97b9 nightly/conf/nightly.conf: Add CentOS kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8891 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:39:34 +00:00
Bart Van Assche
8485b98f05 scripts/kernel-functions: Suppress RHEL warnings about module_init() / module_exit()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8890 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:38:58 +00:00
Bart Van Assche
676b1717fb scripts/specialize-patch: More bug fixes for RHEL / CentOS kernels
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8889 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:37:03 +00:00
Bart Van Assche
7b764b1499 fcst: Suppress sparse warnings
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8888 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:36:21 +00:00
Bart Van Assche
1195daa855 scripts/specialize-patch: Fix RHEL kernel version checks
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8887 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:56:56 +00:00
Bart Van Assche
24b832098b scst: Fix the build against a RHEL 8 debug kernel
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8886 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:55:21 +00:00
Bart Van Assche
6773f8e9a5 scripts/run-regression-tests: Add support for distro kernels
A few examples of how to run the regression tests against a distro kernel:

scripts/run-regression-tests -l 4.18.0-147.5.1.el8_1^CentOS^8.1.1911-nc
scripts/run-regression-tests -l 4.18.0-80.11.2.el8_0^CentOS^8.0.1905-nc
scripts/run-regression-tests -l 3.10.0-1127.el7^CentOS^7.8.2003-nc
scripts/run-regression-tests -l 3.10.0-1062.18.1.el7^CentOS^7.7.1908-nc
scripts/run-regression-tests -l 3.10.0-957.27.2.el7^CentOS^7.6.1810-nc
scripts/run-regression-tests -l 3.10.0-862.14.4.el7^CentOS^7.5.1804-nc



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8885 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:54:47 +00:00
Bart Van Assche
b3b658bd09 scripts/generate-kernel-patch: Make several paths absolute
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8884 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:48:23 +00:00
Bart Van Assche
24caf06381 scripts/rhel-rpm-functions: Add more URLs
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8883 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:47:45 +00:00
Bart Van Assche
5b1a15d3c9 scstadmin/init.d/scst: Simplify sed expressions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8882 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:46:59 +00:00
Bart Van Assche
17a0091804 scstadmin/init.d/scst: Fix shellcheck warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8881 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:46:02 +00:00
Bart Van Assche
5400331606 scripts/rhel-rpm-functions: Restore this file by reverting r8111
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8880 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 19:38:33 +00:00
Bart Van Assche
f4ce28b5ab scst/include/backport.h: Unbreak the build on RHEL 7 / CentOS 7
Fixes: 5ebd20d839 ("scst/include/backport.h: Backport cpu_to_be32_array()")


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8879 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 15:11:29 +00:00
Bart Van Assche
289ae036e5 qla2x00t-32gbit: Fix a compiler warning triggered by kernel versions before v4.10
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8878 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 15:11:05 +00:00
Bart Van Assche
5a99fa9a8c qla2x00t-32gbit: Move the trace/events/qla.h include file
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8877 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-08 15:32:10 +00:00
Bart Van Assche
9ece5279ad Add the qla2x00t-32gbit/trace/events/qla.h file to the output of scripts/generate-kernel-patch
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8876 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-08 15:23:43 +00:00
Bart Van Assche
178eef8917 qla2x00t-32gbit: Revert two changes that had been checked in accidentally
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8875 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 16:55:10 +00:00
Bart Van Assche
f99de361ed Update svn:ignore properties
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8874 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 16:28:22 +00:00
Bart Van Assche
66184b6b25 qla2x00t-32gbit: make 1-bit bit-fields unsigned int
The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed
which is not recommended as the representation is an implementation defined
behaviour.  Fix this by making the bit-fields unsigned ints.

Link: https://lore.kernel.org/r/20200428102013.1040598-1-colin.king@canonical.com
Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 78b874b7cbf09fbfadfa5f18a347ebef7bbb49fe upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8873 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 16:06:41 +00:00
Bart Van Assche
582746f829 qla2x00t-32gbit: Fix MPI failure AEN (8200) handling
Today, upon an MPI failure AEN, on top of collecting an MPI dump, a regular
firmware dump is also taken and then chip reset. This is disruptive to IOs
and not required. Make the firmware dump collection, followed by chip
reset, optional (not done by default).

Firmware dump buffer and MPI dump buffer are independent of each
other with this change and each can have dump that was taken at two
different times for two different issues. The MPI dump is saved in a
separate buffer and is retrieved differently from firmware dump.

To collect full dump on MPI failure AEN, a module parameter is
introduced:
    ql2xfulldump_on_mpifail (default: 0)

Link: https://lore.kernel.org/r/20200331104015.24868-2-njavali@marvell.com
Reported-by: kbuild test robot <lkp@intel.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit cbb01c2f2f630f1497f703c51ff21538ae2d86b8 upstream ]



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8872 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 16:05:56 +00:00
Bart Van Assche
28e8c3fa48 qla2x00t-32gbit: Use ARRAY_SIZE() instead of open-coding it
This patch does not change any functionality.

Link: https://lore.kernel.org/r/20200413021359.21725-1-bvanassche@acm.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Daniel Wagner <dwagner@suse.de>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit d221aed19c80d83c2de2fa5e8a5ba045065c6d4b upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8871 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 16:05:02 +00:00
Bart Van Assche
bf6dcb17a0 qla2x00t-32gbit: Split qla2x00_configure_local_loop()
The size of the function qla2x00_configure_local_loop() hurts its
readability. Hence split that function. This patch does not change any
functionality.

Link: https://lore.kernel.org/r/20200405225905.17171-1-bvanassche@acm.org
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Quinn Tran <qutran@marvell.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Daniel Wagner <dwagner@suse.de>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 21e855cdfeb91cf2fe92cd608c3f1d657fc73c5c upstream ]



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8870 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 16:04:06 +00:00
Bart Van Assche
72a90c1b5a qla2x00t-32gbit: Remove non functional code
Remove code which has no functional use anymore since commit 3c75ad1d87c7
("scsi: qla2xxx: Remove defer flag to indicate immeadiate port loss").
    
While at it remove also the stale function documentation.

Link: https://lore.kernel.org/r/20200206135443.110701-1-dwagner@suse.de
Reviewed-by: Arun Easi <aeasi@marvell.com>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 1b72e86ddbbc7fb55771bf649d81c2513830a6a5 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8869 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 16:03:08 +00:00
Bart Van Assche
2286974744 qla2x00t-32gbit: Add ring buffer for tracing debug logs
Having this log in a ring buffer helps to diagnose qla2xxx driver and
firmware issues instead of having to reproduce the problem with
extended_logging enabled. This saves cycles and helps when it is hard
to reproduce problem.
    
Link: https://lore.kernel.org/r/1581557368-32080-1-git-send-email-rajan.shanmugavelu@oracle.com
Reviewed-by: Joe Jin <joe.jin@oracle.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Rajan Shanmugavelu <rajan.shanmugavelu@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 598a90f2002c4c4daee24d76d24e8270c7075eef upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8868 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 16:01:42 +00:00
Bart Van Assche
afc46c6053 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8867 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 15:10:15 +00:00
Bart Van Assche
3f97a8d3cb iscsi-scst, srpt: Fix the build against MOFED 5
Reported-by: Grant Albitz <Cryptz@Cryptz.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8866 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 03:26:38 +00:00
Bart Van Assche
102797b00b qla2x00t-32gbit: Port to Linux kernel v5.7
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8865 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-21 02:26:16 +00:00
Bart Van Assche
540dc57576 qla2x00t: Port to Linux kernel v5.7
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8864 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-21 02:25:58 +00:00
Bart Van Assche
ab29dc4430 scst: Port to Linux kernel v5.7
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8863 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-21 02:25:32 +00:00
Bart Van Assche
40f36a6873 scst_user: Set replies_done to zero if replies_cnt == 0
This patch prevents that fileio_tgt becomese unresponsive.

Reported-by: James McCarthy <mccarthy1029@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8861 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-11 17:11:33 +00:00
Bart Van Assche
32c2db1acf nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8857 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-08 14:41:35 +00:00
Bart Van Assche
a8b636e09f scst/src/dev_handlers/scst_user: Remove two casts from dev_user_reply_get_cmd()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8851 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-04 23:39:48 +00:00
Bart Van Assche
b2facc91c9 scst/src/dev_handlers/scst_user: Simplify dev_user_reply_get_multi()
Remove multiple pointer casts. This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8850 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-04 23:24:47 +00:00
Bart Van Assche
1db9c3c8b2 scst/kernel/in-tree/Makefile.drivers.Linux.patch: Port to kernel v5.6
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8849 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-04 22:59:14 +00:00
Bart Van Assche
fcfb8f873d scst/kernel/in-tree/Makefile.scst: Add scst_local_cmd.o
Signed-off-by: Sietse van Zanen <sietse@wizdom.nu>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8848 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-03 02:10:40 +00:00
Bart Van Assche
cff108855e scst/src/Makefile: Sort source file names alphabetically
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8847 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-04-03 02:07:01 +00:00