mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-08-20 14:16:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,718 Commits 27 Branches 11 Tags
058ad7ac91bbb10da5422cde997ee52fa5dd48d7
Commit Graph
649 Commits
Author SHA1 Message Date
Bart Van Assche 7a2d9043f6 isert: Fix use-after-free when work requests were submitted after drain_wr 
We were submitting work requests sometimes after the drain_wr,
so we would try to process flushes on something that is already
destroyed. This can be seen with very high login/logout load.

Signed-off-by: Yan Burman <yanb@mellanox.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6428 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-07-27 15:26:09 +00:00
Bart Van Assche 6c0a869007 isert-scst: Linux kernel v4.2 ib_create_cq() build fix 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6427 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-07-14 23:57:42 +00:00
Bart Van Assche d05518f5bc isert-scst: Kernel v4.2 build fix 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6425 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-07-14 23:47:50 +00:00
Bart Van Assche 8eb3f31eea iscsi-scst: Fix parameter order in a debug statement 
Signed-off-by: Alexey Obitotskiy <mobbitster@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6421 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-07-14 21:50:51 +00:00
Bart Van Assche ebcfc73439 isert: Allocate sge and wr structures dynamically 
In order to be able to support large block sizes (larger than 512K),
we allocate required structured in a lazy fashion. This way we both support
large block sizes (over 512K and even over 1M). We also lower memory footprint
when smaller block sizes are used.

Signed-off-by: Yan Burman <yanb@mellanox.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6418 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-07-11 03:41:15 +00:00
Bart Van Assche 993f290908 isert-scst: Port this driver to RHEL 5 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6416 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-07-10 22:27:37 +00:00
Bart Van Assche f92a917d45 iscsi-scst: Suppress strict aliasing compiler warnings 
Avoid that the compiler reports warnings about strict aliasing when
building iscsi-scst on RHEL 6. This patch does not change any
functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6414 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-07-10 22:22:57 +00:00
Vladislav Bolkhovitin 1656efe689 iscsi-scst: small post-r6315 cleanup 
Avoid that rd_task declared when it is not used



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6408 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-07-03 04:21:52 +00:00
Bart Van Assche 75369451a5 isert-scst/Kconfig: Add InfiniBand dependency 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6402 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-25 14:12:54 +00:00
Bart Van Assche 79c8bf1f7c iscsi-scst, isert-scst: One trace flags variable per kernel module 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6397 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-23 15:01:17 +00:00
Bart Van Assche f0e98ee4b2 isert-scst: Build fix for older kernel versions (< 2.6.29) 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6395 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-19 14:06:05 +00:00
Bart Van Assche 46915ef3e5 iscsi-scst: Fix a syntax error 
Preprocessor directives are not allowed in argument lists of a macro.
This patch reverts r6317.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6393 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 05:00:20 +00:00
Bart Van Assche 11df045449 iscsiadm: Fix a resource leak in an error path 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6389 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:32:53 +00:00
Bart Van Assche bb0a7c894a iscsi-scstd: Annotate a fall-through for Coverity 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6388 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:32:27 +00:00
Bart Van Assche 476d0ba898 iscsi-scstd: Constify several function arguments 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6387 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:32:02 +00:00
Bart Van Assche f05dfcf88f iscsi-scstd: Suppress a compiler warning 
Avoid that gcc reports the following compiler warning:
    
message.c:197:44: warning: 'rsp_data_sz' may be used uninitialized in this function [-Wmaybe-uninitialized]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6386 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:31:20 +00:00
Bart Van Assche 8a4e41fb44 iscsi-scstd: Allow the compiler to inline functions 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6385 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:30:40 +00:00
Bart Van Assche a8da0107f8 iscsiadm: Fix a resource leak 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6380 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:28:02 +00:00
Bart Van Assche ad38432332 iscsiadm: Fix strerror() argument 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6379 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:27:41 +00:00
Bart Van Assche a14df39942 iscsiadm: Do not allocate more memory than needed 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6378 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:27:18 +00:00
Bart Van Assche ff2b660264 iscsiadm: Fix a file descriptor leak in an error path 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6377 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:26:35 +00:00
Bart Van Assche f5f85b95fb iscsi-scstd: Fix a resource leak in an error path 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6376 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:26:08 +00:00
Bart Van Assche a6121b03c8 iscsi-scstd: Fix a potential file descriptor leak 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6375 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:25:42 +00:00
Bart Van Assche 74b4104994 iscsi-scstd: Avoid that Coverity complains about a use-after-free 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6374 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:25:05 +00:00
Bart Van Assche b3f49a0a17 iscsi-scstd: Annotate fall-throughs for Coverity 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6373 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:24:25 +00:00
Bart Van Assche 102d8d54c9 iscsi-scstd: Move two local variables to suppress a Coverity complaint 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6372 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:24:03 +00:00
Bart Van Assche 41caee3148 iscsi-scstd: Fix a file descriptor leak in an error path 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6371 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:23:38 +00:00
Bart Van Assche 21b60063a9 iscsi-scstd: Fix a dereference-before-null-check 
Detected by Coverity.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6370 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:23:14 +00:00
Bart Van Assche b099782023 iscsi-scstd: Fix a memory leak in the iSNS code 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6369 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:22:46 +00:00
Bart Van Assche dfcb53a9b2 iscsi-scstd: Rearrange driver major number lookup code 
Introduce a function for looking up the driver major number.
This patch does not change any functionality but makes the source
code easier to read and also makes it easier for Coverity to
analyze this code.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6368 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:22:14 +00:00
Bart Van Assche 165b0f1d10 iscsi-scstd: Improve create_and_open_dev() robustness 
Reset 'devn' if the sscanf() return value is lower than two.
Based on a Coverity report.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6367 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:21:28 +00:00
Bart Van Assche d70b1e39c0 iscsi-scstd: Fix a dereference-before-null-check 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6366 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:20:21 +00:00
Bart Van Assche 40a90a705d isert-scst: Add address length check in isert_listen_ioctl() 
Detected by Coverity.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6365 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:19:27 +00:00
Bart Van Assche 26cda0eb38 iscsi-scst: Annotate fall-through cases for Coverity 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6364 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:18:23 +00:00
Bart Van Assche 63cb4a9d40 iscsi-scst: Fix indentation 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6363 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:09:23 +00:00
Bart Van Assche 612fac9874 isert: Declare a local function static 
Detected by checkpatch.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6354 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 23:55:52 +00:00
Bart Van Assche eb10fe3f7d iscsi-scst: Surround complex values with parentheses 
Detected by checkpatch.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6353 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 23:55:22 +00:00
Bart Van Assche dce5cbc1cb iscsi-scst/README: Add a reference 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6348 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 23:52:10 +00:00
Bart Van Assche f272064c12 iscsi-scst: Suppress put_page_callback patch warnings 
The put_page_callback patch only improves performance on single
socket systems but not on systems with multiple CPU sockets.
Since this message is confusing to SCST users, do not print a
warning if the put_page_callback patch has not been applied.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6340 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 23:10:28 +00:00
Bart Van Assche 6b3f45696a RHEL 7.1: Add put_page_callback patch 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6336 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 20:17:52 +00:00
Bart Van Assche 807c4eacf0 isert: Use break in default case 
Detected by checkpatch.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6328 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 18:51:47 +00:00
Bart Van Assche 7c3b2c4ca6 iscsi-scst: Fix spelling in a source code comment 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6321 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 15:53:31 +00:00
Bart Van Assche bdf2c68e8a iscsi-scst/Makefile: Only report the OFED flavor when building the iSER target driver 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6320 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 13:27:49 +00:00
Vladislav Bolkhovitin 3e9eaf6b29 iscsi-scst: small post-r6315 cleanup 
Avoid that rd_task when it is not used



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6317 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 01:43:26 +00:00
Bart Van Assche 7566e2ed71 Avoid that compiler warnings depend on the build mode 
It is annoying that some warnings are only reported in release mode.
Modify scst_debug.h such that the compiler does not report variables
that are only used in debug builds as unused.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6315 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-15 22:15:07 +00:00
Bart Van Assche 15535bf648 iscsi-scst: Suppress a compiler warning 
Avoid that the compiler complains that the variable 'pad_bytes'
is not used with CONFIG_LIBCRC32C=n.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6314 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-15 22:06:29 +00:00
Bart Van Assche 9e700c6c03 iscsi-scst/Makefile: Only build the iSER target driver if InfiniBand has been enabled in the kernel config 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6313 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-15 14:41:35 +00:00
Bart Van Assche 0d9d6a6f57 isert-scst: Fix in-tree build 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6312 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-12 16:15:45 +00:00
Bart Van Assche a2a22c0b95 isert-scst: Shorten the compiler include path 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6311 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-12 15:31:05 +00:00
Bart Van Assche e62155683e iscsi-scst: Fix a compiler warning for kernel versions >= 3.19 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6310 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-12 15:29:56 +00:00