Commit Graph

4719 Commits

Author SHA1 Message Date
Bart Van Assche
06ef46415c /etc/init.d/scst: Suppress an error message if iscsi-scstd is not installed
Avoid that the following error message is printed when stopping
or starting SCST if iscsi-scstd has not been installed:

# /sbin/service scst restart
which: no iscsi-scstd in
(/bin:/usr/bin:/sbin:/usr/sbin:/usr/local/sbin:/usr/local/bin)
Restarting SCST

Signed-off-by: Hiroyuki Sato <hiroysato@gmail.com>
[bvanassche: Eliminated ISCSI_DAEMON variable]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6436 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-29 17:20:43 +00:00
Bart Van Assche
058ad7ac91 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6435 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-29 17:14:28 +00:00
Bart Van Assche
b9f3fdb66b ib_srpt: Correct a regular expression in the README
Based on a patch from Hiroyuki Sato <hiroysato@gmail.com>.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6434 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-28 15:46:29 +00:00
Bart Van Assche
69ff2ed928 ib_srpt: Clarify RoCE documentation
This is a modified version of a patch supplied by
Hiroyuki Sato <hiroysato@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6433 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-28 15:40:12 +00:00
Bart Van Assche
14c82f892d /etc/init.d/scst: Fix stopping SCST with iSER loaded
Commit r6420 broke scst unloading, since isert_scst must be
unloaded before iscsi_scst.

Additionally, fix another possible cause of failing to unload
isert_scst. With iSER (RDMA CM to be exact) it may take up to
about 50 seconds to receive disconnected event if the remote end
is for some reason unreachable, e.g. becauase of a cable problem
or power loss/forced reboot on initiator side. This is due to MAD
send timeout.

Signed-off-by: Yan Burman <yanb@mellanox.com>
[bvanassche: modified this patch such that it uses unload_kmod()]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6432 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-28 15:28:59 +00:00
Bart Van Assche
bc070bc1bc scripts/specialize-patch: Handle #if 0 / #elif statement combinations correctly
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6431 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-28 05:38:07 +00:00
Bart Van Assche
2609ee1b86 srpt: Remove an empty directory
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6430 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-27 17:33:48 +00:00
Bart Van Assche
2715178d01 /etc/init.d/scst: Introduce function unload_kmod()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6429 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-27 16:10:36 +00:00
Bart Van Assche
7a2d9043f6 isert: Fix use-after-free when work requests were submitted after drain_wr
We were submitting work requests sometimes after the drain_wr,
so we would try to process flushes on something that is already
destroyed. This can be seen with very high login/logout load.

Signed-off-by: Yan Burman <yanb@mellanox.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6428 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-27 15:26:09 +00:00
Bart Van Assche
6c0a869007 isert-scst: Linux kernel v4.2 ib_create_cq() build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6427 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 23:57:42 +00:00
Bart Van Assche
0651bc1e4e ib_srpt: Linux kernel v4.2 ib_create_cq() build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6426 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 23:49:48 +00:00
Bart Van Assche
d05518f5bc isert-scst: Kernel v4.2 build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6425 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 23:47:50 +00:00
Bart Van Assche
5f95edc612 ib_srpt: Test whether ib_create_send_mad() needs a base_version argument
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6424 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 23:24:26 +00:00
Bart Van Assche
87b6fde56d ib_srpt: Linux kernel v4.2 build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6423 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 22:50:25 +00:00
Bart Van Assche
a771b35830 scst_targ: Kernel 4.2 build fix
Sebastian Herbszt <herbszt@gmx.de>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6422 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 21:52:40 +00:00
Bart Van Assche
8eb3f31eea iscsi-scst: Fix parameter order in a debug statement
Signed-off-by: Alexey Obitotskiy <mobbitster@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6421 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 21:50:51 +00:00
Bart Van Assche
8f49cd43bc /etc/init.d/scst: Avoid that starting SCST fails with CONFIG_INFINIBAND=n
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6420 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 18:26:38 +00:00
Bart Van Assche
e75e67bb51 qla2xxx: Fix indentation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6419 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-11 03:46:28 +00:00
Bart Van Assche
ebcfc73439 isert: Allocate sge and wr structures dynamically
In order to be able to support large block sizes (larger than 512K),
we allocate required structured in a lazy fashion. This way we both support
large block sizes (over 512K and even over 1M). We also lower memory footprint
when smaller block sizes are used.

Signed-off-by: Yan Burman <yanb@mellanox.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6418 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-11 03:41:15 +00:00
Bart Van Assche
d1c2869292 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6417 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 23:53:27 +00:00
Bart Van Assche
993f290908 isert-scst: Port this driver to RHEL 5
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6416 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 22:27:37 +00:00
Bart Van Assche
ae9de304c4 scst: Several RHEL 5 build fixes
Move the get_unaligned_*() functions up such that these occur
before the T10-PI functions. Backport the definition of
VARIABLE_LENGTH_CMD. Make scst_dif_crc_fn() build on RHEL 5
systems.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6415 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 22:26:43 +00:00
Bart Van Assche
f92a917d45 iscsi-scst: Suppress strict aliasing compiler warnings
Avoid that the compiler reports warnings about strict aliasing when
building iscsi-scst on RHEL 6. This patch does not change any
functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6414 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 22:22:57 +00:00
Bart Van Assche
84d90ac96e scst.h: Backport more cpumask.h functions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6413 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-10 16:04:27 +00:00
Bart Van Assche
ac156d84c0 scst.h: Add cpumask_var_t for kernel versions before 2.6.28
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6412 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-09 19:12:09 +00:00
Bart Van Assche
44542c9752 ib_srpt: Follow-up for r6410
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6411 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-09 19:11:04 +00:00
Bart Van Assche
b448c6edf4 ib_srpt: Add support for systems with more than 64 CPU's
Avoid that the following warning is reported on systems with more
than 64 CPU's:

WARNING: CPU: 0 PID: 4762 at drivers/scst/srpt/ib_srpt.c:4179 init_module+0x1d8f42/0x1db887 [ib_srpt]()
Call Trace:
 [<ffffffff8154f2ed>] dump_stack+0x46/0x58
 [<ffffffff8104b4ec>] warn_slowpath_common+0x8c/0xc0
 [<ffffffff8104b53a>] warn_slowpath_null+0x1a/0x20
 [<ffffffffa0236f42>] init_module+0x1d8f42/0x1db887 [ib_srpt]
 [<ffffffffa0233000>] ? 0xffffffffa0233000
 [<ffffffffa005e000>] ? 0xffffffffa005e000
 [<ffffffffa015d587>] ib_register_client+0x87/0xc0 [ib_core]
 [<ffffffffa005e0ef>] init_module+0xef/0x1000 [ib_srpt]
 [<ffffffffa005e000>] ? 0xffffffffa005e000
 [<ffffffff810002bc>] do_one_initcall+0x8c/0x1c0
 [<ffffffff81149022>] ? __vunmap+0xc2/0x110
 [<ffffffff810bb3e3>] load_module+0x1b03/0x22a0
 [<ffffffff810b7e80>] ? show_initstate+0x60/0x60
 [<ffffffff810bbcce>] SyS_finit_module+0x8e/0x90
 [<ffffffff81555a32>] system_call_fastpath+0x12/0x17

Reported-by: Jack Wang <xjtuwjp@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6410 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-08 18:23:24 +00:00
Bart Van Assche
ea8f0a8afb nightly build: Add kernel version 4.1
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6409 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-08 15:41:22 +00:00
Vladislav Bolkhovitin
1656efe689 iscsi-scst: small post-r6315 cleanup
Avoid that rd_task declared when it is not used



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6408 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-03 04:21:52 +00:00
Vladislav Bolkhovitin
3949bfa445 scst_vdisk: fix typo in vdisk_get_supported_opcodes()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6407 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-01 22:13:40 +00:00
Bart Van Assche
ce6721207e nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6406 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-30 01:11:54 +00:00
Bart Van Assche
2e07fca500 nightly build: Add kernel v4.1 build infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6405 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-28 15:45:59 +00:00
Bart Van Assche
12566f2781 nightly build: Update a kernel version
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6404 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-28 05:24:49 +00:00
Bart Van Assche
ef8d3ae376 nightly build: Update a kernel version
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6403 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-26 20:21:09 +00:00
Bart Van Assche
75369451a5 isert-scst/Kconfig: Add InfiniBand dependency
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6402 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-25 14:12:54 +00:00
Bart Van Assche
e3c906b4e5 scripts/run-regression-tests: Filter line numbers from the smatch output
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6400 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-24 15:18:48 +00:00
Bart Van Assche
2b209aedcd nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6398 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-24 03:24:37 +00:00
Bart Van Assche
79c8bf1f7c iscsi-scst, isert-scst: One trace flags variable per kernel module
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6397 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-23 15:01:17 +00:00
Bart Van Assche
f0e98ee4b2 isert-scst: Build fix for older kernel versions (< 2.6.29)
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6395 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-19 14:06:05 +00:00
Vladislav Bolkhovitin
3b124eb309 Fix NDOB parsing for WRITE_SAME32
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6394 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-18 01:43:47 +00:00
Bart Van Assche
46915ef3e5 iscsi-scst: Fix a syntax error
Preprocessor directives are not allowed in argument lists of a macro.
This patch reverts r6317.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6393 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 05:00:20 +00:00
Bart Van Assche
cd0a7b7b9d qla2x00t: Fix a potential buffer overflow
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6392 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:36:52 +00:00
Bart Van Assche
7b8ad56790 qla2x00t: Fix a potential buffer overflow
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6391 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:36:22 +00:00
Bart Van Assche
2a6a25ba45 qla2x00t: Change type of first argument of qla24xx_prep_ct_fm_req()
This makes it easier for Coverity to analyze this code.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6390 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:35:43 +00:00
Bart Van Assche
11df045449 iscsiadm: Fix a resource leak in an error path
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6389 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:32:53 +00:00
Bart Van Assche
bb0a7c894a iscsi-scstd: Annotate a fall-through for Coverity
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6388 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:32:27 +00:00
Bart Van Assche
476d0ba898 iscsi-scstd: Constify several function arguments
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6387 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:32:02 +00:00
Bart Van Assche
f05dfcf88f iscsi-scstd: Suppress a compiler warning
Avoid that gcc reports the following compiler warning:
    
message.c:197:44: warning: 'rsp_data_sz' may be used uninitialized in this function [-Wmaybe-uninitialized]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6386 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:31:20 +00:00
Bart Van Assche
8a4e41fb44 iscsi-scstd: Allow the compiler to inline functions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6385 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:30:40 +00:00
Bart Van Assche
4ad34f74d5 fileio: Fix a potential buffer overflow
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6384 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:30:16 +00:00