Commit Graph

5710 Commits

Author SHA1 Message Date
Bart Van Assche
0c1ca90007 scripts/generate-kernel-patch: Download the correct kernel version
Additionally, only try to download the Linux kernel when including the
qla2x00t driver in the output.

This is a modified version of a patch supplied by Pascal de Bruijn.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7825 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-22 05:58:42 +00:00
Bart Van Assche
e46b7a93fc scripts/generate-kernel-patch: Fix the code that only includes fcst for kernel versions >= 2.6.33
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7824 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-22 05:56:18 +00:00
Bart Van Assche
4e4e586a82 scripts/kernel-functions: Fix kernel_version_le()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7823 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-22 05:48:57 +00:00
Bart Van Assche
acf304fb88 scripts/generate-kernel-patch: Download the kernel tarball if necessary
From Pascal de Bruijn <p.debruijn@unilogic.nl>.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7821 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-21 02:54:34 +00:00
Bart Van Assche
7c0540c556 Merge r7814:7819 from the 3.3.x branch
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7820 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-19 04:25:36 +00:00
Bart Van Assche
a201fadd3e scripts/generate-release-archive: Fix shellcheck warnings and add -h to the tar command line
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7815 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-19 02:10:19 +00:00
Bart Van Assche
df02132689 iscsi-scst: Remove the no longer supported put_page_callback patches
See also trunk r7809.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7811 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-17 22:31:57 +00:00
Bart Van Assche
5a1474df43 scst, iscsi-scst: Port to Linux kernel v4.20
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7810 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-10 17:51:41 +00:00
Bart Van Assche
e79fcbd8f3 iscsi-scst: Remove zero-copy TCP/IP support
Zero-copy TCP/IP support is deprecated since a while and is no longer
supported for recent kernels. Hence remove it and also all references
to zero-copy TCP/IP support.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7809 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-10 17:50:59 +00:00
Bart Van Assche
9fff6bc1f0 iscsi-scst: Declare cmnd_alloc() static
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7808 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-10 17:48:33 +00:00
Bart Van Assche
754e5a6b2e scst_lib: Suppress two Coverity false positives about freeing stack memory
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7807 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-10 17:48:04 +00:00
Bart Van Assche
215b44e9d4 scst/src/dev_handlers/scst_vdisk.c: Avoid that Coverity complains about an out-of-bounds access
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7806 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-10 17:47:38 +00:00
Bart Van Assche
9b4a6a8823 srpt/conftest/bad_wr_mod/bad_wr_mod.c: Avoid that Coverity complains about NULL pointer dereferences
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7805 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-10 17:47:10 +00:00
Bart Van Assche
9ccc096b50 Debian: Make it possible to purge the scstadmin package
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7804 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-10 17:46:40 +00:00
Bart Van Assche
a54f922732 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7803 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-10 17:13:32 +00:00
Bart Van Assche
3a45221c34 scst/include/backport.h: Fix RHEL 6.9 build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7801 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-09 05:12:52 +00:00
Bart Van Assche
5cd9a597e9 scst: Fix build against Linux kernel v4.12
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7800 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-06 14:44:03 +00:00
Bart Van Assche
c2f8864d90 scst/include/backport.h: Fix the <linux/eventpoll.h> backport
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7799 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-06 03:11:44 +00:00
Bart Van Assche
b0e5d9834e scst: Add an IOCB_DSYNC backport for kernel versions < v4.7
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7798 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-06 02:33:16 +00:00
Bart Van Assche
97aadf7b99 scst: Make it possible for scst_user to copy sense data to user space
This patch avoids that the following call trace is reported with usercopy
hardening enabled:

Bad or missing usercopy whitelist? Kernel memory overwrite attempt detected to SLUB object 'pool_workqueue' (offset 0, size 28)!
WARNING: CPU: 3 PID: 26167 at mm/usercopy.c:81 usercopy_warn+0x7d/0xa0
Modules linked in: ch osst st scst_user(OE) scst_tape(OE) scst_local(OE) scst_changer(OE) isert_scst(OE) iscsi_scst(OE) scst(OE) dlm rdma_cm iw_cm ib_cm ib_core libcrc32c virtio_balloon joydev i2c_piix4 qxl drm_kms_helper ttm drm virtio_net ata_generic virtio_blk serio_raw net_failover failover pata_acpi
CPU: 3 PID: 26167 Comm: ctdevice Tainted: G           OE     4.18.16-300.fc29.x86_64 #1
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
Call Trace:
 __check_object_size+0x145/0x171
 dev_user_process_reply+0xaab/0xc20 [scst_user]
 dev_user_ioctl+0x4f5/0x8eb [scst_user]
 do_vfs_ioctl+0xa4/0x620
 ksys_ioctl+0x60/0x90
 __x64_sys_ioctl+0x16/0x20
 do_syscall_64+0x5b/0x160
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

This was reported by Rob Turk.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7797 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-06 02:30:55 +00:00
Bart Van Assche
ca512bf87c dpkg: Add support for debian.tar.gz archives
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7796 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 22:02:37 +00:00
Bart Van Assche
75fe332ef1 dpkg: Add support for debian.tar.gz archives
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7795 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 21:29:58 +00:00
Bart Van Assche
04bd4b3a79 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7794 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 21:21:54 +00:00
Bart Van Assche
5f77ac3dd3 scripts/generate-kernel-patch: Only add scst/README_in-tree if present
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7793 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 21:19:52 +00:00
Bart Van Assche
98729e73d0 scst/include/backport.h: Improve the EPOLL* backport
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7792 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 21:14:20 +00:00
Bart Van Assche
058fba5f2a scst_user, scst_event: Convert to __poll_t
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7791 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 20:58:42 +00:00
Bart Van Assche
ad5bfbe4e2 scst: Annotate scst_cmd user space copying correctly
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7790 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 20:21:42 +00:00
Bart Van Assche
04ad78071b scripts/update-version: Also update usr/include/version.h
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7788 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 20:08:59 +00:00
Bart Van Assche
13ca37d6a9 scst: Use 'make modules_install' instead of 'install' for installing kernel modules
This patch ensures that the proper SELinux label is applied to all SCST
kernel modules. This was reported by Rob Turk.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7779 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-04 17:52:01 +00:00
Bart Van Assche
a009f41028 scstadmin.spec: Add /usr/bin/killall to the requirements list
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7603 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-03 23:52:32 +00:00
Bart Van Assche
7e5a0ba300 scst.spec: Avoid that rpm complains about expanding a variable in a comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7602 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-03 23:50:54 +00:00
Bart Van Assche
4ceb343966 scst, scst_user: Add support for usercopy hardening
Avoid that with CONFIG_HARDENED_USERCOPY enabled warnings appear about
kernel memory exposure attempts when using scst_user.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7601 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-03 17:06:01 +00:00
Bart Van Assche
133b012f82 scst: Introduce a backport of kmem_cache_create_usercopy()
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7600 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-03 17:03:41 +00:00
Bart Van Assche
ca180efeec cst_vdisk: Avoid that vdisk_usn_vpd() can trigger a buffer overflow
Additionally, this patch avoids that the following compiler warning
is reported on Fedora 29:

In function 'strncpy',
    inlined from 'vdisk_usn_vpd.isra.24' at /home/bart/software/scst.git/scst/src/dev_handlers/scst_vdisk.c:3866:3:
./include/linux/string.h:246:9: warning: '__builtin_strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
  return __builtin_strncpy(p, q, size);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/bart/software/scst.git/scst/src/dev_handlers/scst_vdisk.c: In function 'vdisk_usn_vpd.isra.24':
./include/linux/string.h:267:10: note: length computed here
   return __builtin_strlen(p);
          ^~~~~~~~~~~~~~~~~~~


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7599 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-03 17:02:38 +00:00
Bart Van Assche
63ed4b4f9a ib_srpt: Fix build against MLNX_OFED-4.5
This patch fixes the following error during srpt compilation:
  CC [M]  /.autodirect/mtrswgwork/sergeygo/scst-trunk/srpt/src/ib_srpt.o
In file included from /usr/src/ofa_kernel/default/include/rdma/ib_verbs.h:76:0,
                 from /usr/src/ofa_kernel/default/include/rdma/ib_cache.h:38,
                 from /.autodirect/mtrswgwork/sergeygo/scst-trunk/srpt/src/ib_srpt.c:61:
/usr/src/ofa_kernel/default/include/uapi/rdma/rdma_user_ioctl.h:45:10: fatal error: rdma/rdma_user_ioctl_cmds.h: No such file or directory
 #include <rdma/rdma_user_ioctl_cmds.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The same problem has already been fixed for iscsi in [r7215] "iscsi-scst/Makefile: Add include/uapi directory to the include path".

From: Sergey Gorenko <sergeygo@mellanox.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7597 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-01 05:28:18 +00:00
Bart Van Assche
69fde133e9 Revert r7524
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7525 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-31 14:25:52 +00:00
Bart Van Assche
91b99af914 scst, srpt, iscsi-scst, qla2x00t, fcst: Bump version number to 3.4.0
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7524 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-31 14:24:20 +00:00
Bart Van Assche
90e883d76b scripts/update-version: Left-align the *_REV revision numbers in scst_vdisk.c
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7523 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-31 14:23:26 +00:00
Bart Van Assche
78a0407d0e scst, iscsi-scst: Simplify the code that uses kstrto*l()
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7522 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 22:05:33 +00:00
Bart Van Assche
0f0ab73758 ibmvstgt: Port to Linux kernel v4.18
Untested.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7521 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 22:04:12 +00:00
Bart Van Assche
c55eaa7d5e iscsi-scstd: Change the gcc-specific __FUNCTION__ into __func__
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7520 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 22:02:24 +00:00
Bart Van Assche
969a36a235 scripts/checkpatch: Suppress more warning categories
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7519 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 22:00:46 +00:00
Bart Van Assche
93d7c0da08 Expand Kconfig help texts
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7518 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 21:59:08 +00:00
Bart Van Assche
c59b0a2303 iscsi-scst: Insert spaces after comma's where required according to the coding style
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7517 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 21:58:38 +00:00
Bart Van Assche
73dca5af22 Remove trailing whitespace from documentation files
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7516 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 21:57:13 +00:00
Bart Van Assche
8631584f47 scst_local: Fix a build regression for older kernels in the scsi-mq support code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7515 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 21:53:22 +00:00
Bart Van Assche
d84fc0783d vdisk_fileio: Add support for asynchronous I/O processing
Using asynchronous has the advantage that SCSI commands can be processed
concurrently even if only one SCST command thread has been configured.
Asynchronous direct I/O has the additional advantage that the page cache
is bypassed and hence that the command processing overhead is reduced.

Asynchronous I/O is not used when DIF is enabled because it is
nontrivial to ensure that a DIF read received after a DIF write
returns the data that has just been written.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7514 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 04:10:59 +00:00
Bart Van Assche
50e31529c4 scst_vdisk: Introduce a union in struct vdisk_cmd_params
This patch does not change any functionality but makes a later patch
easier to read.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7513 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 04:07:53 +00:00
Bart Van Assche
19c9aec2f7 vdisk_fileio: Remove the page cache based zero-copy implementation
A new zero-copy implementation will be added in a later patch.
This patch reverts most of r4213.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7512 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 04:07:04 +00:00
Bart Van Assche
9e740aa986 scst_vdisk: Fix spelling in a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7511 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 04:06:21 +00:00