Commit Graph

4601 Commits

Author SHA1 Message Date
Bart Van Assche
15535bf648 iscsi-scst: Suppress a compiler warning
Avoid that the compiler complains that the variable 'pad_bytes'
is not used with CONFIG_LIBCRC32C=n.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6314 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-15 22:06:29 +00:00
Bart Van Assche
9e700c6c03 iscsi-scst/Makefile: Only build the iSER target driver if InfiniBand has been enabled in the kernel config
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6313 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-15 14:41:35 +00:00
Bart Van Assche
0d9d6a6f57 isert-scst: Fix in-tree build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6312 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-12 16:15:45 +00:00
Bart Van Assche
a2a22c0b95 isert-scst: Shorten the compiler include path
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6311 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-12 15:31:05 +00:00
Bart Van Assche
e62155683e iscsi-scst: Fix a compiler warning for kernel versions >= 3.19
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6310 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-12 15:29:56 +00:00
Bart Van Assche
3e77947ed9 nightly build: Update a kernel version
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6309 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-12 00:41:35 +00:00
Bart Van Assche
f4189cdec2 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6308 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-11 17:57:10 +00:00
Bart Van Assche
b7ec40e6a7 scst: RHEL 5 build fix for file_inode()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6238 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-11 04:19:47 +00:00
Bart Van Assche
e01d03fe2f scripts/specialize-patch: Recognize identifiers correctly
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6237 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-11 04:18:47 +00:00
Bart Van Assche
4117f30c06 scst: Allow compiling iSER/SRP against OFED/MLNX_OFED
Both OFED/MLNX_OFED compat and scst define file_inode.
This causes a compilation error. Fix this by detecting
that backports are in effect.

Signed-off-by: Yan Burman <yanb@mellanox.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6236 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-10 16:01:24 +00:00
Bart Van Assche
6aaeca1cd9 Merge iser branch r6234 into trunk
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6235 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-10 15:35:26 +00:00
Bart Van Assche
5b397efc3f srpt/README: Spelling fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6232 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-10 00:36:16 +00:00
Bart Van Assche
30c09e2987 vdisk_blockio: Make the WRITE VERIFY warning less verbose
Avoid that running the libiscsi tests causes a high number of kernel
warnings to be triggered.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6231 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 16:55:32 +00:00
Bart Van Assche
71a0b70c5d scst_targ: Fix a debug statement
See also patch "Merge t10-pi branch back" (r6192).


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6230 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 14:52:07 +00:00
Bart Van Assche
8660b7b58b scst_vdisk: Avoid that checkpatch complains about 'long long unsigned'
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6229 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 13:55:53 +00:00
Bart Van Assche
cd429f04e5 scst.h: Use tabs for indentation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6228 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 13:49:06 +00:00
Bart Van Assche
253da8189d scst.h: Spelling fix: overriden -> overridden
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6227 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 13:36:45 +00:00
Bart Van Assche
9db6a5e0de nightly build: Add kernel 4.0 build infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6226 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 13:35:04 +00:00
Bart Van Assche
f148075207 nightly build: Add kernel 4.0 build infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6225 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 13:34:22 +00:00
Bart Van Assche
77abedc121 scripts/generate-kernel-patch: Add support for kernel versions >= 4.0.1
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6224 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 13:33:11 +00:00
Bart Van Assche
e2e2395761 nightly build: Add kernel versions 3.19 and 4.0
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6223 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-09 13:32:28 +00:00
Vladislav Bolkhovitin
d1bd22afd9 scst_user: avoid global locks
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6221 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-06 04:35:06 +00:00
Vladislav Bolkhovitin
62fcbdc434 QLogic README updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6220 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-06 02:06:34 +00:00
Vladislav Bolkhovitin
eb8e0d6126 Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6219 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-06 01:49:34 +00:00
Vladislav Bolkhovitin
21cb8657a9 Logging improvement
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6218 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-06 01:22:46 +00:00
Vladislav Bolkhovitin
a34966fbda QLogic driver web page updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6217 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-06 00:49:52 +00:00
Vladislav Bolkhovitin
d5336a72b3 Logging improvements
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6216 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-05 23:53:22 +00:00
Vladislav Bolkhovitin
a4fc2e5638 scst: use t10_pi_tuple
Use t10_pi_tuple instead of scst_dif_tuple.

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6215 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-05 02:15:09 +00:00
Vladislav Bolkhovitin
2d2621536e Commands suspending clarified
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6214 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-05 01:31:18 +00:00
Bart Van Assche
7ccc3033ec scstadmin, installation: Make the activation command output easier to read
Reported-by: Chris Weiss <cweiss@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6213 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-03 20:21:34 +00:00
Vladislav Bolkhovitin
d971c47cad "How To install SCST on Ubutuntu 15.04 with in-tree kernel patches" added, thanks to Chris Weiss
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6212 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-02 02:35:45 +00:00
Vladislav Bolkhovitin
2c7dd187eb Document generate-kernel-patch and generate-patched-kernel scripts
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6211 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-02 02:27:26 +00:00
Vladislav Bolkhovitin
c236c36778 Microoptimizations
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6210 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-21 01:38:55 +00:00
Vladislav Bolkhovitin
e0887beef6 Forwarding targets attribute added
See the patch for description



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6209 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-21 01:36:34 +00:00
Vladislav Bolkhovitin
a422ba3cc9 Unaligned I/O statistics added
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6208 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-21 01:28:58 +00:00
Vladislav Bolkhovitin
dd3799d62a Disable preemption during tasklet schedule for per-CPU variable usage
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6206 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-09 03:17:16 +00:00
Vladislav Bolkhovitin
93dc546f3b Fix typo in the new QLA git qla_extraclean target
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6205 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-09 03:16:19 +00:00
Vladislav Bolkhovitin
c6c52f4a71 Fix FAILFAST for pass-through requests
It seems that REQ_QUIET and REQ_FAILFAST flags were confused. We want
both printed information in the logs about backend devices IO faulires
and fail fast pass-through requests without extra retries. Setting
rq->retries along is not sufficient, because in the kernel code retries
and the FAILFAST bitfields control behavior of different kernel pieces,
so they need to be used together. For instance, blk_noretry_request()
has no idea about rq->retries.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6204 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-07 02:21:35 +00:00
Vladislav Bolkhovitin
e719f0eca5 ib_srpt: cleanup fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6203 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 02:05:54 +00:00
Vladislav Bolkhovitin
627f79738f Fix proc build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6202 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 01:02:04 +00:00
Vladislav Bolkhovitin
9b66034f3f T10-PI documentation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6201 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 00:49:13 +00:00
Vladislav Bolkhovitin
2a5679df53 T10-PI clarifications
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6200 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 00:48:42 +00:00
Vladislav Bolkhovitin
e919c5bb20 Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6199 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 00:47:22 +00:00
Vladislav Bolkhovitin
c9de099c74 Cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6198 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-02 01:13:08 +00:00
Vladislav Bolkhovitin
1ecb7f1fe3 qla2x00t: Fix source code indentation
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6197 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-02 01:08:25 +00:00
Vladislav Bolkhovitin
80be46ae7b scst_targ: Avoid incorrect block size changes
The scst_block_generic_dev_done() function parses the READ CAPACITY
response without checking whether the response buffer has been
initialized. This can lead to incorrect block size changes and also
to the following kernel warning:

WARNING: at scst/src/scst_lib.c:7353 scst_calc_block_shift+0x7f/0xb0 [scst]()
1 << 23 != 12595456
 [<ffffffff816071e3>] dump_stack+0x19/0x1b
 [<ffffffff8106e23d>] warn_slowpath_common+0x7d/0xc0
 [<ffffffff8106e336>] warn_slowpath_fmt+0x46/0x50
 [<ffffffffa0712e2f>] scst_calc_block_shift+0x7f/0xb0 [scst]
 [<ffffffffa072dbd7>] scst_block_generic_dev_done.part.39+0x6a/0x7d [scst]
 [<ffffffffa07162a4>] scst_block_generic_dev_done+0x34/0x40 [scst]
 [<ffffffffa0066205>] dev_user_disk_done+0x15/0x20 [scst_user]
 [<ffffffffa070c119>] scst_dev_done+0x49/0x150 [scst]
 [<ffffffffa070e1a0>] scst_process_active_cmd+0x240/0x390 [scst]
 [<ffffffffa070e7e1>] scst_process_redirect_cmd+0x121/0x1e0 [scst]
 [<ffffffffa070e916>] scst_cmd_done_local+0x76/0x120 [scst]
 [<ffffffffa006843a>] dev_user_process_reply_exec+0x8a/0x370 [scst_user]
 [<ffffffffa00699e2>] dev_user_process_reply+0x242/0x2e0 [scst_user]
 [<ffffffffa0069b80>] dev_user_reply_get_cmd.isra.17+0x100/0x2d0 [scst_user]
 [<ffffffffa0069ea7>] dev_user_ioctl+0x157/0x428 [scst_user]
 [<ffffffff811d999a>] do_vfs_ioctl+0x7a/0x2e0
 [<ffffffff811d9c91>] SyS_ioctl+0x91/0xb0
 [<ffffffff8161b269>] system_call_fastpath+0x16/0x1b

Avoid this by additionally checking cmd->completed

Reported-by: Gal Rosen <galr@storone.com>
Reported-by: Abacus Liang <abacusl@hotmail.com>
Reported-by: Shahar Salzman <shahar.salzman@kaminario.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6196 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-02 01:01:15 +00:00
Vladislav Bolkhovitin
734bd675bd Cleanup
Since SAM_STAT_GOOD is 0, it does not change any functionality



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6195 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-02 00:11:22 +00:00
Vladislav Bolkhovitin
a3f8a4eff1 scst: Log a warning if the block size is modified
A block size change is an important change so log such changes.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6194 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 23:52:51 +00:00
Vladislav Bolkhovitin
b59ce01ead Decrease time cpu_cmd_counter is held taken for suspending case for debug
mode to minimize race window described in
http://sourceforge.net/p/scst/mailman/message/34074831/



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6193 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 23:49:20 +00:00
Vladislav Bolkhovitin
906f4dfefb Merge t10-pi branch back
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6192 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 04:21:56 +00:00