mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-08-20 14:16:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,668 Commits 27 Branches 11 Tags
18c63e434b4e577f8d785ef7a5effbd5a7ec6cd0
Commit Graph
632 Commits
Author SHA1 Message Date
Bart Van Assche a8da0107f8 iscsiadm: Fix a resource leak 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6380 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:28:02 +00:00
Bart Van Assche ad38432332 iscsiadm: Fix strerror() argument 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6379 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:27:41 +00:00
Bart Van Assche a14df39942 iscsiadm: Do not allocate more memory than needed 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6378 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:27:18 +00:00
Bart Van Assche ff2b660264 iscsiadm: Fix a file descriptor leak in an error path 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6377 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:26:35 +00:00
Bart Van Assche f5f85b95fb iscsi-scstd: Fix a resource leak in an error path 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6376 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:26:08 +00:00
Bart Van Assche a6121b03c8 iscsi-scstd: Fix a potential file descriptor leak 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6375 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:25:42 +00:00
Bart Van Assche 74b4104994 iscsi-scstd: Avoid that Coverity complains about a use-after-free 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6374 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:25:05 +00:00
Bart Van Assche b3f49a0a17 iscsi-scstd: Annotate fall-throughs for Coverity 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6373 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:24:25 +00:00
Bart Van Assche 102d8d54c9 iscsi-scstd: Move two local variables to suppress a Coverity complaint 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6372 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:24:03 +00:00
Bart Van Assche 41caee3148 iscsi-scstd: Fix a file descriptor leak in an error path 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6371 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:23:38 +00:00
Bart Van Assche 21b60063a9 iscsi-scstd: Fix a dereference-before-null-check 
Detected by Coverity.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6370 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:23:14 +00:00
Bart Van Assche b099782023 iscsi-scstd: Fix a memory leak in the iSNS code 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6369 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:22:46 +00:00
Bart Van Assche dfcb53a9b2 iscsi-scstd: Rearrange driver major number lookup code 
Introduce a function for looking up the driver major number.
This patch does not change any functionality but makes the source
code easier to read and also makes it easier for Coverity to
analyze this code.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6368 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:22:14 +00:00
Bart Van Assche 165b0f1d10 iscsi-scstd: Improve create_and_open_dev() robustness 
Reset 'devn' if the sscanf() return value is lower than two.
Based on a Coverity report.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6367 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:21:28 +00:00
Bart Van Assche d70b1e39c0 iscsi-scstd: Fix a dereference-before-null-check 
Detected by Coverity.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6366 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:20:21 +00:00
Bart Van Assche 40a90a705d isert-scst: Add address length check in isert_listen_ioctl() 
Detected by Coverity.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6365 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:19:27 +00:00
Bart Van Assche 26cda0eb38 iscsi-scst: Annotate fall-through cases for Coverity 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6364 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:18:23 +00:00
Bart Van Assche 63cb4a9d40 iscsi-scst: Fix indentation 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6363 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-17 00:09:23 +00:00
Bart Van Assche 612fac9874 isert: Declare a local function static 
Detected by checkpatch.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6354 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 23:55:52 +00:00
Bart Van Assche eb10fe3f7d iscsi-scst: Surround complex values with parentheses 
Detected by checkpatch.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6353 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 23:55:22 +00:00
Bart Van Assche dce5cbc1cb iscsi-scst/README: Add a reference 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6348 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 23:52:10 +00:00
Bart Van Assche f272064c12 iscsi-scst: Suppress put_page_callback patch warnings 
The put_page_callback patch only improves performance on single
socket systems but not on systems with multiple CPU sockets.
Since this message is confusing to SCST users, do not print a
warning if the put_page_callback patch has not been applied.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6340 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 23:10:28 +00:00
Bart Van Assche 6b3f45696a RHEL 7.1: Add put_page_callback patch 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6336 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 20:17:52 +00:00
Bart Van Assche 807c4eacf0 isert: Use break in default case 
Detected by checkpatch.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6328 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 18:51:47 +00:00
Bart Van Assche 7c3b2c4ca6 iscsi-scst: Fix spelling in a source code comment 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6321 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 15:53:31 +00:00
Bart Van Assche bdf2c68e8a iscsi-scst/Makefile: Only report the OFED flavor when building the iSER target driver 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6320 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 13:27:49 +00:00
Vladislav Bolkhovitin 3e9eaf6b29 iscsi-scst: small post-r6315 cleanup 
Avoid that rd_task when it is not used



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6317 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-16 01:43:26 +00:00
Bart Van Assche 7566e2ed71 Avoid that compiler warnings depend on the build mode 
It is annoying that some warnings are only reported in release mode.
Modify scst_debug.h such that the compiler does not report variables
that are only used in debug builds as unused.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6315 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-15 22:15:07 +00:00
Bart Van Assche 15535bf648 iscsi-scst: Suppress a compiler warning 
Avoid that the compiler complains that the variable 'pad_bytes'
is not used with CONFIG_LIBCRC32C=n.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6314 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-15 22:06:29 +00:00
Bart Van Assche 9e700c6c03 iscsi-scst/Makefile: Only build the iSER target driver if InfiniBand has been enabled in the kernel config 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6313 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-15 14:41:35 +00:00
Bart Van Assche 0d9d6a6f57 isert-scst: Fix in-tree build 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6312 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-12 16:15:45 +00:00
Bart Van Assche a2a22c0b95 isert-scst: Shorten the compiler include path 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6311 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-12 15:31:05 +00:00
Bart Van Assche e62155683e iscsi-scst: Fix a compiler warning for kernel versions >= 3.19 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6310 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-12 15:29:56 +00:00
Bart Van Assche 6aaeca1cd9 Merge iser branch r6234 into trunk 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6235 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-06-10 15:35:26 +00:00
Vladislav Bolkhovitin 906f4dfefb Merge t10-pi branch back 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6192 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-05-01 04:21:56 +00:00
Vladislav Bolkhovitin 1e78126962 iscsi-scst: update for 3.19 kernels 
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6187 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-04-24 02:54:52 +00:00
Vladislav Bolkhovitin 6572bedcb8 iscsid: Logically and negative conditions instead of or-ing these 
Logically and negative allowed_portal conditions instead of or-ing these.

This was proposed by Sergej Roytman <spocks.goatee@gmail.com>.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6186 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-04-24 02:04:58 +00:00
Vladislav Bolkhovitin 918ac63120 iscsi-scst: Add put_page_callback patch for kernel 3.19 
Tested against the virtio_net network driver.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6184 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-04-16 04:08:45 +00:00
Bart Van Assche c32f79f6c1 Revert T10-PI support 
The T10-PI patch (r6162) increases the time needed to run mkfs.ext4
over iSCSI from less than a second to several minutes. This is a
regression so revert the T10-PI patch until there is sufficient time
to find the root cause of this regression and to fix this regression.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6171 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-03-31 09:51:24 +00:00
Bart Van Assche 6349372255 iscsi-scst: Switch to the new and preferred approach for printing kernel messages 
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6163 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-03-29 17:28:38 +00:00
Vladislav Bolkhovitin 57ae9291b9 iscsi-scst: Concatenate two string literals 
This patch fixes the following kernel 3.19 checkpatch complaint:

Consecutive strings are generally better as a single string.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6160 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-03-27 03:52:37 +00:00
Vladislav Bolkhovitin 5cc7555cd9 iscsi-scst: Rework sparse annotations 
Do not declare kernel pointers as __user but instead cast these to
__user just before assigning these to iov_base.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6156 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-03-26 00:33:45 +00:00
Vladislav Bolkhovitin fe38e4acb2 Copyrights updated 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-03-19 00:01:03 +00:00
Bart Van Assche d9c1ffa29a iscsi-scst/usr/Makefile: Fix include path 
Use the SCST_INC_DIR variable passed by the parent Makefile such that
both the in-tree and out-of-tree builds work.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6130 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-02-24 14:10:54 +00:00
Vladislav Bolkhovitin 4ac6d7a26d [PATCH] scst: Drop detect() method 
There is no need for a detect() method - code that is present in such
a method can be moved to module_init(). Hence declare this method
obsolete. Leave the detect pointer member in the target template for
now for out-of-tree SCST drivers.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>

with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6113 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-02-21 04:32:36 +00:00
Bart Van Assche 5019ae319e scst: Introduce file_inode() 
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
[bvanassche: Constified file_inode() argument / added iscsi-scst conversion]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6084 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-02-12 07:48:10 +00:00
Bart Van Assche 628f3939bc scst: Rework SCSI pass-through support for kernel versions >= 2.6.30 
Changes in this patch:
- Rework the SCSI pass-through code such that for kernel versions
  >= 2.6.30 the scst_exec_req_fifo patch is no longer needed.
- Modify the pass-through code such that blk_rq_append_bio() is only
  called for kernel version 2.6.30. For later kernel versions
  blk_make_request() is called instead.
- Rework scst_scsi_exec_async().
- Add debug tracing of SCSI pass-through result status.
- Add a lockdep_assert_held() call in scsi_end_async().



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5979 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2015-01-20 15:04:23 +00:00
Bart Van Assche 9cd602de2f Update for kernel 3.18 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5955 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-12-22 13:10:41 +00:00
Bart Van Assche d8ec3a3873 Source code spelling fix: authentification -> authentication 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5946 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-12-22 12:31:08 +00:00
Bart Van Assche c8d86e2811 Source code spelling fix: accesss -> access 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5944 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2014-12-22 12:28:56 +00:00