Commit Graph

1408 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
21140e2a07 Fixed incorrect condition in scst_hw_pending_work_fn() noticed by Joe Eykholt <jeykholt@cisco.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1513 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-19 18:45:53 +00:00
Bart Van Assche
2d4d49f304 Fixed two WARN_ON() statements.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1512 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-19 12:03:48 +00:00
Vladislav Bolkhovitin
4d96089e50 Sysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity requirements. See README for details.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1511 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-17 19:07:54 +00:00
Bart Van Assche
9b82ea19be Works now when started with a relative path too.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1510 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-15 19:09:48 +00:00
Bart Van Assche
9c8f290140 Added to repository.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1509 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-15 17:34:22 +00:00
Bart Van Assche
c519012fb2 Factored out channel unregistration code into a new function srpt_unregister_channel().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1508 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-14 12:51:14 +00:00
Bart Van Assche
4f7e597345 Fixed a memory leak in an error path.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1507 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-14 12:11:54 +00:00
Bart Van Assche
40869e57d1 Moved srpt_unmap_sg_to_ib_sge(ch, ioctx) call back into srpt_abort_scst_cmd().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1506 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-14 12:08:47 +00:00
Bart Van Assche
add3508a0c Changes:
- Fixed race condition between SCST session registration and IB channel event
  handler in srpt_add_one(): at least in theory it was possible that 
  sdev->scst_tgt was accessed before being initialized properly.
- A kernel WARN_ON() is no longer triggered when a DREQ has been received after
  SCST session deregistration started.
- Made sure that srpt_unmap_sg_to_ib_sge() does not call ib_dma_unmap_sg()
  twice.
- Moved srpt_unmap_sg_to_ib_sge() call out of srpt_reset_ioctx() and
  srpt_abort_scst_cmd() into the callers of these functions.
- Renamed some of the SRPT command states.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1505 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-14 11:36:34 +00:00
Bart Van Assche
cedf31579e Removed handling of AESOLNT, CRSOLNT and LOSOLNT flags again.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1504 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-12 19:42:00 +00:00
Bart Van Assche
26866a1e28 Simplified implementation of the thread=1 mode.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1503 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-12 19:37:43 +00:00
Bart Van Assche
8981044fb8 Updated test instructions.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1502 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-12 19:30:08 +00:00
Bart Van Assche
7eee1392b8 Compiles again without warnings.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1501 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-12 18:59:15 +00:00
Vladislav Bolkhovitin
82e07ddb73 Commented out required by iSCSI RFC, but not needed for processing, check of LUN field in Data-Out PDU, because some initiators (Windows, at least) don't care to correctly set it.
Reported and tested by Ladislav Pašek <pasek@valbek.cz>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1500 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-12 13:12:58 +00:00
Vladislav Bolkhovitin
8a4b3a1732 Those files were deleted moving to new pass-through implementation, but should have been resurrected when that implementation was limited to 2.6.30+ kernels only. Fixing.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1499 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-12 13:07:23 +00:00
Bart Van Assche
492e570df0 Made ib_srpt easier to build on a multiboot system where multiple kernels
have been installed -- one kernel with OFED and one or more kernels without
OFED.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1498 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-11 19:28:58 +00:00
Bart Van Assche
7c04f47a6b Fixed two MODULE_PARM_DESC() clauses.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1497 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-11 19:27:49 +00:00
Vladislav Bolkhovitin
b611a22ed0 Patch from Christian Motschke <motschke@itso-berlin.de>:
I had some problems compiling scst due to some bashisms in the Makefiles. As
you will know, Debian uses /bin/dash as default shell and /bin/sh is only a
link to /bin/dash. I can either change the default shell, (or in my opinion
the better solution) use SHELL=/bin/bash in the Makefile.
I have made a patch for the Makefiles in question (I hope, that are all
Makefiles).



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1496 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-10 19:32:31 +00:00
Vladislav Bolkhovitin
d880bdab9d cmnd_reject() should return supplied reason, not hardcoded ISCSI_REASON_INVALID_PDU_FIELD
Noticed by Alexey Obitotskiy <alexeyo1@open-e.com>

This line, and those below, will be ignored--

M    trunk/iscsi-scst/usr/iscsid.c


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1495 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-10 19:22:39 +00:00
Bart Van Assche
8ed82e1dbe Updated kernel revisions.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1494 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-09 15:46:10 +00:00
Bart Van Assche
2032370cca svn merge -c1492 https://scst.svn.sourceforge.net/svnroot/scst/branches/srpt-separate-rx-tx-buffers/scripts
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1493 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-07 09:06:03 +00:00
Vladislav Bolkhovitin
f42a81e94a Web updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1490 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-02 17:16:58 +00:00
Bart Van Assche
0b3861da48 Added a blank line.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1483 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-29 19:09:06 +00:00
Bart Van Assche
773ec6e974 Updated kernel revisions.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1482 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-29 11:54:38 +00:00
Vladislav Bolkhovitin
28ed0ed7e3 session_active_commands_attr attribute must have active_commands name.
Reported by Joe Eykholt <jeykholt@cisco.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1478 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-26 13:02:13 +00:00
Bart Van Assche
f7f8c13456 Updated kernel revisions.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1477 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-26 11:52:01 +00:00
Bart Van Assche
4c3a1c3e9e Updated kernel revisions.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1476 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-23 08:54:06 +00:00
Bart Van Assche
fa91abb965 Updated kernel revisions.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1475 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-19 11:37:41 +00:00
Bart Van Assche
30fef168be Moved comma's in table header to the proper place.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1474 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-17 17:36:50 +00:00
Bart Van Assche
421dbafa7c Changes:
- The entire receive queue can be used again instead of only SRPT_RQ_SIZE - 1
  elements (as in r1470).
- Added initiator-lockup-avoidance code to SRP_TSK_MGMT processing code too.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1473 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-17 13:07:46 +00:00
Bart Van Assche
5ce3870372 Updated test instructions.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1472 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-16 19:38:08 +00:00
Bart Van Assche
e3d9724359 Updated copyright statement.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1471 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-16 19:36:29 +00:00
Bart Van Assche
c654261e03 Changes:
- Updated copyright statement.
- Micro-optimized the function srpt_req_lim_delta().
- Made sure that SRPT does not cause a lockup in (at least) the Linux SRP
  initiator. See also http://bugzilla.kernel.org/show_bug.cgi?id=14235.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1470 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-14 20:35:37 +00:00
Bart Van Assche
3d9011443c Removed a trailing space because checkpatch complained about it.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1469 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-14 13:37:56 +00:00
Bart Van Assche
6384c37e83 Enabled sparse checking for the 2.6.23.17 kernel.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1468 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-14 13:28:26 +00:00
Vladislav Bolkhovitin
5b77c89fbd Patch from Gilad H <gilad.public2@gmail.com> with improvements fixing the following scenario:
1. Commands start going to the init_cmd_list probably because SCST was suspended
2. A command is now waiting in the init_cmd_list, it was not yet completely initialized (more impotently cmd->dev == NULL)
3. A clear task set for the same lun arrives from a different initiator
4. The command is marked as aborted from other initiator and released from the init list.
5. The command gets to the PRE_XMIT_RESPONSE state, since it was aborted the scst_xmit_process_aborted_cmd is called.
6. At this stage since the command is marked as aborted by other initiator the scst checks for the device TAS flag (cmd->dev->tas) however cmd->dev is NULL and we crash on Null pointer de-referencing.




git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1466 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-14 13:14:30 +00:00
Vladislav Bolkhovitin
04cb08ec2d Improve handling of aborts of done commands
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1465 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-14 12:59:13 +00:00
Bart Van Assche
ee0767206c Removed SRP_CRED_REQ support again.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1464 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 20:19:54 +00:00
Bart Van Assche
354d74e675 Fixed the following category of checkpatch errors:
3 ERROR: code indent should use tabs where possible


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1463 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 19:33:21 +00:00
Vladislav Bolkhovitin
eada62f329 Fixed processing of REQUEST SENSE and INQUIRY commands for not existing LUNs
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1462 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 18:10:10 +00:00
Vladislav Bolkhovitin
138cd01268 Regular reservations cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1461 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 14:03:55 +00:00
Bart Van Assche
dc45f111c6 Fixed a compiler warning about a format specification mismatch.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1460 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 13:21:08 +00:00
Bart Van Assche
b9ad2bae2b Made sure that the EXTRACHECKS_BUG_ON() macro does not trigger a compiler
warning about an empty controlled statement in a release or perf build.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1459 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 13:20:00 +00:00
Bart Van Assche
e90930ed6d Made sure that none of the EXTRACHECKS_BUG_ON(), EXTRACHECKS_WARN_ON()
or EXTRACHECKS_WARN_ON_ONCE() macros trigger a compiler warning about an
empty controlled statement in a release or perf build.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1458 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 13:13:03 +00:00
Bart Van Assche
ddbaa159ca Fixed the following checkpatch complaint:
1 WARNING: braces {} are not necessary for single statement blocks


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1457 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 08:21:39 +00:00
Vladislav Bolkhovitin
21476c4b9c Docs about QLA FW version updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1456 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-12 20:10:56 +00:00
Vladislav Bolkhovitin
89345ab95c Custom commands parsing cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1455 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-12 19:05:27 +00:00
Vladislav Bolkhovitin
e5a195516c Link to PRs patch to test updated.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1454 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-12 15:05:25 +00:00
Vladislav Bolkhovitin
c32ef099ce Patch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing broken link to the Marvell logo after Marvell redesigned their site.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1453 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-12 14:53:33 +00:00
Vladislav Bolkhovitin
4a2fcb870b - Logging cleanups. Particularly, TRACE_MGMT_MINOR level was removed
- Docs updates
 - Other minor fixes and cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1452 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-12 13:29:01 +00:00