Commit Graph

4577 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
21cb8657a9 Logging improvement
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6218 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-06 01:22:46 +00:00
Vladislav Bolkhovitin
a34966fbda QLogic driver web page updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6217 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-06 00:49:52 +00:00
Vladislav Bolkhovitin
d5336a72b3 Logging improvements
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6216 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-05 23:53:22 +00:00
Vladislav Bolkhovitin
a4fc2e5638 scst: use t10_pi_tuple
Use t10_pi_tuple instead of scst_dif_tuple.

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6215 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-05 02:15:09 +00:00
Vladislav Bolkhovitin
2d2621536e Commands suspending clarified
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6214 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-05 01:31:18 +00:00
Bart Van Assche
7ccc3033ec scstadmin, installation: Make the activation command output easier to read
Reported-by: Chris Weiss <cweiss@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6213 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-03 20:21:34 +00:00
Vladislav Bolkhovitin
d971c47cad "How To install SCST on Ubutuntu 15.04 with in-tree kernel patches" added, thanks to Chris Weiss
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6212 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-02 02:35:45 +00:00
Vladislav Bolkhovitin
2c7dd187eb Document generate-kernel-patch and generate-patched-kernel scripts
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6211 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-02 02:27:26 +00:00
Vladislav Bolkhovitin
c236c36778 Microoptimizations
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6210 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-21 01:38:55 +00:00
Vladislav Bolkhovitin
e0887beef6 Forwarding targets attribute added
See the patch for description



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6209 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-21 01:36:34 +00:00
Vladislav Bolkhovitin
a422ba3cc9 Unaligned I/O statistics added
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6208 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-21 01:28:58 +00:00
Vladislav Bolkhovitin
dd3799d62a Disable preemption during tasklet schedule for per-CPU variable usage
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6206 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-09 03:17:16 +00:00
Vladislav Bolkhovitin
93dc546f3b Fix typo in the new QLA git qla_extraclean target
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6205 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-09 03:16:19 +00:00
Vladislav Bolkhovitin
c6c52f4a71 Fix FAILFAST for pass-through requests
It seems that REQ_QUIET and REQ_FAILFAST flags were confused. We want
both printed information in the logs about backend devices IO faulires
and fail fast pass-through requests without extra retries. Setting
rq->retries along is not sufficient, because in the kernel code retries
and the FAILFAST bitfields control behavior of different kernel pieces,
so they need to be used together. For instance, blk_noretry_request()
has no idea about rq->retries.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6204 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-07 02:21:35 +00:00
Vladislav Bolkhovitin
e719f0eca5 ib_srpt: cleanup fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6203 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 02:05:54 +00:00
Vladislav Bolkhovitin
627f79738f Fix proc build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6202 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 01:02:04 +00:00
Vladislav Bolkhovitin
9b66034f3f T10-PI documentation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6201 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 00:49:13 +00:00
Vladislav Bolkhovitin
2a5679df53 T10-PI clarifications
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6200 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 00:48:42 +00:00
Vladislav Bolkhovitin
e919c5bb20 Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6199 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 00:47:22 +00:00
Vladislav Bolkhovitin
c9de099c74 Cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6198 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-02 01:13:08 +00:00
Vladislav Bolkhovitin
1ecb7f1fe3 qla2x00t: Fix source code indentation
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6197 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-02 01:08:25 +00:00
Vladislav Bolkhovitin
80be46ae7b scst_targ: Avoid incorrect block size changes
The scst_block_generic_dev_done() function parses the READ CAPACITY
response without checking whether the response buffer has been
initialized. This can lead to incorrect block size changes and also
to the following kernel warning:

WARNING: at scst/src/scst_lib.c:7353 scst_calc_block_shift+0x7f/0xb0 [scst]()
1 << 23 != 12595456
 [<ffffffff816071e3>] dump_stack+0x19/0x1b
 [<ffffffff8106e23d>] warn_slowpath_common+0x7d/0xc0
 [<ffffffff8106e336>] warn_slowpath_fmt+0x46/0x50
 [<ffffffffa0712e2f>] scst_calc_block_shift+0x7f/0xb0 [scst]
 [<ffffffffa072dbd7>] scst_block_generic_dev_done.part.39+0x6a/0x7d [scst]
 [<ffffffffa07162a4>] scst_block_generic_dev_done+0x34/0x40 [scst]
 [<ffffffffa0066205>] dev_user_disk_done+0x15/0x20 [scst_user]
 [<ffffffffa070c119>] scst_dev_done+0x49/0x150 [scst]
 [<ffffffffa070e1a0>] scst_process_active_cmd+0x240/0x390 [scst]
 [<ffffffffa070e7e1>] scst_process_redirect_cmd+0x121/0x1e0 [scst]
 [<ffffffffa070e916>] scst_cmd_done_local+0x76/0x120 [scst]
 [<ffffffffa006843a>] dev_user_process_reply_exec+0x8a/0x370 [scst_user]
 [<ffffffffa00699e2>] dev_user_process_reply+0x242/0x2e0 [scst_user]
 [<ffffffffa0069b80>] dev_user_reply_get_cmd.isra.17+0x100/0x2d0 [scst_user]
 [<ffffffffa0069ea7>] dev_user_ioctl+0x157/0x428 [scst_user]
 [<ffffffff811d999a>] do_vfs_ioctl+0x7a/0x2e0
 [<ffffffff811d9c91>] SyS_ioctl+0x91/0xb0
 [<ffffffff8161b269>] system_call_fastpath+0x16/0x1b

Avoid this by additionally checking cmd->completed

Reported-by: Gal Rosen <galr@storone.com>
Reported-by: Abacus Liang <abacusl@hotmail.com>
Reported-by: Shahar Salzman <shahar.salzman@kaminario.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6196 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-02 01:01:15 +00:00
Vladislav Bolkhovitin
734bd675bd Cleanup
Since SAM_STAT_GOOD is 0, it does not change any functionality



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6195 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-02 00:11:22 +00:00
Vladislav Bolkhovitin
a3f8a4eff1 scst: Log a warning if the block size is modified
A block size change is an important change so log such changes.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6194 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 23:52:51 +00:00
Vladislav Bolkhovitin
b59ce01ead Decrease time cpu_cmd_counter is held taken for suspending case for debug
mode to minimize race window described in
http://sourceforge.net/p/scst/mailman/message/34074831/



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6193 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 23:49:20 +00:00
Vladislav Bolkhovitin
906f4dfefb Merge t10-pi branch back
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6192 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 04:21:56 +00:00
Vladislav Bolkhovitin
0b4fe40d3e scst_lib: Improve WRITE SAME performance
Some storage devices have a block size of 512 bytes and a minimum
I/O size and/or optimal I/O size of 4096 bytes. Improve WRITE SAME
performance for such devices by increasing the I/O granularity from
512 bytes to 4096 bytes.

Based on a patch written by Vishal Tripathi <vishal.tripathi@calsoftinc.com>
and Sushil Sharma <sushil.sharma@calsoftinc.com>.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>

+ with some minor changes



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6189 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 02:04:39 +00:00
Vladislav Bolkhovitin
1e78126962 iscsi-scst: update for 3.19 kernels
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6187 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-24 02:54:52 +00:00
Vladislav Bolkhovitin
6572bedcb8 iscsid: Logically and negative conditions instead of or-ing these
Logically and negative allowed_portal conditions instead of or-ing these.

This was proposed by Sergej Roytman <spocks.goatee@gmail.com>.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6186 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-24 02:04:58 +00:00
Vladislav Bolkhovitin
b8fe3c6962 Emulex target driver web update from Emulex
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6185 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-24 00:20:59 +00:00
Vladislav Bolkhovitin
918ac63120 iscsi-scst: Add put_page_callback patch for kernel 3.19
Tested against the virtio_net network driver.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6184 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-16 04:08:45 +00:00
Vladislav Bolkhovitin
d7de93ba19 qla2x00t: Kernel 3.19 build fix
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6183 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-16 04:06:37 +00:00
Bart Van Assche
33a4bccc38 ib_srpt: Avoid that aborting a command triggers a race condition
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6181 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-10 05:39:44 +00:00
Vladislav Bolkhovitin
268c7ce246 Docs update
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6180 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-10 00:33:05 +00:00
Bart Van Assche
98fb52432c ib_srpt: Specify a valid completion vector during completion queue creation
Avoid that SRP login can fail as follows:

kernel: ib_srpt: failed to create CQ: cqe 320; c.v. 17; ret -22


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6179 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-09 15:06:36 +00:00
Bart Van Assche
8cb332836f scripts/specialize-patch: Fix a bug in evaluate()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6176 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-01 07:17:17 +00:00
Bart Van Assche
b0167433fb qla2x00t: Fix spelling in a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6175 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-01 06:39:16 +00:00
Bart Van Assche
356c46e018 qla2x00t: Avoid that checkpatch complains about indentation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6174 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-01 06:37:50 +00:00
Bart Van Assche
c32f79f6c1 Revert T10-PI support
The T10-PI patch (r6162) increases the time needed to run mkfs.ext4
over iSCSI from less than a second to several minutes. This is a
regression so revert the T10-PI patch until there is sufficient time
to find the root cause of this regression and to fix this regression.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6171 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-31 09:51:24 +00:00
Bart Van Assche
01524f59ce qla2x00t: Fix a checkpatch complaint about whitespace
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6170 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-31 07:58:48 +00:00
Bart Van Assche
2dc5f994cf scst.h: Address recently introduced checkpatch complaints about whitespace
Address the following checkpatch complaints:

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
ERROR:SPACING: space required before the open parenthesis '('


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6169 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-30 14:56:42 +00:00
Bart Van Assche
4751a5bf5d scst_vdisk: Fix indentation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6168 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-30 14:46:00 +00:00
Bart Van Assche
40c138ac23 scst: Kernel 3.19 build fix
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6167 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-30 09:34:16 +00:00
Bart Van Assche
d6db54ebdc ib_srpt: Enable building against OFED headers without patching the build system (follow-up for r6138)
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6166 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-29 19:19:36 +00:00
Bart Van Assche
b79e0f7272 scst_main: Insert a blank line after a mutex_unlock() statement
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6165 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-29 17:34:10 +00:00
Bart Van Assche
a3f4f28711 Build fixes - follow-up for r6162
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-29 17:32:59 +00:00
Bart Van Assche
6349372255 iscsi-scst: Switch to the new and preferred approach for printing kernel messages
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6163 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-29 17:28:38 +00:00
Vladislav Bolkhovitin
a3ad8d1832 T10-PI support
Thanks to SanDisk and Emulex for supporting this work!

Tested with Emulex SDK Release 5.2.1



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6162 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-28 05:22:47 +00:00
Bart Van Assche
dbdec5079d nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6161 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-28 02:45:23 +00:00
Vladislav Bolkhovitin
57ae9291b9 iscsi-scst: Concatenate two string literals
This patch fixes the following kernel 3.19 checkpatch complaint:

Consecutive strings are generally better as a single string.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6160 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-27 03:52:37 +00:00