Commit Graph

583 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
26cde4de56 Make soft IRQ context default
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@594 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-12-03 18:01:42 +00:00
Vladislav Bolkhovitin
e7e7c386f9 Cleanups after "make namespacecheck"
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@593 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-12-03 11:59:41 +00:00
Vladislav Bolkhovitin
0961dd7433 - Patch from Richard Sharpe <realrichardsharpe@gmail.com> to fix an unterminated macro call and add a semicolon to please
the compiler in an ifdef block.

 - Memory leak fixed on error path in scst_local

 - Docs cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@592 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-12-01 18:36:54 +00:00
Richard Sharpe
bd3cef926e Some minor fixups to the doc to make it more correct.
My previous commit was tested against 2.6.24 and 2.6.26.5 prior to the commit.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@591 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-12-01 00:55:56 +00:00
Richard Sharpe
4c90106577 Fix a problem on kernels older than 2.6.25 where the symbol SCSI_MAX_SG_SEGMENTS
is not available. Define it if it is not already defined.

Also fix a few minor English issues.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@590 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-12-01 00:42:02 +00:00
Vladislav Bolkhovitin
7f87aa16a3 Small docs update
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@589 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-29 17:00:15 +00:00
Vladislav Bolkhovitin
2ceda4a4c2 alloc_io_context renamed to export_alloc_io_context
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@588 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-28 17:19:29 +00:00
Vladislav Bolkhovitin
1cabaea296 - Performance increase
- Cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@587 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-28 17:15:17 +00:00
Vladislav Bolkhovitin
9013ab1315 Signed/unsigned cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@586 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-28 16:11:51 +00:00
Vladislav Bolkhovitin
c9bdcb7c70 Fixing compilation warning when compiling the code with -Wcast-qual.
The casting from (const uint8_t *) to (uint8_t *) is not really necessary.

Signed-off-by: Dotan Barak <dotanba@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@585 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-26 19:03:41 +00:00
Vladislav Bolkhovitin
9183709081 There are two remaining printk() statements on which checkpatch warns that the
KERN_ facility level is missing. Algthough these warnings are false positives,
I have developed a patch to suppress these warnings.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@584 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-26 19:00:23 +00:00
Vladislav Bolkhovitin
61c0d1167f - Now task_mgmt_fn() callback called for TARGET RESET and NEXUS LOSS only once for tgt_dev, which belongs to the session, from which the corresponding request came
- Cleanup



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@583 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-25 16:44:24 +00:00
Vladislav Bolkhovitin
fb2fdb2ed6 Checkpatch warnings fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@582 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-21 12:12:53 +00:00
Vladislav Bolkhovitin
2bce93c688 Forgotten in r578 initiator version increase
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@581 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-21 10:18:28 +00:00
Vladislav Bolkhovitin
8563f4f876 DRIVER_ATTR add_host made static
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@580 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-21 10:16:34 +00:00
Vladislav Bolkhovitin
ea7e57886e The patch below fixes the sparse warnings on passing a __user pointer where a
kernel pointer is expected and vice versa. Additionally, there are a few fixes
for checkpatch warnings on trailing whitespace and lines that were over 80
columns.

This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k 2.6.27.6.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@579 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-21 10:15:03 +00:00
Vladislav Bolkhovitin
e54c3872bc Update to initiator driver from 2.6.27
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@578 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-20 18:58:53 +00:00
Vladislav Bolkhovitin
d908081912 - SGV cache related parameters moved from scst.h to scst_sgv.h
- Minor updates



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@577 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-20 17:05:08 +00:00
Vladislav Bolkhovitin
371e083d06 Prevent memory leaks in error paths by deferring
allocation until we have checked for errors. Also, fix the host ID
(target #) to be one larger than the max target ID for the host. Also,
reduce the number of outstanding commands per LUN to 1 (although this
might not be needed). Also scst_lcl_ini_driver_template flags cleanup.

Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Signed-off-by: Vladislav Bolkhovitin <vst@vlnb.net>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@576 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-19 11:37:45 +00:00
Vladislav Bolkhovitin
7edb4c0c72 Fix for memory overwrite-after-free bug in scst_local
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@575 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-19 10:55:58 +00:00
Vladislav Bolkhovitin
31c2ada297 The patch below implements the following modifications for
scripts/run-regression-tests:
- Adds a description about what the script does.
- Added command-line option -c which allows to specify which directory to use
  as cache for kernel tar balls and patch files.
- More error checking.
- scst_local is now included in all the tests.
- Swapped the order of two test steps, namely compiling the whole tree and
  running sparse. This way the output of the sparse tool is available a lot
  sooner.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@574 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-18 18:47:09 +00:00
Vladislav Bolkhovitin
bad0bad3da The patch below fixes two categories of checkpatch
complaints on scst_local, namely "line over 80 columns" and "use tabs to indent
instead of spaces".

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@573 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-18 18:45:13 +00:00
Vladislav Bolkhovitin
ec7d33e537 Log level for "Warning: expected transfer length X for opcode Y" changed to be disabled by default for release build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@572 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-18 18:42:09 +00:00
Vladislav Bolkhovitin
e882fcec37 The patch below fixes sparse warnings about int / unsigned int mismatches in
the iscsi-scst source code.

This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k 2.6.27.6.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@571 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-18 18:23:08 +00:00
Vladislav Bolkhovitin
caa419d49d Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@570 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-13 16:14:06 +00:00
Vladislav Bolkhovitin
b0c6d9a561 The patch below fixes many checkpatch warnings triggered by the iSCSI kernel
code, mainly about lines that exceeded 80 columns. As you can see in the patch
below most lines that were too long have been split, but some code has also
been moved into helper functions in order to keep the code readable. No
functionality has been changed.

This patch has been verified as follows:
- Reread the patch carefully.
- Verified that the iSCSI target kernel module still loads.
- Verified the output generated by scripts/run-regression-tests -k 2.6.27.5.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>

with some modifications



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@569 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-12 18:49:18 +00:00
Vladislav Bolkhovitin
190e00f6d2 Here is the patch to fix problems with scst_local and 2.6.24 or earlier (tested by building under 2.6.24).
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>

This line, and those below, will be ignored--

M    trunk/scst_local/scst_local.c



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@568 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-11 12:04:52 +00:00
Vladislav Bolkhovitin
47422bf856 Added possibility to coexist if both target driver and dev handler need custom memory allocation. Direct consequences:
1. scst_local can work with scst_user's devices

2. scst_user now compatible with iscsi-scst if put_page_callback not applied

+ some cosmetics



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@567 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-11 11:56:18 +00:00
Vladislav Bolkhovitin
e967b30f95 Small cleanup of unused code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@566 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-10 17:23:23 +00:00
Vladislav Bolkhovitin
95c93b2626 Depecated scst_cmd_get_tgt_resp_flags() removed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@565 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-10 17:21:09 +00:00
Vladislav Bolkhovitin
2177758f82 Fixes warning:
trunk/scst_local/scst_local.c:907: warning: initialization from incompatible pointer type



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@564 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-10 17:11:48 +00:00
Vladislav Bolkhovitin
6822e4f6cf Added proposed patch to solve SG IO count limitation issue in pass-through mode. It allows SGV cache do allocation
of pages with order > 0, i.e. more than 1 page per SG entry. Web and doc updated correspondingly.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@563 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-07 18:47:17 +00:00
Vladislav Bolkhovitin
3842a0af02 Make SWP and TAS parameters changable in vdisk handler.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@562 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-06 12:06:58 +00:00
Vladislav Bolkhovitin
55153a772c Attached is a patch that I think makes scst_local properly handle multiple targets per host.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@561 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-05 18:56:31 +00:00
Vladislav Bolkhovitin
27dc521710 Cleanup: one more __GFP_NOFAIL removed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@560 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-11-01 11:45:26 +00:00
Vladislav Bolkhovitin
b748ebde74 Small optimization
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@559 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-31 18:56:01 +00:00
Vladislav Bolkhovitin
06905f3e57 Follow-up improvements to r556
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@558 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-31 16:17:08 +00:00
Vladislav Bolkhovitin
3379376993 - Fixed incorrect SCST state used on error path
- Small cleanups
 - ToDo entry added


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@557 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-31 11:16:47 +00:00
Vladislav Bolkhovitin
90c831b838 Cleanup removing usage of in_atomic(). Particularly, now target drivers and dev handlers need to explicitly supply preferred execution context in scst_cmd_done() and scst_tgt_cmd_done().
WARNING! This commit changes external SCST interface, so it can break compilation of your out of SCST SVN tree target driver or dev handler. To fix it, simply supply the preferred exection context to scst_cmd_done() and/or scst_tgt_cmd_done().

Thanks to Bart Van Assche <bart.vanassche@gmail.com> for pointing on it.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@556 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-31 10:49:25 +00:00
Vladislav Bolkhovitin
c89dae4cb4 The patch below fixes the following:
* Lots of checkpatch warnings about lines over 80 characters.
* Checkpatch errors about code indent should use tabs where possible (same issues as reported by Dotan Barak).
* One checkpatch warning about braces {} are not necessary for single statement blocks.
* Sparse warnings about missing declarations.
* Sparse warnings about using 0 instead of NULL.

This patch has been verified by reviewing it carefully and by verifying the
output files of the command scripts/run-regression-tests -k 2.6.27.3.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>

With changes



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@555 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 20:17:42 +00:00
Vladislav Bolkhovitin
0b3215695d The patch below fixes the checkpatch warnings for source files in the
directory scst/include about lines that exceed 80 columns.

This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@554 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 19:11:04 +00:00
Vladislav Bolkhovitin
3d4486cfb9 The patch below fixes a few more warnings about lines that exceed 80 columns.
This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@553 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 18:59:23 +00:00
Vladislav Bolkhovitin
75d2a4b1a2 The patch below adds the first version of a script that runs regression tests
to the SCST source tree. All tests are run in an automated fashion, but result
interpretation is not yet completely automated.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@552 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 12:43:20 +00:00
Vladislav Bolkhovitin
0b2be958e9 The patch below makes the srpt driver compile against the 2.6.27 kernel
headers.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Acked-by: Vu Pham <vu@mellanox.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@551 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 12:34:48 +00:00
Vladislav Bolkhovitin
b35c83dbe2 Fixes wrong sess_count decrement on session registration failure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@549 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-30 12:22:48 +00:00
Vladislav Bolkhovitin
fe84b1f26b The iscsi-scst kernel module does not get compiled even with CONFIG_SCST_ISCSI
set to m or y. The patch below fixes this.

This patch has been verified by rerunning scripts/run-regression-tests -k 2.6.27.3
and by verifying that the kernel build produced a iscsi-scst.ko kernel module.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@548 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:43:38 +00:00
Vladislav Bolkhovitin
d5dc2fed6a By testing kernel patch generation for the mpt driver I found out that the
Kconfig and Makefile were read from the wrong directory. The patch below fixes
this.

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@547 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:41:29 +00:00
Vladislav Bolkhovitin
7782dc0768 Release/debug/perf patches updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@546 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:38:49 +00:00
Vladislav Bolkhovitin
0411713796 Small improvement
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@545 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:30:47 +00:00
Vladislav Bolkhovitin
3fc14278b5 Fixed accidentally enabled superfluous warnings.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@544 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-10-28 20:19:07 +00:00