mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-21 12:41:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,121 Commits 26 Branches 11 Tags
2c7890d765191aa2cb372c42e63fe7eda66b20c2
Commit Graph

9121 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Gleb Chesnokov
2c7890d765 scst_vdisk: Fix multiple checkpatch warnings 
This patch does not change any functionality.
 2024-12-28 14:59:04 +03:00
Gleb Chesnokov
ce31d4b126 dev_handlers: Fix multiple checkpatch warnings 
This patch does not change any functionality.
 2024-12-28 14:59:04 +03:00
Gleb Chesnokov
9082b4e82a nightly build: Update kernel versions 
Another kernel versions update
 2024-12-28 14:59:04 +03:00
m.chernobrov
297034d884 scstadmin: Fix scstadmin -list_sessions error msg in out cmd 
In out of "scstadmin -list_sessions" cmd occurs error
"Use of uninitialized value in numeric lt (<) at
/usr/local/sbin/scstadmin line 3679".
 2024-11-27 11:33:20 +03:00
Gleb Chesnokov
f265dc450f scst_lib: Move synchronize_rcu() calls out of loops to reduce overhead 
This patch refactors the code by accumulating the target devices into a
temporary list and moving the synchronize_rcu() call outside of the
loops. By doing so, we reduce the number of synchronize_rcu() calls to
one, improving the efficiency of the cleanup process.

Fixes: https://github.com/SCST-project/scst/issues/229
 2024-11-18 19:32:27 +03:00
Gleb Chesnokov
cc713322e7 nightly build: Update kernel versions 
Another kernel versions update.
 2024-11-18 17:13:45 +03:00
Gleb Chesnokov
60dc638b1b iscsi-scst: Fix multiple checkpatch warnings 
This patch does not change any functionality.
 2024-11-16 14:33:58 +03:00
Gleb Chesnokov
3a54209167 iscsi-scst: Fix multiple checkpatch warnings 
This patch does not change any functionality.
 2024-11-16 14:33:58 +03:00
Gleb Chesnokov
ae5ea42594 iscsi-scst: Fix multiple checkpatch warnings 
This patch does not change any functionality.
 2024-11-16 14:33:58 +03:00
Gleb Chesnokov
8aa93714e6 iscsi-scst: Fix multiple checkpatch warnings 
This patch does not change any functionality.
 2024-11-16 14:33:58 +03:00
Gleb Chesnokov
1414c9dda3 iscsi-scst: Fix multiple checkpatch warnings 
This patch does not change any functionality.
 2024-11-16 14:33:58 +03:00
Gleb Chesnokov
ec80741a24 iscsi-scst: Fix multiple checkpatch warnings 
This patch does not change any functionality.
 2024-11-16 14:33:58 +03:00
Dhananjay Kamble
70cf2f6271 scst: Unbreak the RHEL 9.5 build 2024-11-07 19:32:26 +03:00
Gleb Chesnokov
2fea7e484f qla2x00t-32gbit: Remove the unused 'del_list_entry' field in struct fc_port 
The 'del_list_entry' field in "struct fc_port" is unused.

The field was introduced in commit 2d70c103fd2a ("[SCSI] qla2xxx: Add LLD
target-mode infrastructure for >= 24xx series") in 2012-05 and the last
user was removed in commit 726b85487067 ("qla2xxx: Add framework for async
fabric discovery") in 2017-02.

Remove this unused field.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/69155321ab26c1f4d473d5bb6cd44b59b9b6a020.1724094686.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit e59f43fb6477 upstream ]
 2024-11-07 14:02:05 +03:00
Gleb Chesnokov
61f365f96e scst: Expand all create*_workqueue() invocations 
The workqueue maintainer wants to remove the create*_workqueue() macros
because these macros always set the WQ_MEM_RECLAIM flag and because these
only support literal workqueue names. Hence this patch that replaces the
create*_workqueue() invocations with the definition of this macro. The
WQ_MEM_RECLAIM flag has been retained because I think that flag is necessary
for workqueues created by storage drivers.
 2024-11-07 14:02:05 +03:00
Gleb Chesnokov
31eca7eced .github/workflows: Use checkpatch scripts 
Inroduce several checkpatch scripts to use in workflows.
 2024-11-07 13:21:25 +03:00
Gleb Chesnokov
fca4d58822 .github/workflows: Run regression tests upon a pull request 
Also allow regression tests to run upon a pull request.
 2024-11-07 13:21:25 +03:00
Gleb Chesnokov
256d695afa scst: Port to Linux kernel v6.12 
Support for the following changes in the Linux kernel v6.12:

- 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
- cb787f4ac0c2 ("[tree-wide] finally take no_llseek out")
 2024-11-07 13:21:25 +03:00
Gleb Chesnokov
1925094cb0 .github/workflows, scripts: Improve checkpatch compliance 
Use checkpatch --strict to detect more style issues.
 2024-10-01 16:17:11 +03:00
Gleb Chesnokov
878bbad8ce nightly build: Update kernel versions 
Another kernel versions update
 2024-09-16 13:44:01 +03:00
Gleb Chesnokov
376838e898 scripts/run-regression-tests: Improve support for RHEL kernels 
Additionally, update kernel versions.
 2024-09-04 20:12:26 +03:00
Gleb Chesnokov
ca51801d25 qla2x00t-32gbit: Convert comma to semicolon 
Replace a comma between expression statements by a semicolon.

Fixes: d4523bd6fd5d ("scsi: qla2xxx: Refactor asynchronous command initialization")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://lore.kernel.org/r/20240711005724.2358446-1-nichen@iscas.ac.cn
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 6ca9fede7c73 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
096a7271ca qla2x00t-32gbit: Update version to 10.02.09.300-k 
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-12-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit a1392b19ca59 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
4726c8a0d1 qla2x00t-32gbit: Use QP lock to search for bsg 
On bsg timeout, hardware_lock is used as part of search for the srb.
Instead, qpair lock should be used to iterate through different qpair.

Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-11-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit c449b4198701 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
d66e9dea01 qla2x00t-32gbit: Reduce fabric scan duplicate code 
For fabric scan, current code uses switch scan opcode and flags as the
method to iterate through different commands to carry out the process.
This makes it hard to read. This patch convert those opcode and flags into
steps. In addition, this help reduce some duplicate code.

Consolidate routines that handle GPNFT & GNNFT.

Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-10-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit beafd6924614 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
7920ac0e45 qla2x00t-32gbit: Fix optrom version displayed in FDMI 
Bios version was popluated for FDMI response. Systems with EFI would show
optrom version as 0.  EFI version is populated here and BIOS version is
already displayed under FDMI_HBA_BOOT_BIOS_NAME.

Cc: stable@vger.kernel.org
Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-9-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 348744f27a35 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
e5da16ad31 qla2x00t-32gbit: During vport delete send async logout explicitly 
During vport delete, it is observed that during unload we hit a crash
because of stale entries in outstanding command array.  For all these stale
I/O entries, eh_abort was issued and aborted (fast_fail_io = 2009h) but
I/Os could not complete while vport delete is in process of deleting.

  BUG: kernel NULL pointer dereference, address: 000000000000001c
  #PF: supervisor read access in kernel mode
  #PF: error_code(0x0000) - not-present page
  PGD 0 P4D 0
  Oops: 0000 [#1] PREEMPT SMP NOPTI
  Workqueue: qla2xxx_wq qla_do_work [qla2xxx]
  RIP: 0010:dma_direct_unmap_sg+0x51/0x1e0
  RSP: 0018:ffffa1e1e150fc68 EFLAGS: 00010046
  RAX: 0000000000000000 RBX: 0000000000000021 RCX: 0000000000000001
  RDX: 0000000000000021 RSI: 0000000000000000 RDI: ffff8ce208a7a0d0
  RBP: ffff8ce208a7a0d0 R08: 0000000000000000 R09: ffff8ce378aac9c8
  R10: ffff8ce378aac8a0 R11: ffffa1e1e150f9d8 R12: 0000000000000000
  R13: 0000000000000000 R14: ffff8ce378aac9c8 R15: 0000000000000000
  FS:  0000000000000000(0000) GS:ffff8d217f000000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 000000000000001c CR3: 0000002089acc000 CR4: 0000000000350ee0
  Call Trace:
  <TASK>
  qla2xxx_qpair_sp_free_dma+0x417/0x4e0
  ? qla2xxx_qpair_sp_compl+0x10d/0x1a0
  ? qla2x00_status_entry+0x768/0x2830
  ? newidle_balance+0x2f0/0x430
  ? dequeue_entity+0x100/0x3c0
  ? qla24xx_process_response_queue+0x6a1/0x19e0
  ? __schedule+0x2d5/0x1140
  ? qla_do_work+0x47/0x60
  ? process_one_work+0x267/0x440
  ? process_one_work+0x440/0x440
  ? worker_thread+0x2d/0x3d0
  ? process_one_work+0x440/0x440
  ? kthread+0x156/0x180
  ? set_kthread_struct+0x50/0x50
  ? ret_from_fork+0x22/0x30
  </TASK>

Send out async logout explicitly for all the ports during vport delete.

Cc: stable@vger.kernel.org
Signed-off-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-8-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 76f480d7c717 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
500979d486 qla2x00t-32gbit: Complete command early within lock 
A crash was observed while performing NPIV and FW reset,

 BUG: kernel NULL pointer dereference, address: 000000000000001c
 #PF: supervisor read access in kernel mode
 #PF: error_code(0x0000) - not-present page
 PGD 0 P4D 0
 Oops: 0000 1 PREEMPT_RT SMP NOPTI
 RIP: 0010:dma_direct_unmap_sg+0x51/0x1e0
 RSP: 0018:ffffc90026f47b88 EFLAGS: 00010246
 RAX: 0000000000000000 RBX: 0000000000000021 RCX: 0000000000000002
 RDX: 0000000000000021 RSI: 0000000000000000 RDI: ffff8881041130d0
 RBP: ffff8881041130d0 R08: 0000000000000000 R09: 0000000000000034
 R10: ffffc90026f47c48 R11: 0000000000000031 R12: 0000000000000000
 R13: 0000000000000000 R14: ffff8881565e4a20 R15: 0000000000000000
 FS: 00007f4c69ed3d00(0000) GS:ffff889faac80000(0000) knlGS:0000000000000000
 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 000000000000001c CR3: 0000000288a50002 CR4: 00000000007706e0
 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
 PKRU: 55555554
 Call Trace:
 <TASK>
 ? __die_body+0x1a/0x60
 ? page_fault_oops+0x16f/0x4a0
 ? do_user_addr_fault+0x174/0x7f0
 ? exc_page_fault+0x69/0x1a0
 ? asm_exc_page_fault+0x22/0x30
 ? dma_direct_unmap_sg+0x51/0x1e0
 ? preempt_count_sub+0x96/0xe0
 qla2xxx_qpair_sp_free_dma+0x29f/0x3b0 [qla2xxx]
 qla2xxx_qpair_sp_compl+0x60/0x80 [qla2xxx]
 __qla2x00_abort_all_cmds+0xa2/0x450 [qla2xxx]

The command completion was done early while aborting the commands in driver
unload path but outside lock to avoid the WARN_ON condition of performing
dma_free_attr within the lock. However this caused race condition while
command completion via multiple paths causing system crash.

Hence complete the command early in unload path but within the lock to
avoid race condition.

Fixes: 0367076b0817 ("scsi: qla2xxx: Perform lockless command completion in abort path")
Cc: stable@vger.kernel.org
Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-7-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 4475afa2646d upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
30cb67f0c1 qla2x00t-32gbit: Fix flash read failure 
Link up failure is observed as a result of flash read failure.  Current
code does not check flash read return code where it relies on FW checksum
to detect the problem.

Add check of flash read failure to detect the problem sooner.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/202406210815.rPDRDMBi-lkp@intel.com/
Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-6-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 29e222085d89 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
8ec5a49d4b qla2x00t-32gbit: Return ENOBUFS if sg_cnt is more than one for ELS cmds 
Firmware only supports single DSDs in ELS Pass-through IOCB (0x53h), sg cnt
is decided by the SCSI ML. User is not aware of the cause of an acutal
error.

Return the appropriate return code that will be decoded by API and
application and proper error message will be displayed to user.

Fixes: 6e98016ca077 ("[SCSI] qla2xxx: Re-organized BSG interface specific code.")
Cc: stable@vger.kernel.org
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-5-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit ce2065c4cc4f upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
4580c85a6e qla2x00t-32gbit: Fix for possible memory corruption 
Init Control Block is dereferenced incorrectly.  Correctly dereference ICB

Cc: stable@vger.kernel.org
Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-4-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit c03d740152f7 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
d002f0afd5 qla2x00t-32gbit: validate nvme_local_port correctly 
The driver load failed with error message,

qla2xxx [0000:04:00.0]-ffff:0: register_localport failed: ret=ffffffef

and with a kernel crash,

	BUG: unable to handle kernel NULL pointer dereference at 0000000000000070
	Workqueue: events_unbound qla_register_fcport_fn [qla2xxx]
	RIP: 0010:nvme_fc_register_remoteport+0x16/0x430 [nvme_fc]
	RSP: 0018:ffffaaa040eb3d98 EFLAGS: 00010282
	RAX: 0000000000000000 RBX: ffff9dfb46b78c00 RCX: 0000000000000000
	RDX: ffff9dfb46b78da8 RSI: ffffaaa040eb3e08 RDI: 0000000000000000
	RBP: ffff9dfb612a0a58 R08: ffffffffaf1d6270 R09: 3a34303a30303030
	R10: 34303a303030305b R11: 2078787832616c71 R12: ffff9dfb46b78dd4
	R13: ffff9dfb46b78c24 R14: ffff9dfb41525300 R15: ffff9dfb46b78da8
	FS:  0000000000000000(0000) GS:ffff9dfc67c00000(0000) knlGS:0000000000000000
	CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
	CR2: 0000000000000070 CR3: 000000018da10004 CR4: 00000000000206f0
	Call Trace:
	qla_nvme_register_remote+0xeb/0x1f0 [qla2xxx]
	? qla2x00_dfs_create_rport+0x231/0x270 [qla2xxx]
	qla2x00_update_fcport+0x2a1/0x3c0 [qla2xxx]
	qla_register_fcport_fn+0x54/0xc0 [qla2xxx]

Exit the qla_nvme_register_remote() function when qla_nvme_register_hba()
fails and correctly validate nvme_local_port.

Cc: stable@vger.kernel.org
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-3-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit eb1d4ce26095 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
1e5f77a931 qla2x00t-32gbit: Unable to act on RSCN for port online 
The device does not come online when the target port is online. There were
multiple RSCNs indicating multiple devices were affected. Driver is in the
process of finishing a fabric scan. A new RSCN (device up) arrived at the
tail end of the last fabric scan. Driver mistakenly thinks the new RSCN is
being taken care of by the previous fabric scan, where this notification is
cleared and not acted on. The laser needs to be blinked again to get the
device to show up.

To prevent driver from accidentally clearing the RSCN notification, each
RSCN is given a generation value.  A fabric scan will scan for that
generation(s).  Any new RSCN arrive after the scan start will have a new
generation value. This will trigger another scan to get latest data. The
RSCN notification flag will be cleared when the scan is associate to that
generation.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406210538.w875N70K-lkp@intel.com/
Fixes: bb2ca6b3f09a ("scsi: qla2xxx: Relogin during fabric disturbance")
Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-2-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit c3d98b12eef8 upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
e73abbd6b8 qla2x00t-32gbit: Remove unused struct 'scsi_dif_tuple' 
'scsi_dif_tuple' is unused since commit 8cb2049c7448 ("[SCSI] qla2xxx: T10
DIF - Handle uninitalized sectors.").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://lore.kernel.org/r/20240528215640.91771-1-linux@treblig.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 96281dfa266d upstream ]
 2024-09-04 14:34:12 +03:00
Gleb Chesnokov
667ef768a0 scst_local: Port to Linux kernel v6.11 
Support for the following driver core changes in the Linux kernel v6.11:

- d69d80484598 ("driver core: have match() callback in struct bus_type
  take a const *")
 2024-09-04 12:54:26 +03:00
Gleb Chesnokov
ec1b85a7e1 scst_vdisk: Port to Linux kernel v6.11 
Support for the following block layer changes in the Linux kernel v6.11:

- e9f5f44ad372 ("block: remove the blk_integrity_profile structure")
 2024-09-04 12:54:26 +03:00
Gleb Chesnokov
8c6a968083 scst_lib: Port to Linux kernel v6.11 
Support for the following block layer changes in the Linux kernel v6.11:

- e94b45d08b5d ("block: move dma_pad_mask into queue_limits")
 2024-09-04 12:54:26 +03:00
Brian M
aa086c9fb3 iscsi-scst: Add internal_portal parameter 
Add an internal_portal parameter to allow specified portals to
bypass CHAP controls for both discovery and target login.  If not
populated, then the current behavior will be preserved.
 2024-08-19 17:13:00 +03:00
Gleb Chesnokov
0b00e0af96 scst_lib: Fix VPD inquiry handling on incorrect LUNs 
When SCST receives an INQUIRY request for an incorrect LUN, it calls
scst_set_lun_not_supported_inquiry(), which returns an inquiry buffer with
a peripheral qualifier of 011b and a peripheral device type of 1Fh.
However, for a VPD inquiry, it is unable to populate the remaining fields.
According to SPC-6, if the device server cannot return the requested data,
it should terminate with CHECK CONDITION.

Reported-by: Lev Vainblat <lev@zadarastorage.com>
 2024-08-19 11:10:34 +03:00
Gleb Chesnokov
7117490910 nightly build: Update kernel versions 
Another kernel versions update.
 2024-07-15 15:18:16 +03:00
Gleb Chesnokov
faa8f460d7 scst_local, qla2x00t-32gbit: Improve Linux kernel 6.10 porting 
Fix compilation warnings, errors.
 2024-07-15 15:18:16 +03:00
Gleb Chesnokov
40675cf67d qla2x00t-32gbit: Fix debugfs output for fw_resource_count 
DebugFS output for fw_resource_count shows:

estimate exchange used[0] high water limit [1945] n        estimate iocb2 used [0] high water limit [5141]
        estimate exchange2 used[0] high water limit [1945]

Which shows incorrect display due to missing newline in seq_print().

[mkp: fix checkpatch warning about space before newline]

Fixes: 5f63a163ed2f ("scsi: qla2xxx: Fix exchange oversubscription for management commands")
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Link: https://lore.kernel.org/r/20240426020056.3639406-1-himanshu.madhani@oracle.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 998d09c5ef61 upstream ]
 2024-07-15 11:54:23 +03:00
Gleb Chesnokov
ceba304d08 qla2x00t-32gbit: Avoid possible run-time warning with long model_num 
The prior strlcpy() replacement of strncpy() here (which was
later replaced with strscpy()) expected pinfo->model_num (and
pinfo->model_description) to be NUL-terminated, but it is possible
it was not, as the code pattern here shows vha->hw->model_number (and
vha->hw->model_desc) being exactly 1 character larger, and the replaced
strncpy() was copying only up to the size of the source character
array. Replace this with memtostr(), which is the unambiguous way to
convert a maybe not-NUL-terminated character array into a NUL-terminated
string.

Fixes: 527e9b704c3d ("scsi: qla2xxx: Use memcpy() and strlcpy() instead of strcpy() and strncpy()")
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20240410023155.2100422-5-keescook@chromium.org
Signed-off-by: Kees Cook <keescook@chromium.org>
[ commit c3408c4ae041 upstream ]
 2024-07-15 11:54:23 +03:00
Gleb Chesnokov
d776e70d5c qla2x00t-32gbit: Drop driver owner assignment 
PCI core in pci_register_driver() already sets the .owner, so driver does
not need to.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240327174921.519830-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 4e64bbba5352 upstream ]
 2024-07-15 11:54:23 +03:00
Gleb Chesnokov
c3bd33a34f qla2x00t-32gbit, scst_local: Port to Linux kernel v6.10 
Support for the following scsi layer changes in the Linux kernel v6.10:

- 5b7dfbeff92a ("scsi: core: Add a dma_alignment field to the host and
  host template")
 2024-07-08 13:45:29 +03:00
Gleb Chesnokov
5f4eee5fc9 scst_lib: use bdev_nr_bytes(bdev) instead of i_size_read(bdev->bd_inode) 
Use the helper to query the size of a block device in bytes.
 2024-07-08 13:45:29 +03:00
Gleb Chesnokov
ad35eef335 scst/include/backport.h: Port to Linux kernel v6.10 
Support for the following fs layer changes in the Linux kernel v6.10:

- 7c98f7cb8fda ("remove call_{read,write}_iter() functions")
 2024-07-08 13:45:29 +03:00
Gleb Chesnokov
aa2c925429 nightly build: Update kernel versions 
Another kernel versions update.
 2024-05-17 12:36:01 +03:00
Gleb Chesnokov
7c4e07414a .github/workflows: Add a GitHub action to run regression tests upon push 
Introduce a new GitHub action that automatically runs the
scripts/run_regression_tests script upon each push to the master branch.
 2024-05-03 17:45:14 +03:00
Brian Meagher
3fba8e48e1 scst_lib: Allow REPORT LUNS to operate on an unsupported LUN 
Initiators will attempt to send LUN 0 INQUIRY and REPORT LUNS commands
when connecting to a target.

Add scst_set_lun_not_supported_report_luns to handle the case when REPORT
LUNs is sent to an unsupported LUN.

Also, in scst_set_lun_not_supported_inquiry report a valid vendor
identification string to promote better initiator behavior.
 2024-05-03 12:52:30 +03:00