Commit Graph

8211 Commits

Author SHA1 Message Date
Bart Van Assche
39bded445f Merge branch 'svn-trunk' 2021-03-23 09:18:22 -07:00
Bart Van Assche
833d83a48f scst: Add support for SERVICE ACTION IN(12)
HP LTO 3 and later and Oracle/STK T10000 tape drives support the READ MEDIA
SERIALNO command, one of the SERVICE ACTION IN(12) commands.

Signed-off-by: Rob Turk <robtu@rtist.nl>
[ bvanassche: wrote patch description ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9367 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-23 16:18:03 +00:00
Bart Van Assche
b9d7a40e26 Merge branch 'svn-trunk' 2021-03-15 21:01:40 -07:00
Bart Van Assche
ebf837baae qla2x00t-32gbit: Revert "Make sure that aborted commands are freed"
Calling vha->hw->tgt.tgt_ops->free_cmd() from qlt_xmit_response() is wrong
and may trigger a kernel crash. Hence revert this patch.

Reported-by: Chesnokov Gleb <Chesnokov.G@raidix.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9366 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-16 04:01:27 +00:00
Bart Van Assche
16932369a3 Merge branch 'svn-trunk' 2021-03-14 21:16:22 -07:00
Bart Van Assche
91c5e9f91f Set svn:global-ignores property
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9365 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 04:16:07 +00:00
Bart Van Assche
c15cdb8037 Merge branch 'svn-trunk' 2021-03-14 21:10:58 -07:00
Bart Van Assche
b41f8a8dcb .gitignore: Add *.gcno
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9364 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 04:06:56 +00:00
Bart Van Assche
620e35e138 qla2x00t-32gbit: Minimize diffs with upstream
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9363 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 04:06:16 +00:00
Bart Van Assche
449135e635 Merge branch 'svn-trunk' 2021-03-14 20:43:58 -07:00
Bart Van Assche
fe4a05b87c qla2x00t-32gbit: Minimize diffs with upstream
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9362 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:43:26 +00:00
Bart Van Assche
b4d69388f3 qla2x00t-32gbit: Minimize diffs with upstream
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9361 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:41:36 +00:00
Bart Van Assche
20d21065d4 qla2x00t-32gbit: Minimize diffs with upstream
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9360 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:40:02 +00:00
Bart Van Assche
8e51d021ec qla2xxx-32gbit: Implementation to get and manage host, target stats and initiator port
This statistics will help in debugging process and checking specific error
counts. It also provides a capability to isolate the port or bring it out
of isolation.

Link: https://lore.kernel.org/r/20210111093134.1206-2-njavali@marvell.com
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit dbf1f53cfd238090c69f92725b91208b97eb53fe upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9359 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:39:19 +00:00
Bart Van Assche
78bc3baee2 qla2x00t-32gbit: Minimize diffs with upstream
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9358 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:29:13 +00:00
Bart Van Assche
ce592d72e2 Merge branch 'svn-trunk' 2021-03-14 20:23:08 -07:00
Bart Van Assche
fdc180ec66 qla2xxx: Remove redundant NULL check
Fix below warnings reported by coccicheck:
./drivers/scsi/qla2xxx/qla_init.c:3371:2-7: WARNING: NULL check before some freeing functions is not needed.
./drivers/scsi/qla2xxx/qla_init.c:7855:5-10: WARNING: NULL check before some freeing functions is not needed.
./drivers/scsi/qla2xxx/qla_init.c:7916:2-7: WARNING: NULL check before some freeing functions is not needed.
./drivers/scsi/qla2xxx/qla_init.c:8113:4-18: WARNING: NULL check before some freeing functions is not needed.
./drivers/scsi/qla2xxx/qla_init.c:8174:2-7: WARNING: NULL check before some freeing functions is not needed.
    
Link: https://lore.kernel.org/r/1611306174-92627-1-git-send-email-abaci-bugfix@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 18c05faf8ab14913c8144108661efa8f17b10b5b upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9357 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:13:39 +00:00
Bart Van Assche
c5a5f47060 qla2xxx-32gbit: Remove unnecessary NULL check
The list iterator can't be NULL so this check is not required.  Removing
the check silences a Smatch warning about inconsistent NULL checking.

    drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
    error: we previously assumed 'fcport' could be null (see line 372)

Link: https://lore.kernel.org/r/YAkaaSrhn1mFqyHy@mwanda
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit c750a9c9c59a85843d447910a27da21c5bcf600a upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9356 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:12:51 +00:00
Bart Van Assche
69edc03f79 qla2xxx-32gbit: Assign boolean values to a bool variable
Fix the following coccicheck warnings:

./drivers/scsi/qla2xxx/qla_isr.c:780:2-18: WARNING: Assignment
of 0/1 to bool variable.

Link: https://lore.kernel.org/r/1611127919-56551-1-git-send-email-abaci-bugfix@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 71311be1cd3e2dfd75381ef8840a88ac79256ca1 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9355 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:12:07 +00:00
Bart Van Assche
fca3497c59 qla2xxx-32gbit: fc_remote_port_chkready() returns a SCSI result value
fc_remote_port_chkready() returns a SCSI result value, not the port
status. Fix the value returned when the remote port isn't set.

Link: https://lore.kernel.org/r/20210113090500.129644-34-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 6098c3005d5a39c39331ca6c3d9fa7525247166c upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9354 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:11:35 +00:00
Bart Van Assche
3a8b79eb3d qla2x00t-32gbit: Fix description for parameter ql2xenforce_iocb_limit
Parameter ql2xenforce_iocb_limit is enabled by default.

Link: https://lore.kernel.org/r/20210118184922.23793-1-ematsumiya@suse.de
Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit aa2c24e7f415e9c13635cee22ff4e15a80215551 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9353 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:11:02 +00:00
Bart Van Assche
404e3da31a qla2xxx-32gbit: Update version to 10.02.00.105-k
Link: https://lore.kernel.org/r/20210111093134.1206-8-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit dc0d9b12b8a74f5435097ebc7aafca76ba9cda7a upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9352 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:10:24 +00:00
Bart Van Assche
d097336055 qla2x00t-32gbit: Enable NVMe CONF (BIT_7) when enabling SLER
Enable NVMe confirmation bit in PRLI.

Link: https://lore.kernel.org/r/20210111093134.1206-7-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit ffa018e3a5b4a8d53dd2400fb60b5150588b57d7 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9351 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:09:49 +00:00
Bart Van Assche
5869874f10 qla2x00t-32gbit: Fix mailbox Ch erroneous error
Mailbox Ch/dump ram extend expects mb register 10 to be set. If not
set/clear, firmware can pick up garbage from previous invocation of this
mailbox. Example: mctp dump can set mb10.  On subsequent flash read which
use mailbox cmd Ch, mb10 can retain previous value.

Link: https://lore.kernel.org/r/20210111093134.1206-6-njavali@marvell.com
Cc: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 044c218b04503858ca4e17f61899c8baa0ae9ba1 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9350 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:09:15 +00:00
Bart Van Assche
9439f944f2 qla2x00t-32gbit: Wait for ABTS response on I/O timeouts for NVMe
FW needs to wait for an ABTS response before completing the I/O.

Link: https://lore.kernel.org/r/20210111093134.1206-5-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Bikash Hazarika <bhazarika@marvell.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit a04658594399e1fa25f984601b77ee840e6aaf01 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9349 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:08:33 +00:00
Bart Van Assche
512607644a qla2x00t-32gbit: Move some messages from debug to normal log level
This change will aid in debugging issues arising because of dropped frame,
DIF errors, queue full etc where debug level is not set.

Link: https://lore.kernel.org/r/20210111093134.1206-4-njavali@marvell.com
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit daaecb41a278273014c11a19b4dad73c2ca8a9ca upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9348 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:07:09 +00:00
Bart Van Assche
4b0dafc3b9 qla2x00t-32gbit: Add error counters to debugfs node
Display error counters via debugfs node.

Link: https://lore.kernel.org/r/20210111093134.1206-3-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit 307862e6697a153a5645c75d86682b75ea471369 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9347 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-03-15 03:06:29 +00:00
Bart Van Assche
821eb41561 Merge branch 'svn-trunk' 2021-02-27 19:41:06 -08:00
Bart Van Assche
ae72c4193b scst_lib: Remove the scst_store_sense() call from scst_process_check_condition()
This patch fixes an inifinite loop. See also
https://sourceforge.net/p/scst/tickets/49/.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9346 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-02-28 03:40:05 +00:00
Bart Van Assche
2b5ca6aefc Merge branch 'svn-trunk' 2021-02-23 20:43:40 -08:00
Bart Van Assche
d7bcb43d33 scst_lib: Fix scst_prepare_request_sense()
See also https://sourceforge.net/p/scst/tickets/49/.

Reported-by: Philip Pritchard
Fixes: f16c5d1b2e ("scst: Rework scst_prepare_request_sense()")



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9343 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-02-24 04:42:01 +00:00
Bart Van Assche
916af93b3c Merge branch 'svn-trunk' 2021-02-15 18:09:38 -08:00
Bart Van Assche
4affae1bb7 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9342 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-02-16 02:09:27 +00:00
Bart Van Assche
c0a838cf60 Merge branch 'svn-trunk' 2021-02-08 19:42:53 -08:00
Bart Van Assche
eb34335f2f scst: Suppress a warning in scst_cm_update_dev()
Suppress the following warning:

WARNING: CPU: 0 PID: 6998 at scst/src/scst_copy_mgr.c:2672 scst_cm_update_dev+0xdc/0x110

This warning can be triggered during unregistration of a virtual device with
the following test case:
1. Change a parameter of the virtual device, e.g. the USN.
2. Delete the LUN.

That triggers the following sequence:
1. vdev_del_device()
2. scst_unregister_virtual_device()
3. scst_acg_del_lun()
4. cancel the work struct associated with vdev_inq_changed_fn().
5. visk_detach()
6. vdev_del_device() finishes.

vdev_inq_changed_fn() may get called after a LUN has been unregistered from
the copy manager and before device deletion finishes.

Reported-by: Gleb Chesnokov <Chesnokov.G@raidix.com>




git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9341 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-02-09 03:42:26 +00:00
Bart Van Assche
c522f2448d scst: Increase the maximum READ CAPACITY(16) response buffer size
From the libiscsi source code:

        readcapacity16(sd, &rc16_task, /*alloc_len=*/96, EXPECT_STATUS_GOOD);

Hence increase the limit from 32 to 128.

Fixes: dd467b0eda ("scst: Limit the size of READ CAPACITY buffers")



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9340 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-02-09 03:37:28 +00:00
Bart Van Assche
81b8a89f58 Merge branch 'svn-trunk' 2021-02-08 19:03:23 -08:00
Vladislav Bolkhovitin
92a6dad912 Web copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9339 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-02-05 20:26:25 +00:00
Bart Van Assche
3ec42dd037 Merge branch 'svn-trunk' 2021-01-23 19:59:15 -08:00
Bart Van Assche
5a8db0e00f README.performance: Add to repository
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9338 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-01-24 03:59:03 +00:00
Bart Van Assche
3562037277 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9337 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-01-23 16:59:56 +00:00
Bart Van Assche
36d97eb604 Merge branch 'svn-trunk' 2021-01-17 12:36:02 -08:00
Bart Van Assche
dd467b0eda scst: Limit the size of READ CAPACITY buffers
Fixes: be8b679bb8 ("scst: fix tapes handling with Windows initiators")
Reported-by: James McCarthy <mccarthy1029@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9336 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-01-17 20:31:31 +00:00
Bart Van Assche
a673b482f1 Merge branch 'svn-trunk' 2021-01-17 11:17:09 -08:00
Bart Van Assche
ed0bb63c54 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9335 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-01-17 16:21:56 +00:00
Bart Van Assche
ce9ed7e36d Merge branch 'svn-trunk' 2021-01-09 17:22:30 -08:00
Bart Van Assche
48e2034307 Debian: Follow-up for r9333
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9334 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-01-10 01:22:26 +00:00
Bart Van Assche
12094ae3ec Merge branch 'svn-trunk' 2021-01-09 17:21:49 -08:00
Bart Van Assche
613e7583c2 Debian: Various package building improvements
Use a two digit revision number instead of a single digit revision number to
fix a lintian warning. Exclude .gitignore files from the source archive.
Copy the debhelper major version number into debian/compat instead of
hardcoding the compatibility level because the highest compatibility level
supported by Ubuntu 16.04 is 9 and because compatibility level 9 is considered
deprecated by Ubuntu 20.04.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9333 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-01-10 01:21:44 +00:00
Bart Van Assche
e0e4dcba2c dpkg: Use defaults if DEBEMAIL or DEBFULLNAME have not been set
This makes it easier to build a Debian package.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9332 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-01-10 01:18:07 +00:00