This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@553 d57e44dd-8a1f-0410-8b47-8ef2f437770f
to the SCST source tree. All tests are run in an automated fashion, but result
interpretation is not yet completely automated.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@552 d57e44dd-8a1f-0410-8b47-8ef2f437770f
set to m or y. The patch below fixes this.
This patch has been verified by rerunning scripts/run-regression-tests -k 2.6.27.3
and by verifying that the kernel build produced a iscsi-scst.ko kernel module.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@548 d57e44dd-8a1f-0410-8b47-8ef2f437770f
declarations by inserting the keyword static where appropriate.
This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@539 d57e44dd-8a1f-0410-8b47-8ef2f437770f
eighty columns, and more sparse warnings about missing declarations by
inserting the keyword static where appropriate. A sparse warning about a
shadowed variable (ucmd) is also fixed.
This patch has been verified by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@538 d57e44dd-8a1f-0410-8b47-8ef2f437770f
The patch below fixes the checkpatch warnings about lines that are over eighty
columns, and the sparse warnings about missing declarations by inserting the
keyword static where appropriate.
This patch has been tested by rereading the patch carefully, and by verifying
that SCST source code still compiles fine.
Also extracheck in_interrupt() was added in scst_cmd_atomic()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@531 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Add a dummy Signed-off-by line to the generated patch, such that checkpatch
doesn't complain that it's missing.
- Sort the names of source files (through ls) before using these, such that
the generated patch is the same during each run.
- Fixed a bug in #elif handling (this bug is not triggered by the current SCST
code).
This patch has been tested by comparing the output of the old and the new
generate-kernel-patch script.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@530 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Converted tabs to spaces in the help text.
- Removed command-line option '-s' -- the srpt driver is now always included.
- Recognizes now both kernel versions with three components (x.y.z) and kernel
versions with four components (x.y.z.p).
- Empty files for Kconfig and Makefile are added for those components that are
not included in the kernel patch, such that make allyesconfig
/ make allmodconfig keeps working.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@528 d57e44dd-8a1f-0410-8b47-8ef2f437770f
upcoming checkpatch version will complain about these:
* Make sure that a single tab is used for indenting instead of four spaces.
* Removed spaces from around the colon used for specifying field widths.
* Remove trailing whitespace in .txt files.
This patch has been tested by verifying that:
- the output of svn diff -x -w is empty, i.e. that the patch only affects
whitespace.
- the SCST out-of-tree source code still compiles fine against the 2.6.25 kernel
(make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@525 d57e44dd-8a1f-0410-8b47-8ef2f437770f
CONFIG_INFINIBAND_SRPT. This is a reminiscent from the time when the SRPT code
resided in the directory drivers/infiniband/ulp/srpt. Since this code has been moved
into the directory drivers/scst/srpt, the path below renames this config option
into CONFIG_SCST_SRPT. The other changes present in this patch are:
- Removed srpt/src/Makefile.infiniband.Linux-2.6.2[45].patch since these files are obsolete.
- Rewrote Kconfig help text slightly.
The patch below has been tested by verifying that the 2.6.26.5 kernel + SCST
patch still compiles cleanly with CONFIG_SCST_SRPT=m.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@518 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This patch has been tested by verifying that:
- the patched Linux 2.6.25.17 and 2.6.26.5 kernel trees still compile when
CONFIG_INFINIBAND_SRPT=m is present in .config (verified that
make -k modules only complains about a missing qla2xxx-target directory).
- the SCST out-of-tree source code still compiles fine against the 2.6.25 kernel
(make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
- checkpatch output is identical for the output of scripts/generate-kernel-patch 2.6.25
and scripts/generate-kernel-patch 2.6.26.
Based on patch from Vu Pham <vu@mellanox.com>
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@516 d57e44dd-8a1f-0410-8b47-8ef2f437770f
WARNING: externs should be avoided in .c files
This patch has been tested by verifying that the SCST sources still compile
fine (make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@515 d57e44dd-8a1f-0410-8b47-8ef2f437770f
WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
This patch has been tested by verifying that the SCST sources still compile
fine (make -s clean && make -C srpt -s clean && make -s scst iscsi-scst && make -C srpt -s).
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@514 d57e44dd-8a1f-0410-8b47-8ef2f437770f
ERROR: return is not a function, parentheses are not required
This patch has been tested by verifying that the newly generated patch still
applies without warnings to the 2.6.25.17 kernel and that the patched kernel
still compiles.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@513 d57e44dd-8a1f-0410-8b47-8ef2f437770f
* ERROR: return is not a function, parentheses are not required
* ERROR: that open brace { should be on the previous line
This patch has been tested by verifying that the newly generated patch still
applies without warnings to the 2.6.25.17 kernel and that the patched kernel
still compiles.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@512 d57e44dd-8a1f-0410-8b47-8ef2f437770f
vanilla Linux kernel version. When I submitted this script for inclusion in the
SCST Subversion repository the SRPT target driver was excluded by default
because of checkpatch errors triggered by the SRPT source code. These errors
have been fixed considerable time ago. Hence the patch below makes inclusion
of the SRPT driver the default.
This patch has been tested by verifying that the generated patch still applies
cleanly to the 2.6.25.17 kernel, and that the patched kernel still compiles cleanly.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@511 d57e44dd-8a1f-0410-8b47-8ef2f437770f
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#290: FILE: net/core/utils.c:316:
+EXPORT_SYMBOL(net_get_page_callback);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#291: FILE: net/core/utils.c:317:
+EXPORT_SYMBOL(net_put_page_callback);
This patch has been tested by verifying that the generated patch still applies
without warnings to the 2.6.25.17 kernel and that the patched kernel still
compiles.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@510 d57e44dd-8a1f-0410-8b47-8ef2f437770f
